[v8,1/8] bbdev: add big endian processing data processing info

Message ID 20211006113112.11163-2-nipun.gupta@nxp.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series baseband: add NXP LA12xx driver |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Nipun Gupta Oct. 6, 2021, 11:31 a.m. UTC
  From: Nipun Gupta <nipun.gupta@nxp.com>

This patch introduces a new info pertaining to bbdev device
to process the data in big endian order.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 lib/bbdev/rte_bbdev.h | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Chautru, Nicolas Oct. 6, 2021, 9:02 p.m. UTC | #1
Hi Nipin, 
As mentioned earlier the bbdev api change related to endianness would be more explicit as an enum. 
I have put the change here as an adjusted proposal : https://patches.dpdk.org/project/dpdk/patch/1633553929-58670-2-git-send-email-nicolas.chautru@intel.com/
I have also set default value for existing PMDs for backward compatibility and put a note in rel_notes
Let me know if unclear or other opinion
Thanks
Nic

> -----Original Message-----
> From: nipun.gupta@nxp.com <nipun.gupta@nxp.com>
> Sent: Wednesday, October 6, 2021 4:31 AM
> To: dev@dpdk.org; gakhil@marvell.com; Chautru, Nicolas
> <nicolas.chautru@intel.com>
> Cc: david.marchand@redhat.com; hemant.agrawal@nxp.com; Nipun Gupta
> <nipun.gupta@nxp.com>
> Subject: [PATCH v8 1/8] bbdev: add big endian processing data processing
> info
> 
> From: Nipun Gupta <nipun.gupta@nxp.com>
> 
> This patch introduces a new info pertaining to bbdev device to process the
> data in big endian order.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>  lib/bbdev/rte_bbdev.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index
> 3ebf62e697..9b9f9d0be6 100644
> --- a/lib/bbdev/rte_bbdev.h
> +++ b/lib/bbdev/rte_bbdev.h
> @@ -309,6 +309,8 @@ struct rte_bbdev_driver_info {
>  	uint16_t min_alignment;
>  	/** HARQ memory available in kB */
>  	uint32_t harq_buffer_size;
> +	/** Device support input, output and HARQ data as big-endian */
> +	bool support_be_data;
>  	/** Default queue configuration used if none is supplied  */
>  	struct rte_bbdev_queue_conf default_queue_conf;
>  	/** Device operation capabilities */
> --
> 2.17.1
  

Patch

diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index 3ebf62e697..9b9f9d0be6 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -309,6 +309,8 @@  struct rte_bbdev_driver_info {
 	uint16_t min_alignment;
 	/** HARQ memory available in kB */
 	uint32_t harq_buffer_size;
+	/** Device support input, output and HARQ data as big-endian */
+	bool support_be_data;
 	/** Default queue configuration used if none is supplied  */
 	struct rte_bbdev_queue_conf default_queue_conf;
 	/** Device operation capabilities */