diff mbox series

[v3,14/14] eventdev: mark trace variables as internal

Message ID 20211006065012.16508-14-pbhagavatula@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series [v3,01/14] eventdev: make driver interface as internal |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Pavan Nikhilesh Bhagavatula Oct. 6, 2021, 6:50 a.m. UTC 
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Mark rte_trace global variables as internal i.e. remove them
from experimental section of version map.
Some of them are used in inline APIs, mark those as global.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
---
 lib/eventdev/version.map | 77 ++++++++++++++++++----------------------
 1 file changed, 35 insertions(+), 42 deletions(-)

Comments

David Marchand Oct. 6, 2021, 7:11 a.m. UTC | #1 
Hello Pavan, Ray,

On Wed, Oct 6, 2021 at 8:52 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Mark rte_trace global variables as internal i.e. remove them
> from experimental section of version map.
> Some of them are used in inline APIs, mark those as global.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Please, sort those symbols.
I check with ./devtools/update-abi.sh $(cat ABI_VERSION)


> ---
>  lib/eventdev/version.map | 77 ++++++++++++++++++----------------------
>  1 file changed, 35 insertions(+), 42 deletions(-)
>
> diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> index 068d186c66..617fff0ae6 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -88,57 +88,19 @@ DPDK_22 {
>         rte_event_vector_pool_create;
>         rte_eventdevs;
>
> -       #added in 21.11
> -       rte_event_fp_ops;
> -
> -       local: *;
> -};
> -
> -EXPERIMENTAL {
> -       global:
> -
>         # added in 20.05

At the next ABI bump, ./devtools/update-abi.sh will strip those
comments from the stable section.
You can notice this when you run ./devtools/update-abi.sh $CURRENT_ABI
as suggested above.

I would strip the comments now that the symbols are going to stable.
Ray, do you have an opinion?
Jerin Jacob Oct. 14, 2021, 9:28 a.m. UTC | #2 
On Wed, Oct 6, 2021 at 12:41 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Hello Pavan, Ray,
>
> On Wed, Oct 6, 2021 at 8:52 AM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Mark rte_trace global variables as internal i.e. remove them
> > from experimental section of version map.
> > Some of them are used in inline APIs, mark those as global.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Acked-by: Ray Kinsella <mdr@ashroe.eu>
>
> Please, sort those symbols.
> I check with ./devtools/update-abi.sh $(cat ABI_VERSION)
>
>
> > ---
> >  lib/eventdev/version.map | 77 ++++++++++++++++++----------------------
> >  1 file changed, 35 insertions(+), 42 deletions(-)
> >
> > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> > index 068d186c66..617fff0ae6 100644
> > --- a/lib/eventdev/version.map
> > +++ b/lib/eventdev/version.map
> > @@ -88,57 +88,19 @@ DPDK_22 {
> >         rte_event_vector_pool_create;
> >         rte_eventdevs;
> >
> > -       #added in 21.11
> > -       rte_event_fp_ops;
> > -
> > -       local: *;
> > -};
> > -
> > -EXPERIMENTAL {
> > -       global:
> > -
> >         # added in 20.05
>
> At the next ABI bump, ./devtools/update-abi.sh will strip those
> comments from the stable section.
> You can notice this when you run ./devtools/update-abi.sh $CURRENT_ABI
> as suggested above.

Please do the David suggestion on sorting the map file.

> I would strip the comments now that the symbols are going to stable.
> Ray, do you have an opinion?
>
>
> --
> David Marchand
>
diff mbox series

Patch

diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index 068d186c66..617fff0ae6 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -88,57 +88,19 @@  DPDK_22 {
 	rte_event_vector_pool_create;
 	rte_eventdevs;
 
-	#added in 21.11
-	rte_event_fp_ops;
-
-	local: *;
-};
-
-EXPERIMENTAL {
-	global:
-
 	# added in 20.05
-	__rte_eventdev_trace_configure;
-	__rte_eventdev_trace_queue_setup;
-	__rte_eventdev_trace_port_link;
-	__rte_eventdev_trace_port_unlink;
-	__rte_eventdev_trace_start;
-	__rte_eventdev_trace_stop;
-	__rte_eventdev_trace_close;
+	__rte_eventdev_trace_crypto_adapter_enqueue;
 	__rte_eventdev_trace_deq_burst;
 	__rte_eventdev_trace_enq_burst;
-	__rte_eventdev_trace_eth_rx_adapter_create;
-	__rte_eventdev_trace_eth_rx_adapter_free;
-	__rte_eventdev_trace_eth_rx_adapter_queue_add;
-	__rte_eventdev_trace_eth_rx_adapter_queue_del;
-	__rte_eventdev_trace_eth_rx_adapter_start;
-	__rte_eventdev_trace_eth_rx_adapter_stop;
-	__rte_eventdev_trace_eth_tx_adapter_create;
-	__rte_eventdev_trace_eth_tx_adapter_free;
-	__rte_eventdev_trace_eth_tx_adapter_queue_add;
-	__rte_eventdev_trace_eth_tx_adapter_queue_del;
-	__rte_eventdev_trace_eth_tx_adapter_start;
-	__rte_eventdev_trace_eth_tx_adapter_stop;
 	__rte_eventdev_trace_eth_tx_adapter_enqueue;
-	__rte_eventdev_trace_timer_adapter_create;
-	__rte_eventdev_trace_timer_adapter_start;
-	__rte_eventdev_trace_timer_adapter_stop;
-	__rte_eventdev_trace_timer_adapter_free;
 	__rte_eventdev_trace_timer_arm_burst;
 	__rte_eventdev_trace_timer_arm_tmo_tick_burst;
 	__rte_eventdev_trace_timer_cancel_burst;
-	__rte_eventdev_trace_crypto_adapter_create;
-	__rte_eventdev_trace_crypto_adapter_free;
-	__rte_eventdev_trace_crypto_adapter_queue_pair_add;
-	__rte_eventdev_trace_crypto_adapter_queue_pair_del;
-	__rte_eventdev_trace_crypto_adapter_start;
-	__rte_eventdev_trace_crypto_adapter_stop;
 
-	# changed in 20.11
-	__rte_eventdev_trace_port_setup;
+	#added in 21.11
+	rte_event_fp_ops;
 
-	#added in 21.05
-	__rte_eventdev_trace_crypto_adapter_enqueue;
+	local: *;
 };
 
 INTERNAL {
@@ -157,4 +119,35 @@  INTERNAL {
 	rte_event_pmd_release;
 	rte_event_pmd_vdev_init;
 	rte_event_pmd_vdev_uninit;
+
+	__rte_eventdev_trace_close;
+	__rte_eventdev_trace_configure;
+	__rte_eventdev_trace_crypto_adapter_create;
+	__rte_eventdev_trace_crypto_adapter_free;
+	__rte_eventdev_trace_crypto_adapter_queue_pair_add;
+	__rte_eventdev_trace_crypto_adapter_queue_pair_del;
+	__rte_eventdev_trace_crypto_adapter_start;
+	__rte_eventdev_trace_crypto_adapter_stop;
+	__rte_eventdev_trace_eth_rx_adapter_create;
+	__rte_eventdev_trace_eth_rx_adapter_free;
+	__rte_eventdev_trace_eth_rx_adapter_queue_add;
+	__rte_eventdev_trace_eth_rx_adapter_queue_del;
+	__rte_eventdev_trace_eth_rx_adapter_start;
+	__rte_eventdev_trace_eth_rx_adapter_stop;
+	__rte_eventdev_trace_eth_tx_adapter_create;
+	__rte_eventdev_trace_eth_tx_adapter_free;
+	__rte_eventdev_trace_eth_tx_adapter_queue_add;
+	__rte_eventdev_trace_eth_tx_adapter_queue_del;
+	__rte_eventdev_trace_eth_tx_adapter_start;
+	__rte_eventdev_trace_eth_tx_adapter_stop;
+	__rte_eventdev_trace_port_link;
+	__rte_eventdev_trace_port_setup;
+	__rte_eventdev_trace_port_unlink;
+	__rte_eventdev_trace_queue_setup;
+	__rte_eventdev_trace_start;
+	__rte_eventdev_trace_stop;
+	__rte_eventdev_trace_timer_adapter_create;
+	__rte_eventdev_trace_timer_adapter_free;
+	__rte_eventdev_trace_timer_adapter_start;
+	__rte_eventdev_trace_timer_adapter_stop;
 };