[v3,3/4] cryptodev: build on Windows

Message ID 20211002003344.594-4-u9012063@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series net/ixgbe: Add support for Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

William Tu Oct. 2, 2021, 12:33 a.m. UTC
  From: Tal Shnaiderman <talshn@nvidia.com>

Build the cryptography device library on Windows OS
by removing unneeded include and exports blocking the
compilation.

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: William Tu <u9012063@gmail.com>
---
 lib/cryptodev/cryptodev_pmd.c | 2 ++
 lib/cryptodev/rte_cryptodev.c | 1 -
 lib/cryptodev/version.map     | 2 --
 lib/meson.build               | 1 +
 4 files changed, 3 insertions(+), 3 deletions(-)
  

Comments

Akhil Goyal Oct. 5, 2021, 10:53 a.m. UTC | #1
> From: Tal Shnaiderman <talshn@nvidia.com>
> 
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Acked-by: William Tu <u9012063@gmail.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
  

Patch

diff --git a/lib/cryptodev/cryptodev_pmd.c b/lib/cryptodev/cryptodev_pmd.c
index 71e34140cd..44a70ecb35 100644
--- a/lib/cryptodev/cryptodev_pmd.c
+++ b/lib/cryptodev/cryptodev_pmd.c
@@ -2,6 +2,8 @@ 
  * Copyright(c) 2017 Intel Corporation
  */
 
+#include <sys/queue.h>
+
 #include <rte_string_fns.h>
 #include <rte_malloc.h>
 
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index 9fa3aff1d3..b913c434c5 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -12,7 +12,6 @@ 
 #include <errno.h>
 #include <stdint.h>
 #include <inttypes.h>
-#include <netinet/in.h>
 
 #include <rte_byteorder.h>
 #include <rte_log.h>
diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
index 8294c9f64f..43cf937e40 100644
--- a/lib/cryptodev/version.map
+++ b/lib/cryptodev/version.map
@@ -93,10 +93,8 @@  EXPERIMENTAL {
 	# added in 20.11
 	rte_cryptodev_configure_raw_dp_ctx;
 	rte_cryptodev_get_raw_dp_ctx_size;
-	rte_cryptodev_raw_dequeue;
 	rte_cryptodev_raw_dequeue_burst;
 	rte_cryptodev_raw_dequeue_done;
-	rte_cryptodev_raw_enqueue;
 	rte_cryptodev_raw_enqueue_burst;
 	rte_cryptodev_raw_enqueue_done;
 
diff --git a/lib/meson.build b/lib/meson.build
index 95b0ea41c4..e5f0094a82 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -80,6 +80,7 @@  if is_windows
             'hash',
             'timer',
             'bitratestats',
+            'cryptodev',
             'cfgfile',
             'gro',
             'gso',