diff mbox series

net/mlx5: fix flow tables double release

Message ID 20210928040851.56636-1-bingz@nvidia.com (mailing list archive)
State Accepted
Delegated to: Raslan Darawsheh
Headers show
Series net/mlx5: fix flow tables double release | expand

Checks

Context Check Description
ci/iol-testing warning apply patch failure
ci/github-robot: build success github build: passed
ci/checkpatch success coding style OK

Commit Message

Bing Zhao Sept. 28, 2021, 4:08 a.m. UTC
In the function mlx5_alloc_shared_dr(), there are various reasons
to result in a failure and error clean up process. While in the
caller of mlx5_dev_spawn(), once there is a error occurring after
the mlx5_alloc_shared_dr(), the mlx5_os_free_shared_dr() is called
to release all the resources.

To prevent a double release, the pointers of the resources should
be checked before the releasing and set to NULL after done.

In the mlx5_free_table_hash_list(), after the releasing, the pointer
was missed to set to NULL and a double release may cause a crash.

By setting the tables pointer to NULL as done for other resources,
the double release and crash could be solved.

Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
Cc: matan@mellanox.com
Cc: stable@dpdk.org

Signed-off-by: Bing Zhao <bingz@nvidia.com>
---
 drivers/net/mlx5/mlx5.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Matan Azrad Sept. 29, 2021, 7:55 a.m. UTC | #1
From: Bing Zhao
> In the function mlx5_alloc_shared_dr(), there are various reasons to result in
> a failure and error clean up process. While in the caller of mlx5_dev_spawn(),
> once there is a error occurring after the mlx5_alloc_shared_dr(), the
> mlx5_os_free_shared_dr() is called to release all the resources.
> 
> To prevent a double release, the pointers of the resources should be
> checked before the releasing and set to NULL after done.
> 
> In the mlx5_free_table_hash_list(), after the releasing, the pointer was
> missed to set to NULL and a double release may cause a crash.
> 
> By setting the tables pointer to NULL as done for other resources, the double
> release and crash could be solved.
> 
> Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
> Cc: matan@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Thomas Monjalon Sept. 29, 2021, 8:46 p.m. UTC | #2
29/09/2021 09:55, Matan Azrad:
> From: Bing Zhao
> > In the function mlx5_alloc_shared_dr(), there are various reasons to result in
> > a failure and error clean up process. While in the caller of mlx5_dev_spawn(),
> > once there is a error occurring after the mlx5_alloc_shared_dr(), the
> > mlx5_os_free_shared_dr() is called to release all the resources.
> > 
> > To prevent a double release, the pointers of the resources should be
> > checked before the releasing and set to NULL after done.
> > 
> > In the mlx5_free_table_hash_list(), after the releasing, the pointer was
> > missed to set to NULL and a double release may cause a crash.
> > 
> > By setting the tables pointer to NULL as done for other resources, the double
> > release and crash could be solved.
> > 
> > Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
> > Cc: matan@mellanox.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Applied in next-net-mlx, thanks.
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 02ea2e781e..3c10f186e6 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1369,6 +1369,7 @@  mlx5_free_table_hash_list(struct mlx5_priv *priv)
 	if (!sh->flow_tbls)
 		return;
 	mlx5_hlist_destroy(sh->flow_tbls);
+	sh->flow_tbls = NULL;
 }
 
 /**