| Message ID | 20210924102942.2878051-9-bruce.richardson@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | add test suite for DMA drivers | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
On 24/09/2021 11:29, Bruce Richardson wrote: > When running the dmadev_autotest, run the suite of copy tests on the > skeleton driver created for API testing too, rather than just destroying > the driver instances once the API tests are complete. This helps to > sanity check the tests themselves are reasonable. > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > --- > app/test/test_dmadev.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index 21600686e8..c26329e63d 100644 --- a/app/test/test_dmadev.c +++ b/app/test/test_dmadev.c @@ -255,14 +255,13 @@ test_apis(void) int id; int ret; - if (rte_vdev_init(pmd, NULL) < 0) - return TEST_SKIPPED; + /* attempt to create skeleton instance - ignore errors due to one being already present */ + rte_vdev_init(pmd, NULL); id = rte_dma_get_dev_id(pmd); if (id < 0) return TEST_SKIPPED; printf("\n### Test dmadev infrastructure using skeleton driver\n"); ret = test_dma_api(id); - rte_vdev_uninit(pmd); return ret; }
When running the dmadev_autotest, run the suite of copy tests on the skeleton driver created for API testing too, rather than just destroying the driver instances once the API tests are complete. This helps to sanity check the tests themselves are reasonable. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- app/test/test_dmadev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)