diff mbox series

[v2] eal: reword logs for CPU and NUMA counts

Message ID 20210916103209.3710442-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] eal: reword logs for CPU and NUMA counts |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/github-robot: build success github build: passed
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing fail Testing issues
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Thomas Monjalon Sept. 16, 2021, 10:32 a.m. UTC 
  Some logs about cores and nodes were using hypotetic plural (s) form.
A fixed plural form with value at the end is preferred.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: keep plural form as suggested by Bruce
---
 lib/eal/common/eal_common_lcore.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Thomas Monjalon Sept. 16, 2021, 10:39 a.m. UTC | #1 
16/09/2021 12:32, Thomas Monjalon:
> Some logs about cores and nodes were using hypotetic plural (s) form.
> A fixed plural form with value at the end is preferred.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: keep plural form as suggested by Bruce
> ---
>  lib/eal/common/eal_common_lcore.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
> index 66d6bad1a7..b38bb46d44 100644
> --- a/lib/eal/common/eal_common_lcore.c
> +++ b/lib/eal/common/eal_common_lcore.c
> @@ -191,9 +191,9 @@ rte_eal_cpu_init(void)
>  	/* Set the count of enabled logical cores of the EAL configuration */
>  	config->lcore_count = count;
>  	RTE_LOG(DEBUG, EAL,
> -		"Support maximum %u logical core(s) by configuration.\n",
> -		RTE_MAX_LCORE);
> -	RTE_LOG(INFO, EAL, "Detected %u lcore(s)\n", config->lcore_count);
> +			"Maximum logical cores by configuration: %u\n",
> +			RTE_MAX_LCORE);
> +	RTE_LOG(INFO, EAL, "Detected CPU lcores: %u\n",config->lcore_count);

space missing above, consider it as fixed ;)

>  
>  	/* sort all socket id's in ascending order */
>  	qsort(lcore_to_socket_id, RTE_DIM(lcore_to_socket_id),
> @@ -208,7 +208,7 @@ rte_eal_cpu_init(void)
>  					socket_id;
>  		prev_socket_id = socket_id;
>  	}
> -	RTE_LOG(INFO, EAL, "Detected %u NUMA nodes\n", config->numa_node_count);
> +	RTE_LOG(INFO, EAL, "Detected NUMA nodes: %u\n", config->numa_node_count);
>  
>  	return 0;
>  }
>
Bruce Richardson Sept. 16, 2021, 10:41 a.m. UTC | #2 
On Thu, Sep 16, 2021 at 12:39:20PM +0200, Thomas Monjalon wrote:
> 16/09/2021 12:32, Thomas Monjalon:
> > Some logs about cores and nodes were using hypotetic plural (s) form.
> > A fixed plural form with value at the end is preferred.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > v2: keep plural form as suggested by Bruce
> > ---
> >  lib/eal/common/eal_common_lcore.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Sept. 23, 2021, 6:51 a.m. UTC | #3 
16/09/2021 12:41, Bruce Richardson:
> On Thu, Sep 16, 2021 at 12:39:20PM +0200, Thomas Monjalon wrote:
> > 16/09/2021 12:32, Thomas Monjalon:
> > > Some logs about cores and nodes were using hypotetic plural (s) form.
> > > A fixed plural form with value at the end is preferred.
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > > v2: keep plural form as suggested by Bruce
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied
diff mbox series

Patch

diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
index 66d6bad1a7..b38bb46d44 100644
--- a/lib/eal/common/eal_common_lcore.c
+++ b/lib/eal/common/eal_common_lcore.c
@@ -191,9 +191,9 @@  rte_eal_cpu_init(void)
 	/* Set the count of enabled logical cores of the EAL configuration */
 	config->lcore_count = count;
 	RTE_LOG(DEBUG, EAL,
-		"Support maximum %u logical core(s) by configuration.\n",
-		RTE_MAX_LCORE);
-	RTE_LOG(INFO, EAL, "Detected %u lcore(s)\n", config->lcore_count);
+			"Maximum logical cores by configuration: %u\n",
+			RTE_MAX_LCORE);
+	RTE_LOG(INFO, EAL, "Detected CPU lcores: %u\n",config->lcore_count);
 
 	/* sort all socket id's in ascending order */
 	qsort(lcore_to_socket_id, RTE_DIM(lcore_to_socket_id),
@@ -208,7 +208,7 @@  rte_eal_cpu_init(void)
 					socket_id;
 		prev_socket_id = socket_id;
 	}
-	RTE_LOG(INFO, EAL, "Detected %u NUMA nodes\n", config->numa_node_count);
+	RTE_LOG(INFO, EAL, "Detected NUMA nodes: %u\n", config->numa_node_count);
 
 	return 0;
 }