diff mbox series

examples/kni: add dev close step when kni free

Message ID 20210914060219.45890-1-humin29@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series examples/kni: add dev close step when kni free |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing fail Testing issues
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

humin (Q) Sept. 14, 2021, 6:02 a.m. UTC 
  From: Huisong Li <lihuisong@huawei.com>

This patch adds dev_close() step to release network adapter resources
when kni free.

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 examples/kni/main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit Sept. 21, 2021, 7:48 a.m. UTC | #1 
On 9/14/2021 7:02 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds dev_close() step to release network adapter resources
> when kni free.
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>  examples/kni/main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/examples/kni/main.c b/examples/kni/main.c
> index beabb3c848..2a993a0ca4 100644
> --- a/examples/kni/main.c
> +++ b/examples/kni/main.c
> @@ -1031,6 +1031,7 @@ kni_free_kni(uint16_t port_id)
>  	if (ret != 0)
>  		RTE_LOG(ERR, APP, "Failed to stop port %d: %s\n",
>  			port_id, rte_strerror(-ret));
> +	rte_eth_dev_close(port_id);
>  
>  	return 0;
>  }
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Closing the port not directly related to the 'kni free', just both done before
exiting the app, so I would update the patch title to something like:
examples/kni: close port before exit
Thomas Monjalon Oct. 6, 2021, 2:52 p.m. UTC | #2 
21/09/2021 09:48, Ferruh Yigit:
> On 9/14/2021 7:02 AM, Min Hu (Connor) wrote:
> > From: Huisong Li <lihuisong@huawei.com>
> > 
> > This patch adds dev_close() step to release network adapter resources
> > when kni free.
> > 
> > Signed-off-by: Huisong Li <lihuisong@huawei.com>
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Closing the port not directly related to the 'kni free', just both done before
> exiting the app, so I would update the patch title to something like:
> examples/kni: close port before exit

Applied, with suggested title, thanks.
diff mbox series

Patch

diff --git a/examples/kni/main.c b/examples/kni/main.c
index beabb3c848..2a993a0ca4 100644
--- a/examples/kni/main.c
+++ b/examples/kni/main.c
@@ -1031,6 +1031,7 @@  kni_free_kni(uint16_t port_id)
 	if (ret != 0)
 		RTE_LOG(ERR, APP, "Failed to stop port %d: %s\n",
 			port_id, rte_strerror(-ret));
+	rte_eth_dev_close(port_id);
 
 	return 0;
 }