diff mbox series

cryptodev: build on Windows

Message ID 20210913171658.3664-1-talshn@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series cryptodev: build on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Tal Shnaiderman Sept. 13, 2021, 5:16 p.m. UTC 
  Build the cryptography device library on Windows OS
by removing unneeded include and exports blocking the
compilation.

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
 lib/cryptodev/rte_cryptodev.c | 1 -
 lib/cryptodev/version.map     | 2 --
 lib/meson.build               | 1 +
 3 files changed, 1 insertion(+), 3 deletions(-)

Comments

William Tu Sept. 19, 2021, 2:03 p.m. UTC | #1 
On Mon, Sep 13, 2021 at 10:19 AM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>

Acked-by: William Tu <u9012063@gmail.com>

I sent similar patch to enable ixgbe support for windows.
http://inbox.dpdk.org/dev/CALDO+SY_YkdV+Dx-dUJx8cyqafL6HdL=09DrOGCUBeonH2bPrA@mail.gmail.com/T/#t
Kadam, Pallavi Sept. 23, 2021, 6:07 p.m. UTC | #2 
On 9/13/2021 10:16 AM, Tal Shnaiderman wrote:
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---

Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>

>
Akhil Goyal Oct. 5, 2021, 10:39 a.m. UTC | #3 
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied to dpdk-next-crypto

Thanks.
Akhil Goyal Oct. 5, 2021, 10:50 a.m. UTC | #4 
> > Build the cryptography device library on Windows OS
> > by removing unneeded include and exports blocking the
> > compilation.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> Applied to dpdk-next-crypto
Removing this patch from dpdk-next-crypto as the patch is superseded
With another series delegated to Thomas.
http://patches.dpdk.org/project/dpdk/cover/20211002003344.594-1-u9012063@gmail.com/

Please ensure previous versions are marked superseded or else it will create
Unnecessary issues while merging.
Tal Shnaiderman Oct. 5, 2021, 12:12 p.m. UTC | #5 
> Subject: RE: [EXT] [PATCH] cryptodev: build on Windows
> 
> External email: Use caution opening links or attachments
> 
> 
> > > Build the cryptography device library on Windows OS by removing
> > > unneeded include and exports blocking the compilation.
> > >
> > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > > ---
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > Applied to dpdk-next-crypto
> Removing this patch from dpdk-next-crypto as the patch is superseded With
> another series delegated to Thomas.
> http://patches.dpdk.org/project/dpdk/cover/20211002003344.594-1-
> u9012063@gmail.com/
> 
> Please ensure previous versions are marked superseded or else it will create
> Unnecessary issues while merging.
> 
> 

Thanks, you're right, I superseded the security patches but didn't notice a v3 for crypto was also sent.
diff mbox series

Patch

diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index 9fa3aff1d3..b913c434c5 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -12,7 +12,6 @@ 
 #include <errno.h>
 #include <stdint.h>
 #include <inttypes.h>
-#include <netinet/in.h>
 
 #include <rte_byteorder.h>
 #include <rte_log.h>
diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
index 8294c9f64f..43cf937e40 100644
--- a/lib/cryptodev/version.map
+++ b/lib/cryptodev/version.map
@@ -93,10 +93,8 @@  EXPERIMENTAL {
 	# added in 20.11
 	rte_cryptodev_configure_raw_dp_ctx;
 	rte_cryptodev_get_raw_dp_ctx_size;
-	rte_cryptodev_raw_dequeue;
 	rte_cryptodev_raw_dequeue_burst;
 	rte_cryptodev_raw_dequeue_done;
-	rte_cryptodev_raw_enqueue;
 	rte_cryptodev_raw_enqueue_burst;
 	rte_cryptodev_raw_enqueue_done;
 
diff --git a/lib/meson.build b/lib/meson.build
index 1673ca4323..5f3b1cf365 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -80,6 +80,7 @@  if is_windows
             'hash',
             'timer',
             'bitratestats',
+            'cryptodev',
             'cfgfile',
             'gro',
             'gso',