From patchwork Mon Sep 13 14:02:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 98746 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E359A0C45; Mon, 13 Sep 2021 16:04:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5696410E1; Mon, 13 Sep 2021 16:04:02 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2047.outbound.protection.outlook.com [40.107.93.47]) by mails.dpdk.org (Postfix) with ESMTP id 7F3EC40151; Mon, 13 Sep 2021 16:04:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vm+IzagNyFAhxiy52RWKOTD8sfy17kmgerw2vcw0oXx55qWIerQYIMdu7W8t8Wz0Fijkj+7ZZK3wcZh1ZBcqylA+HToX6g5Y94trsds/gM5hYW2/gyXLD/3021GEQp+dWLHOtMDdp2vfqrJi+sKIpIFZFnu+Z06VLhfhKdNMxwqNqunXAxMoSNLCbvKTlX9IL6CI5VX4FG8LHupMxgG6+OWpLVUTGmAMvLI3stahuGwiHmBB5Ddx/eK2uqgcHig75FU7aGuDouXOubgxxlVYH3jor76SEd7K/c3ftRwwT1hU5ow3cf09fL+vbHpaQkiJwDj6bQITzPoh1EkdIk7e1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7MIn1jTcMrRkvd43QEVXNzFOTg90GGZsmL2+GXKH0Yg=; b=j7AGMp3Ixq5SOko/vyNVQic7j1tYpn430oPTa9SVvIACVTruGOPsocl0QWX/EcyH0kIgQxa03qeEh+VWwK5xzaOpE/C5ih/lTXhIbqmYbpjdkgLZ7cEkopbkqn4eCgTNuMvfwW6c1aOM34IbKkvjfR1lE5yHU/2QKvbxD9xnQwAHxWdmrpCPcjeVyxKc+AbSKTFIkECxToeijAp3K9PNaDkYo2vo4EN6viS/pWbEO8g+p8IPl4fbRS7Dt5Nu1kXw18t/HRpwxzVmjxbKVp1qQO+FhMuit7rs5bnpNl7c27cv24lVcGKyDty0LVp6P5NYzgIstCJDHV3uuLsbcPanyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7MIn1jTcMrRkvd43QEVXNzFOTg90GGZsmL2+GXKH0Yg=; b=Ww0okwk+Kx4nKlBkK08zfMWdTTSpEsUvXOpUKIqEVoeCMiz2Mz3vASYTBT2XGLAnZb7xdlWVBEGC5g1RcJHWTtWJ2sL1DnzKksgIdkSxETNFEosusi6nqNsuFJsjHi/yPx/8Vm9ncK14k2iSuTZzumMPjJhw32Ij3jVTiS0PwBPPUbS4GQ+jyfu24HxJA2QzcZ836l6r+LhHz5rzw+oDhONQ4aBgVupqbVQUtGJcTi+W8u3AvwWzwWHArOsQSvcVTt5KIxktoe1QrCZrw3tFCMRawntltt+o8jKytR/yq5KPAwCYUZfoJq1Y6JaWhEFxcp7KTz2xTN2YXQpkL/iRzw== Received: from BN6PR14CA0010.namprd14.prod.outlook.com (2603:10b6:404:79::20) by BYAPR12MB4727.namprd12.prod.outlook.com (2603:10b6:a03:99::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Mon, 13 Sep 2021 14:03:59 +0000 Received: from BN8NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:404:79:cafe::86) by BN6PR14CA0010.outlook.office365.com (2603:10b6:404:79::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 14:03:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT061.mail.protection.outlook.com (10.13.177.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 14:03:57 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 13 Sep 2021 14:02:51 +0000 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 13 Sep 2021 14:02:49 +0000 From: Tal Shnaiderman To: CC: , , , , , Date: Mon, 13 Sep 2021 17:02:24 +0300 Message-ID: <20210913140224.18788-1-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18e44a68-39d9-4eab-3d67-08d976bf5432 X-MS-TrafficTypeDiagnostic: BYAPR12MB4727: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GvO+oyobNi0NLNkocO2KGBcSsT9iqXOEMuxik4+APKOV3uoqml0LieWe2Lah+I8H75NDlXRnH08hu+VBQONzdF40gYyHUy/VY+/TjEG4wRvEotdHZyXT4D7K6hWKn4qOSxQZrlDjW6huxLRfc2i8BYpH2gcSxS/eGw08yBxISE2lybX3g3r6Ygc2uSZYBAx1Q+hv41sXT1J+6TpGQ9zESMl0ciIcki1tPn7mHwI/covYHQstGaRJWLf+s7J4fODb0ppfhA1HHatpV2qDpHzhjQz3hETQJUEv9Gi3nqXr46rLD66WbXysuhBT8EUN3o1Vo309iM+61oyNs4W8Xg2+U0hcvMRFtEbPwyoMTJdrNi/ujaqdOJ1o4vHip2sWQ6B0DUrOu92mLF/r2HgD+4LRDR47tbSSUXTg9gS2Aa+x1bo9Goz1MgaXVJJXogMCb+qZgUXS1FCiwpA7raj4NBRKES6UsKCiZ7VBtk5bZolHGbFJpvryd2yYnfhHMCxJGjf+APWuaHuLKHJfMqRdbA1IzMxArC412AwMNSVlGF8Zl5chs7ycl5XkYsQHC5IxELYzVMmPcTDUCrnj7msQwzGolUk/8cdfQ1a5q+US+m5juZYTaRdNFOUtBzBIbFOfHtSP6El95TELOewfJcBYoFnna25cgaBf/RglPVOu3nlDZ13Nbr8fR2YxyInhIiXBdzsNx7PuxFmM1ek93YGVcY0GUQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(46966006)(36840700001)(55016002)(316002)(8676002)(356005)(4326008)(70206006)(336012)(36860700001)(26005)(16526019)(6916009)(36756003)(86362001)(6286002)(70586007)(6666004)(5660300002)(54906003)(478600001)(82310400003)(47076005)(1076003)(8936002)(2906002)(426003)(186003)(7696005)(2616005)(82740400003)(7636003)(36906005)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 14:03:57.1306 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18e44a68-39d9-4eab-3d67-08d976bf5432 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4727 Subject: [dpdk-dev] [PATCH] crypto/mlx5: fix crypto QP indexing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The crypto QP consumer (ci) and producer (pi) indexes are increased with each successful enqueue/dequeue operations. However the QP pi index is calculated with a wraparound the number of elements while the QP ci does not. This is causing incorrect engine calculation for encqueued WQ values (wq->pi - wq->ci) and eventually the device stops accepting new enqueue operations. Fixed by removing the wraparound on QP pi and using a temp calculation where wraparound values are needed. Fixes: 8e196c08ab53 ("crypto/mlx5: support enqueue/dequeue operations") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index b3d5200ca3..eeec554e6e 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -494,6 +494,7 @@ mlx5_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops, struct rte_crypto_op *op; uint16_t mask = qp->entries_n - 1; uint16_t remain = qp->entries_n - (qp->pi - qp->ci); + uint32_t idx; if (remain < nb_ops) nb_ops = remain; @@ -502,8 +503,9 @@ mlx5_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops, if (unlikely(remain == 0)) return 0; do { + idx = qp->pi & mask; op = *ops++; - umr = RTE_PTR_ADD(qp->umem_buf, priv->wqe_set_size * qp->pi); + umr = RTE_PTR_ADD(qp->umem_buf, priv->wqe_set_size * idx); if (unlikely(mlx5_crypto_wqe_set(priv, qp, op, umr) == 0)) { qp->stats.enqueue_err_count++; if (remain != nb_ops) { @@ -512,8 +514,8 @@ mlx5_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops, } return 0; } - qp->ops[qp->pi] = op; - qp->pi = (qp->pi + 1) & mask; + qp->ops[idx] = op; + qp->pi++; } while (--remain); qp->stats.enqueued_count += nb_ops; rte_io_wmb();