diff mbox series

net: promote make rarp packet API as stable

Message ID 20210908105915.73420-1-xiao.w.wang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers show
Series net: promote make rarp packet API as stable | expand

Checks

Context Check Description
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Wang, Xiao W Sept. 8, 2021, 10:59 a.m. UTC
rte_net_make_rarp_packet was introduced in version v18.02, there was no
change in this public API since then, and it's still being used by vhost
lib and virtio driver, so promote it as stable ABI.

Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
 lib/net/rte_arp.h   | 4 ----
 lib/net/version.map | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Stephen Hemminger Sept. 8, 2021, 4:52 a.m. UTC | #1
On Wed,  8 Sep 2021 18:59:15 +0800
Xiao Wang <xiao.w.wang@intel.com> wrote:

> rte_net_make_rarp_packet was introduced in version v18.02, there was no
> change in this public API since then, and it's still being used by vhost
> lib and virtio driver, so promote it as stable ABI.
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Xia, Chenbo Sept. 8, 2021, 5:07 a.m. UTC | #2
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiao Wang
> Sent: Wednesday, September 8, 2021 6:59 PM
> To: olivier.matz@6wind.com
> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable
> 
> rte_net_make_rarp_packet was introduced in version v18.02, there was no
> change in this public API since then, and it's still being used by vhost
> lib and virtio driver, so promote it as stable ABI.
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  lib/net/rte_arp.h   | 4 ----
>  lib/net/version.map | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/lib/net/rte_arp.h b/lib/net/rte_arp.h
> index feb0eb3e49..076c8ab314 100644
> --- a/lib/net/rte_arp.h
> +++ b/lib/net/rte_arp.h
> @@ -50,9 +50,6 @@ struct rte_arp_hdr {
>  } __rte_packed __rte_aligned(2);
> 
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
>   * Make a RARP packet based on MAC addr.
>   *
>   * @param mpool
> @@ -63,7 +60,6 @@ struct rte_arp_hdr {
>   * @return
>   *   - RARP packet pointer on success, or NULL on error
>   */
> -__rte_experimental
>  struct rte_mbuf *
>  rte_net_make_rarp_packet(struct rte_mempool *mpool,
>  		const struct rte_ether_addr *mac);
> diff --git a/lib/net/version.map b/lib/net/version.map
> index 355b7c25b4..7584018d58 100644
> --- a/lib/net/version.map
> +++ b/lib/net/version.map
> @@ -6,6 +6,7 @@ DPDK_22 {
>  	rte_net_crc_calc;
>  	rte_net_crc_set_alg;
>  	rte_net_get_ptype;
> +	rte_net_make_rarp_packet;
> 
>  	local: *;
>  };
> @@ -13,7 +14,6 @@ DPDK_22 {
>  EXPERIMENTAL {
>  	global:
> 
> -	rte_net_make_rarp_packet;
>  	rte_net_skip_ip6_ext;
>  	rte_ether_unformat_addr;
>  };
> --
> 2.15.1

Acked-by: Chenbo Xia <chenbo.xia@intel.com>
Olivier Matz Sept. 16, 2021, 11:38 a.m. UTC | #3
On Wed, Sep 08, 2021 at 06:59:15PM +0800, Xiao Wang wrote:
> rte_net_make_rarp_packet was introduced in version v18.02, there was no
> change in this public API since then, and it's still being used by vhost
> lib and virtio driver, so promote it as stable ABI.
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
David Marchand Oct. 2, 2021, 8:57 a.m. UTC | #4
On Thu, Sep 16, 2021 at 1:38 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Wed, Sep 08, 2021 at 06:59:15PM +0800, Xiao Wang wrote:
> > rte_net_make_rarp_packet was introduced in version v18.02, there was no
> > change in this public API since then, and it's still being used by vhost
> > lib and virtio driver, so promote it as stable ABI.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Chenbo Xia <chenbo.xia@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>


Applied, thanks.
diff mbox series

Patch

diff --git a/lib/net/rte_arp.h b/lib/net/rte_arp.h
index feb0eb3e49..076c8ab314 100644
--- a/lib/net/rte_arp.h
+++ b/lib/net/rte_arp.h
@@ -50,9 +50,6 @@  struct rte_arp_hdr {
 } __rte_packed __rte_aligned(2);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Make a RARP packet based on MAC addr.
  *
  * @param mpool
@@ -63,7 +60,6 @@  struct rte_arp_hdr {
  * @return
  *   - RARP packet pointer on success, or NULL on error
  */
-__rte_experimental
 struct rte_mbuf *
 rte_net_make_rarp_packet(struct rte_mempool *mpool,
 		const struct rte_ether_addr *mac);
diff --git a/lib/net/version.map b/lib/net/version.map
index 355b7c25b4..7584018d58 100644
--- a/lib/net/version.map
+++ b/lib/net/version.map
@@ -6,6 +6,7 @@  DPDK_22 {
 	rte_net_crc_calc;
 	rte_net_crc_set_alg;
 	rte_net_get_ptype;
+	rte_net_make_rarp_packet;
 
 	local: *;
 };
@@ -13,7 +14,6 @@  DPDK_22 {
 EXPERIMENTAL {
 	global:
 
-	rte_net_make_rarp_packet;
 	rte_net_skip_ip6_ext;
 	rte_ether_unformat_addr;
 };