From patchwork Mon Sep 6 07:07:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiming Chen X-Patchwork-Id: 98037 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1026CA0C4D; Mon, 6 Sep 2021 09:08:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63F8B410EA; Mon, 6 Sep 2021 09:08:41 +0200 (CEST) Received: from mail-m974.mail.163.com (mail-m974.mail.163.com [123.126.97.4]) by mails.dpdk.org (Postfix) with ESMTP id 951DF40C35; Mon, 6 Sep 2021 09:08:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=LGyFS oJ45XeN21xVEYjXpFEwlJw0bfK6Ufk7BksUInY=; b=SPS25kFUxud+mLGMf+PKs J7LNZxonPsdNA1FinbhA7Y39OJ2WKlxNUDSkzkEqDvU1hWJU11u9fpX3XBJNdCNc mLCDU8XBuy5gDaoFvm56lZxjUtts1a3M0eHpmMNAf/DCU791Te/OE36Cz/c8t/H1 hBsAkP2b48ok0ToiOWJeL4= Received: from localhost.localdomain (unknown [124.160.214.74]) by smtp4 (Coremail) with SMTP id HNxpCgDHzGFyvjVhvd14BQ--.937S2; Mon, 06 Sep 2021 15:08:36 +0800 (CST) From: Qiming Chen To: dev@dpdk.org Cc: beilei.xing@intel.com, Qiming Chen , stable@dpdk.org Date: Mon, 6 Sep 2021 15:07:51 +0800 Message-Id: <20210906070751.9750-1-chenqiming_huawei@163.com> X-Mailer: git-send-email 2.30.1.windows.1 MIME-Version: 1.0 X-CM-TRANSID: HNxpCgDHzGFyvjVhvd14BQ--.937S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7CFyxWrW5Zw4UAryfXw1fJFb_yoW8WF1rpF 4xJFyakFs8tanrW3y8JF4xuFWfZ393G3yUGFZ3C3sY9390ka45ZFy5KFWjgFyqyr4kWFnY qrZ0kw1UCa98ZaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jPkucUUUUU= X-Originating-IP: [124.160.214.74] X-CM-SenderInfo: xfkh01xlpl0w5bkxt4lhl6il2tof0z/xtbBZw8GoFet3z527QABsP Subject: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In the embedded RTOS environment, the x722 controller Ethernet card of the d2146nt chip, the vfio user mode driver takes over 8 vf ports in turn, but i40evf_check_vf_reset_done will probably fail. This issue has been discussed with intel&dpdk experts for 3 rounds before, and the version matching is no problem, and there is no substantial progress. The official website contacted external experts, but there was no response afterwards. Learning from the implementation of the i40evf kernel driver locally, after modifying the polling time from 1 second to 5s, the repeated restart process took over the start port test, and it was found that this probability was reduced to an order of magnitude acceptable to the user. The patch cannot fundamentally solve the failure problem, but it greatly slows down the probability of the problem. The modification is based on the i40evf kernel driver. Fixes: 5c9222058df7 ("i40e: move to drivers/net/") Cc: stable@dpdk.org Signed-off-by: Qiming Chen --- drivers/net/i40e/i40e_ethdev_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index f64db72e9a..924da8dfb4 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -42,7 +42,7 @@ /* busy wait delay in msec */ #define I40EVF_BUSY_WAIT_DELAY 10 #define I40EVF_BUSY_WAIT_COUNT 50 -#define MAX_RESET_WAIT_CNT 20 +#define MAX_RESET_WAIT_CNT 100 #define I40EVF_ALARM_INTERVAL 50000 /* us */