diff mbox series

[4/7] examples/ipsec-secgw: enable stats by default

Message ID 20210903112257.303961-5-radu.nicolau@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series IPsec Sec GW new features |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Radu Nicolau Sept. 3, 2021, 11:22 a.m. UTC 
  Enable stats screen by default

Signed-off-by: Declan Doherty <declan.doherty@intel.com>
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 examples/ipsec-secgw/ipsec-secgw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fan Zhang Sept. 3, 2021, 12:50 p.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Radu Nicolau
> Sent: Friday, September 3, 2021 12:23 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>; Akhil Goyal
> <gakhil@marvell.com>
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>
> Subject: [dpdk-dev] [PATCH 4/7] examples/ipsec-secgw: enable stats by
> default
> 
> Enable stats screen by default
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
>  examples/ipsec-secgw/ipsec-secgw.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ipsec-secgw/ipsec-secgw.h b/examples/ipsec-
> secgw/ipsec-secgw.h
> index 96e22de45e..ede610bcde 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.h
> +++ b/examples/ipsec-secgw/ipsec-secgw.h
> @@ -7,7 +7,7 @@
>  #include <stdbool.h>
> 
>  #ifndef STATS_INTERVAL
> -#define STATS_INTERVAL 0
> +#define STATS_INTERVAL 10ULL
>  #endif
> 
>  #define NB_SOCKETS 4
> --
> 2.25.1
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Akhil Goyal Sept. 8, 2021, 1:08 p.m. UTC | #2 
> Enable stats screen by default
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---

I believe timeout should be configurable like we have in l3fwd/l2fwd.
And without recompiling, there should be a way out to disable it.
If we are not doing an effort to do that, then by default it should be
Disabled in my opinion. Others can comment on it.
Hemant Agrawal Sept. 8, 2021, 4:05 p.m. UTC | #3 
On 9/8/2021 6:38 PM, Akhil Goyal wrote:
>> Enable stats screen by default
>>
>> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> ---
> I believe timeout should be configurable like we have in l3fwd/l2fwd.
> And without recompiling, there should be a way out to disable it.
> If we are not doing an effort to do that, then by default it should be
> Disabled in my opinion. Others can comment on it.


+1 we shall make it optional and disabled by default.
diff mbox series

Patch

diff --git a/examples/ipsec-secgw/ipsec-secgw.h b/examples/ipsec-secgw/ipsec-secgw.h
index 96e22de45e..ede610bcde 100644
--- a/examples/ipsec-secgw/ipsec-secgw.h
+++ b/examples/ipsec-secgw/ipsec-secgw.h
@@ -7,7 +7,7 @@ 
 #include <stdbool.h>
 
 #ifndef STATS_INTERVAL
-#define STATS_INTERVAL 0
+#define STATS_INTERVAL 10ULL
 #endif
 
 #define NB_SOCKETS 4