diff mbox series

build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic"

Message ID 20210902144805.105098-1-tchaikov@gmail.com (mailing list archive)
State Superseded
Delegated to: Thomas Monjalon
Headers show
Series build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic" | expand


Context Check Description
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/checkpatch success coding style OK

Commit Message

Kefu Chai Sept. 2, 2021, 2:48 p.m. UTC
RTE_MAX_MEMSEG_LISTS = 128 is not enough for some use cases, so add an
option so user can override it.
RTE_MBUF_REFCNT_ATOMIC = 0 is enough for applications like Seastar,
where it's safe to assume that the mbuf refcnt is only updated by a single
core only.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
 config/meson.build  | 5 ++++-
 config/rte_config.h | 2 --
 meson_options.txt   | 5 +++++
 3 files changed, 9 insertions(+), 3 deletions(-)
diff mbox series


diff --git a/config/meson.build b/config/meson.build
index 3b5966ec2f..72dd461198 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -301,7 +301,10 @@  if dpdk_conf.get('RTE_ARCH_64')
 else # for 32-bit we need smaller reserved memory areas
     dpdk_conf.set('RTE_MAX_MEM_MB', 2048)
+dpdk_conf.set('RTE_MAX_MEMSEG_LISTS', get_option('max_memseg_lists'))
+if get_option('mbuf_refcnt_atomic')
+  dpdk_conf.set('RTE_MBUF_REFCNT_ATOMIC', true)
 compile_time_cpuflags = []
diff --git a/config/rte_config.h b/config/rte_config.h
index 590903c07d..0a659f5e1a 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -29,7 +29,6 @@ 
 /* EAL defines */
 #define RTE_MAX_HEAPS 32
 #define RTE_MAX_MEM_MB_PER_LIST 32768
 #define RTE_MAX_MEMSEG_PER_TYPE 32768
@@ -50,7 +49,6 @@ 
 /* mbuf defines */
 #define RTE_MBUF_DEFAULT_MEMPOOL_OPS "ring_mp_mc"
 /* ether defines */
diff --git a/meson_options.txt b/meson_options.txt
index 0e92734c49..c0e8958797 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -38,6 +38,11 @@  option('max_lcores', type: 'integer', value: 128, description:
        'maximum number of cores/threads supported by EAL')
 option('max_numa_nodes', type: 'integer', value: 32, description:
        'maximum number of NUMA nodes supported by EAL')
+option('max_memseg_lists', type: 'integer', value: 128, description:
+       'maximum number of dynamic arrays holding memsegs')
+option('mbuf_refcnt_atomic', type: 'boolean', value: true, description:
+       'atomically access the mbuf refcnt')
 option('platform', type: 'string', value: 'native', description:
        'Platform to build, either "native", "generic" or a SoC. Please refer to the Linux build guide for more information.')
 option('enable_trace_fp', type: 'boolean', value: false, description: