diff mbox series

net/softnic: remove experimental table from API

Message ID 20210901122052.3885098-1-jasvinder.singh@intel.com (mailing list archive)
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series net/softnic: remove experimental table from API | expand

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/checkpatch success coding style OK

Commit Message

Singh, Jasvinder Sept. 1, 2021, 12:20 p.m. UTC
This API was introduced in 18.08, therefore removing
experimental tag to promote it to stable state.

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 drivers/net/softnic/rte_eth_softnic.h | 1 -
 drivers/net/softnic/version.map       | 7 +------
 2 files changed, 1 insertion(+), 7 deletions(-)

Comments

Kinsella, Ray Sept. 1, 2021, 1:48 p.m. UTC | #1
On 01/09/2021 13:20, Jasvinder Singh wrote:
> This API was introduced in 18.08, therefore removing
> experimental tag to promote it to stable state.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  drivers/net/softnic/rte_eth_softnic.h | 1 -
>  drivers/net/softnic/version.map       | 7 +------
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>
Ferruh Yigit Sept. 15, 2021, 7:33 a.m. UTC | #2
On 9/1/2021 2:48 PM, Kinsella, Ray wrote:
> 
> 
> On 01/09/2021 13:20, Jasvinder Singh wrote:
>> This API was introduced in 18.08, therefore removing
>> experimental tag to promote it to stable state.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>> ---
>>  drivers/net/softnic/rte_eth_softnic.h | 1 -
>>  drivers/net/softnic/version.map       | 7 +------
>>  2 files changed, 1 insertion(+), 7 deletions(-)
>>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> 

Applied to dpdk-next-net/main, thanks.
David Marchand Sept. 30, 2021, 3:42 p.m. UTC | #3
On Wed, Sep 15, 2021 at 9:33 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/1/2021 2:48 PM, Kinsella, Ray wrote:
> >
> >
> > On 01/09/2021 13:20, Jasvinder Singh wrote:
> >> This API was introduced in 18.08, therefore removing
> >> experimental tag to promote it to stable state.
> >>
> >> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> >> ---
> >>  drivers/net/softnic/rte_eth_softnic.h | 1 -
> >>  drivers/net/softnic/version.map       | 7 +------
> >>  2 files changed, 1 insertion(+), 7 deletions(-)
> >>
> > Acked-by: Ray Kinsella <mdr@ashroe.eu>
> >
>
> Applied to dpdk-next-net/main, thanks.


Nit:

diff --git a/drivers/net/softnic/version.map b/drivers/net/softnic/version.map
index cd5afcf155..01e1514276 100644
--- a/drivers/net/softnic/version.map
+++ b/drivers/net/softnic/version.map
@@ -1,8 +1,8 @@
 DPDK_22 {
        global:

-       rte_pmd_softnic_run;
        rte_pmd_softnic_manage;
+       rte_pmd_softnic_run;

        local: *;
 };


When merging patches touching .map, I recommend running:
./devtools/update-abi.sh 22.0
Dumitrescu, Cristian Oct. 12, 2021, 8:35 p.m. UTC | #4
> -----Original Message-----
> From: Singh, Jasvinder <jasvinder.singh@intel.com>
> Sent: Wednesday, September 1, 2021 1:21 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; mdr@ashroe.eu
> Subject: [PATCH] net/softnic: remove experimental table from API
> 
> This API was introduced in 18.08, therefore removing
> experimental tag to promote it to stable state.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  drivers/net/softnic/rte_eth_softnic.h | 1 -
>  drivers/net/softnic/version.map       | 7 +------
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/net/softnic/rte_eth_softnic.h
> b/drivers/net/softnic/rte_eth_softnic.h
> index 3f01161777..6c11d89ab6 100644
> --- a/drivers/net/softnic/rte_eth_softnic.h
> +++ b/drivers/net/softnic/rte_eth_softnic.h
> @@ -75,7 +75,6 @@ rte_pmd_softnic_run(uint16_t port_id);
>   * @return
>   *    Zero on success, error code otherwise.
>   */
> -__rte_experimental
>  int
>  rte_pmd_softnic_manage(uint16_t port_id);
> 
> diff --git a/drivers/net/softnic/version.map
> b/drivers/net/softnic/version.map
> index 6784318f77..cd5afcf155 100644
> --- a/drivers/net/softnic/version.map
> +++ b/drivers/net/softnic/version.map
> @@ -2,12 +2,7 @@ DPDK_22 {
>  	global:
> 
>  	rte_pmd_softnic_run;
> +	rte_pmd_softnic_manage;
> 
>  	local: *;
>  };
> -
> -EXPERIMENTAL {
> -	global:
> -
> -	rte_pmd_softnic_manage;
> -};
> --
> 2.26.3

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Kinsella, Ray Oct. 13, 2021, 8:52 a.m. UTC | #5
On 01/09/2021 13:20, Jasvinder Singh wrote:
> This API was introduced in 18.08, therefore removing
> experimental tag to promote it to stable state.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  drivers/net/softnic/rte_eth_softnic.h | 1 -
>  drivers/net/softnic/version.map       | 7 +------
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>
diff mbox series

Patch

diff --git a/drivers/net/softnic/rte_eth_softnic.h b/drivers/net/softnic/rte_eth_softnic.h
index 3f01161777..6c11d89ab6 100644
--- a/drivers/net/softnic/rte_eth_softnic.h
+++ b/drivers/net/softnic/rte_eth_softnic.h
@@ -75,7 +75,6 @@  rte_pmd_softnic_run(uint16_t port_id);
  * @return
  *    Zero on success, error code otherwise.
  */
-__rte_experimental
 int
 rte_pmd_softnic_manage(uint16_t port_id);
 
diff --git a/drivers/net/softnic/version.map b/drivers/net/softnic/version.map
index 6784318f77..cd5afcf155 100644
--- a/drivers/net/softnic/version.map
+++ b/drivers/net/softnic/version.map
@@ -2,12 +2,7 @@  DPDK_22 {
 	global:
 
 	rte_pmd_softnic_run;
+	rte_pmd_softnic_manage;
 
 	local: *;
 };
-
-EXPERIMENTAL {
-	global:
-
-	rte_pmd_softnic_manage;
-};