[v2] app/testpmd: add command to print representor info
Checks
Commit Message
From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
Make it simpler to debug configurations and code related to the representor
info API.
Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
v2:
- change output format to log just one line per range
app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 135 insertions(+)
Comments
> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Wednesday, September 1, 2021 12:13 AM
> To: Xiaoyun Li <xiaoyun.li@intel.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>; Andy
> Moreton <amoreton@xilinx.com>
> Subject: [PATCH v2] app/testpmd: add command to print representor info
>
> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>
> Make it simpler to debug configurations and code related to the representor info API.
>
> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> ---
> v2:
> - change output format to log just one line per range
>
> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 135 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc751..ae700f9dd1 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result,
> " Show port supported ptypes"
> " for a specific port\n\n"
>
> + "show port (port_id) representor info\n"
> + " Show supported representors"
> + " for a specific port\n\n"
> +
> "show device info (<identifier>|all)"
> " Show general information about devices probed.\n\n"
>
> @@ -16962,6 +16966,136 @@ cmdline_parse_inst_t cmd_show_capability = {
> },
> };
>
> +/* *** show port representors information *** */ struct
> +cmd_representor_info_result {
> + cmdline_fixed_string_t cmd_show;
> + cmdline_fixed_string_t cmd_port;
> + cmdline_fixed_string_t cmd_keyword;
> + portid_t cmd_pid;
> +};
> +
> +static void
> +cmd_representor_info_parsed(void *parsed_result,
> + __rte_unused struct cmdline *cl,
> + __rte_unused void *data)
> +{
> + struct cmd_representor_info_result *res = parsed_result;
> + struct rte_eth_representor_info *info;
> + struct rte_eth_representor_range *range;
> + uint32_t range_diff;
> + uint32_t i;
> + int ret;
> + int num;
> +
> + if (!rte_eth_dev_is_valid_port(res->cmd_pid)) {
> + fprintf(stderr, "Invalid port id %u\n", res->cmd_pid);
> + return;
> + }
> +
> + ret = rte_eth_representor_info_get(res->cmd_pid, NULL);
> + if (ret < 0) {
> + fprintf(stderr,
> + "Failed to get the number of representor info ranges for port %hu: %s\n",
> + res->cmd_pid, rte_strerror(-ret));
> + return;
> + }
> + num = ret;
> +
> + info = calloc(1, sizeof(*info) + num * sizeof(info->ranges[0]));
> + if (info == NULL) {
> + fprintf(stderr,
> + "Failed to allocate memory for representor info for port %hu\n",
> + res->cmd_pid);
> + return;
> + }
> + info->nb_ranges_alloc = num;
> +
> + ret = rte_eth_representor_info_get(res->cmd_pid, info);
> + if (ret < 0) {
> + fprintf(stderr,
> + "Failed to get the representor info for port %hu: %s\n",
> + res->cmd_pid, rte_strerror(-ret));
> + free(info);
> + return;
> + }
> +
> + printf("Port controller: %hu\n", info->controller);
> + printf("Port PF: %hu\n", info->pf);
> +
> + printf("Ranges: %u\n", info->nb_ranges);
> + for (i = 0; i < info->nb_ranges; i++) {
> + range = &info->ranges[i];
> + range_diff = range->id_end - range->id_base;
> +
> + printf("%u. ", i + 1);
> + printf("'%s' ", range->name);
> + if (range_diff > 0)
> + printf("[%u-%u]: ", range->id_base, range->id_end);
> + else
> + printf("[%u]: ", range->id_base);
> +
> + printf("Controller %d, PF %d", range->controller, range->pf);
> +
> + switch (range->type) {
> + case RTE_ETH_REPRESENTOR_NONE:
> + printf(", NONE\n");
> + break;
> + case RTE_ETH_REPRESENTOR_VF:
> + if (range_diff > 0) {
> + printf(", VF %d..%d\n", range->vf,
> + range->vf + range_diff);
> + } else {
> + printf(", VF %d\n", range->vf);
> + }
> + break;
> + case RTE_ETH_REPRESENTOR_SF:
> + printf(", SF %d\n", range->sf);
> + break;
> + case RTE_ETH_REPRESENTOR_PF:
> + if (range_diff > 0)
> + printf("..%d\n", range->pf + range_diff);
> + else
> + printf("\n");
> + break;
> + default:
> + printf(", UNKNOWN TYPE %d\n", range->type);
> + break;
> + }
> + }
> +
> + free(info);
> +}
> +
> +cmdline_parse_token_string_t cmd_representor_info_show =
> + TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
> + cmd_show, "show");
> +cmdline_parse_token_string_t cmd_representor_info_port =
> + TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
> + cmd_port, "port");
> +cmdline_parse_token_num_t cmd_representor_info_pid =
> + TOKEN_NUM_INITIALIZER(struct cmd_representor_info_result,
> + cmd_pid, RTE_UINT16);
> +cmdline_parse_token_string_t cmd_representor_info_keyword1 =
> + TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
> + cmd_keyword, "representor");
> +cmdline_parse_token_string_t cmd_representor_info_keyword2 =
> + TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
> + cmd_keyword, "info");
> +
> +cmdline_parse_inst_t cmd_representor_info = {
> + .f = cmd_representor_info_parsed,
> + .data = NULL,
> + .help_str = "show port <port_id> representor info",
> + .tokens = {
> + (void *)&cmd_representor_info_show,
> + (void *)&cmd_representor_info_port,
> + (void *)&cmd_representor_info_pid,
> + (void *)&cmd_representor_info_keyword1,
> + (void *)&cmd_representor_info_keyword2,
> + NULL,
> + },
> +};
> +
> /* *** show fec mode per port configuration *** */ struct cmd_show_fec_metadata_result {
> cmdline_fixed_string_t cmd_show;
> @@ -17816,6 +17950,7 @@ cmdline_parse_ctx_t main_ctx[] = {
> (cmdline_parse_inst_t *)&cmd_show_fec_mode,
> (cmdline_parse_inst_t *)&cmd_set_fec_mode,
> (cmdline_parse_inst_t *)&cmd_show_capability,
> + (cmdline_parse_inst_t *)&cmd_representor_info,
> NULL,
> };
>
> --
> 2.30.2
Reviewed-by: Xueming(Steven) Li <xuemingl@nvidia.com>
On 8/31/2021 5:12 PM, Andrew Rybchenko wrote:
> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>
> Make it simpler to debug configurations and code related to the representor
> info API.
>
> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> ---
> v2:
> - change output format to log just one line per range
>
> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 135 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 82253bc751..ae700f9dd1 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result,
> " Show port supported ptypes"
> " for a specific port\n\n"
>
> + "show port (port_id) representor info\n"
> + " Show supported representors"
> + " for a specific port\n\n"
> +
What do you think extending existing "show port info #" command instead of
creating a new command for it?
Since "show port info #" is a well known command, it can simplify the usage.
When port is representor port it can display additional info.
On 9/14/21 6:52 PM, Ferruh Yigit wrote:
> On 8/31/2021 5:12 PM, Andrew Rybchenko wrote:
>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>
>> Make it simpler to debug configurations and code related to the representor
>> info API.
>>
>> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>> ---
>> v2:
>> - change output format to log just one line per range
>>
>> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 135 insertions(+)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index 82253bc751..ae700f9dd1 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result,
>> " Show port supported ptypes"
>> " for a specific port\n\n"
>>
>> + "show port (port_id) representor info\n"
>> + " Show supported representors"
>> + " for a specific port\n\n"
>> +
>
> What do you think extending existing "show port info #" command instead of
> creating a new command for it?
My fear with such approach is that output of the "show port
info #" is already too long and adding representors info
there will make it even much longer.
> Since "show port info #" is a well known command, it can simplify the usage.
> When port is representor port it can display additional info.
>
Just to be clear: it will output information for "backer"
(or parent) port which should be used to create representors.
On 9/14/2021 5:17 PM, Andrew Rybchenko wrote:
> On 9/14/21 6:52 PM, Ferruh Yigit wrote:
>> On 8/31/2021 5:12 PM, Andrew Rybchenko wrote:
>>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>>
>>> Make it simpler to debug configurations and code related to the representor
>>> info API.
>>>
>>> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>>> ---
>>> v2:
>>> - change output format to log just one line per range
>>>
>>> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 135 insertions(+)
>>>
>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>>> index 82253bc751..ae700f9dd1 100644
>>> --- a/app/test-pmd/cmdline.c
>>> +++ b/app/test-pmd/cmdline.c
>>> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result,
>>> " Show port supported ptypes"
>>> " for a specific port\n\n"
>>>
>>> + "show port (port_id) representor info\n"
>>> + " Show supported representors"
>>> + " for a specific port\n\n"
>>> +
>>
>> What do you think extending existing "show port info #" command instead of
>> creating a new command for it?
>
> My fear with such approach is that output of the "show port
> info #" is already too long and adding representors info
> there will make it even much longer.
>
That is fair concern, what about extend existing command with a new keyword to
just print representor info:
"show port info # representor"
>> Since "show port info #" is a well known command, it can simplify the usage.
>> When port is representor port it can display additional info.
>>
>
> Just to be clear: it will output information for "backer"
> (or parent) port which should be used to create representors.
>
On 9/14/21 7:36 PM, Ferruh Yigit wrote:
> On 9/14/2021 5:17 PM, Andrew Rybchenko wrote:
>> On 9/14/21 6:52 PM, Ferruh Yigit wrote:
>>> On 8/31/2021 5:12 PM, Andrew Rybchenko wrote:
>>>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>>>
>>>> Make it simpler to debug configurations and code related to the representor
>>>> info API.
>>>>
>>>> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>>>> ---
>>>> v2:
>>>> - change output format to log just one line per range
>>>>
>>>> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 135 insertions(+)
>>>>
>>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>>>> index 82253bc751..ae700f9dd1 100644
>>>> --- a/app/test-pmd/cmdline.c
>>>> +++ b/app/test-pmd/cmdline.c
>>>> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result,
>>>> " Show port supported ptypes"
>>>> " for a specific port\n\n"
>>>>
>>>> + "show port (port_id) representor info\n"
>>>> + " Show supported representors"
>>>> + " for a specific port\n\n"
>>>> +
>>>
>>> What do you think extending existing "show port info #" command instead of
>>> creating a new command for it?
>>
>> My fear with such approach is that output of the "show port
>> info #" is already too long and adding representors info
>> there will make it even much longer.
>>
>
> That is fair concern, what about extend existing command with a new keyword to
> just print representor info:
> "show port info # representor"
Good idea, see v3.
>>> Since "show port info #" is a well known command, it can simplify the usage.
>>> When port is representor port it can display additional info.
>>>
>>
>> Just to be clear: it will output information for "backer"
>> (or parent) port which should be used to create representors.
>>
@@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result,
" Show port supported ptypes"
" for a specific port\n\n"
+ "show port (port_id) representor info\n"
+ " Show supported representors"
+ " for a specific port\n\n"
+
"show device info (<identifier>|all)"
" Show general information about devices probed.\n\n"
@@ -16962,6 +16966,136 @@ cmdline_parse_inst_t cmd_show_capability = {
},
};
+/* *** show port representors information *** */
+struct cmd_representor_info_result {
+ cmdline_fixed_string_t cmd_show;
+ cmdline_fixed_string_t cmd_port;
+ cmdline_fixed_string_t cmd_keyword;
+ portid_t cmd_pid;
+};
+
+static void
+cmd_representor_info_parsed(void *parsed_result,
+ __rte_unused struct cmdline *cl,
+ __rte_unused void *data)
+{
+ struct cmd_representor_info_result *res = parsed_result;
+ struct rte_eth_representor_info *info;
+ struct rte_eth_representor_range *range;
+ uint32_t range_diff;
+ uint32_t i;
+ int ret;
+ int num;
+
+ if (!rte_eth_dev_is_valid_port(res->cmd_pid)) {
+ fprintf(stderr, "Invalid port id %u\n", res->cmd_pid);
+ return;
+ }
+
+ ret = rte_eth_representor_info_get(res->cmd_pid, NULL);
+ if (ret < 0) {
+ fprintf(stderr,
+ "Failed to get the number of representor info ranges for port %hu: %s\n",
+ res->cmd_pid, rte_strerror(-ret));
+ return;
+ }
+ num = ret;
+
+ info = calloc(1, sizeof(*info) + num * sizeof(info->ranges[0]));
+ if (info == NULL) {
+ fprintf(stderr,
+ "Failed to allocate memory for representor info for port %hu\n",
+ res->cmd_pid);
+ return;
+ }
+ info->nb_ranges_alloc = num;
+
+ ret = rte_eth_representor_info_get(res->cmd_pid, info);
+ if (ret < 0) {
+ fprintf(stderr,
+ "Failed to get the representor info for port %hu: %s\n",
+ res->cmd_pid, rte_strerror(-ret));
+ free(info);
+ return;
+ }
+
+ printf("Port controller: %hu\n", info->controller);
+ printf("Port PF: %hu\n", info->pf);
+
+ printf("Ranges: %u\n", info->nb_ranges);
+ for (i = 0; i < info->nb_ranges; i++) {
+ range = &info->ranges[i];
+ range_diff = range->id_end - range->id_base;
+
+ printf("%u. ", i + 1);
+ printf("'%s' ", range->name);
+ if (range_diff > 0)
+ printf("[%u-%u]: ", range->id_base, range->id_end);
+ else
+ printf("[%u]: ", range->id_base);
+
+ printf("Controller %d, PF %d", range->controller, range->pf);
+
+ switch (range->type) {
+ case RTE_ETH_REPRESENTOR_NONE:
+ printf(", NONE\n");
+ break;
+ case RTE_ETH_REPRESENTOR_VF:
+ if (range_diff > 0) {
+ printf(", VF %d..%d\n", range->vf,
+ range->vf + range_diff);
+ } else {
+ printf(", VF %d\n", range->vf);
+ }
+ break;
+ case RTE_ETH_REPRESENTOR_SF:
+ printf(", SF %d\n", range->sf);
+ break;
+ case RTE_ETH_REPRESENTOR_PF:
+ if (range_diff > 0)
+ printf("..%d\n", range->pf + range_diff);
+ else
+ printf("\n");
+ break;
+ default:
+ printf(", UNKNOWN TYPE %d\n", range->type);
+ break;
+ }
+ }
+
+ free(info);
+}
+
+cmdline_parse_token_string_t cmd_representor_info_show =
+ TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
+ cmd_show, "show");
+cmdline_parse_token_string_t cmd_representor_info_port =
+ TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
+ cmd_port, "port");
+cmdline_parse_token_num_t cmd_representor_info_pid =
+ TOKEN_NUM_INITIALIZER(struct cmd_representor_info_result,
+ cmd_pid, RTE_UINT16);
+cmdline_parse_token_string_t cmd_representor_info_keyword1 =
+ TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
+ cmd_keyword, "representor");
+cmdline_parse_token_string_t cmd_representor_info_keyword2 =
+ TOKEN_STRING_INITIALIZER(struct cmd_representor_info_result,
+ cmd_keyword, "info");
+
+cmdline_parse_inst_t cmd_representor_info = {
+ .f = cmd_representor_info_parsed,
+ .data = NULL,
+ .help_str = "show port <port_id> representor info",
+ .tokens = {
+ (void *)&cmd_representor_info_show,
+ (void *)&cmd_representor_info_port,
+ (void *)&cmd_representor_info_pid,
+ (void *)&cmd_representor_info_keyword1,
+ (void *)&cmd_representor_info_keyword2,
+ NULL,
+ },
+};
+
/* *** show fec mode per port configuration *** */
struct cmd_show_fec_metadata_result {
cmdline_fixed_string_t cmd_show;
@@ -17816,6 +17950,7 @@ cmdline_parse_ctx_t main_ctx[] = {
(cmdline_parse_inst_t *)&cmd_show_fec_mode,
(cmdline_parse_inst_t *)&cmd_set_fec_mode,
(cmdline_parse_inst_t *)&cmd_show_capability,
+ (cmdline_parse_inst_t *)&cmd_representor_info,
NULL,
};