From patchwork Mon Aug 23 06:33:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Somnath Kotur X-Patchwork-Id: 97205 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59191A0C56; Mon, 23 Aug 2021 08:38:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2C5240143; Mon, 23 Aug 2021 08:38:06 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (lpdvsmtp09.broadcom.com [192.19.166.228]) by mails.dpdk.org (Postfix) with ESMTP id 7B2E64003E; Mon, 23 Aug 2021 08:38:05 +0200 (CEST) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id B28A580CC; Sun, 22 Aug 2021 23:38:02 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com B28A580CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1629700684; bh=AiaUiTrjvCuOd6oK32ASvp8TKAjarBexAdmtnZ61HSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sQtTxJkgPaZZs72YDzjAC/drvGx9bA02EuaTwQWCrYfoNTw4AOioT/BpzCr0jXyoh EidmkEWRIb3sgwbnMDJk6qbPtlyIKXpaEpspreVlIpKgDP1zelGmFMBR8iUR1PoRxV hwP3WRHKPqI6uFOXM5+Rf4X2iRV7YNfrIgus1V8g= From: Somnath Kotur To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Somnath Kotur , stable@dpdk.org, Kalesh AP , Ajit Khaparde Date: Mon, 23 Aug 2021 12:03:36 +0530 Message-Id: <20210823063336.28274-1-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.28.0.450.g3a238e5 In-Reply-To: <20210810060731.30127-1-somnath.kotur@broadcom.com> References: <20210810060731.30127-1-somnath.kotur@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] net/bnxt: fix to reset Rx next consumer index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In bnxt_init_one_rx_ring(), reset this variable internal to the driver ring to 0, so that there is no scope for any false mismatch errors being flagged on traffic resumption. Typically, this would show up in a port stop/start sequence as then the HW would start afresh, but this driver internal variable would still point to a stale value. Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion") Cc: stable@dpdk.org Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- v2: Updated commit log as requested by Ferruh drivers/net/bnxt/bnxt_rxr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index aea71703d1..73fbdd17d1 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -1379,6 +1379,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq) } PMD_DRV_LOG(DEBUG, "TPA alloc Done!\n"); + /* Explicitly reset this driver internal tracker on a ring init */ + rxr->rx_next_cons = 0; + return 0; }