| Message ID | 20210819061125.19929-1-joyce.kong@arm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Marchand |
| Headers | show |
| Series | test/service_cores: fix wrong comment | expand |
| Context | Check | Description |
|---|---|---|
| ci/intel-Testing | success | Testing PASS |
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-aarch64-unit-testing | fail | Testing issues |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/github-robot: build | success | github build: passed |
| ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Joyce Kong <joyce.kong@arm.com> > Sent: Thursday, August 19, 2021 7:11 AM > To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > <harry.van.haaren@intel.com>; honnappa.nagarahalli@arm.com; > ruifeng.wang@arm.com > Cc: dev@dpdk.org; nd@arm.com; stable@dpdk.org > Subject: [PATCH] test/service_cores: fix wrong comment > > Change the inaccurate comment of 'set pass flag' > to 'clear pass flag' as the '*pass_test = 0' code > actually implements clearing. > > Fixes: f038a81e1c56 ("service: add unit tests") > Cc: stable@dpdk.org > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
On Thu, Aug 19, 2021 at 10:13 AM Van Haaren, Harry <harry.van.haaren@intel.com> wrote: > > > -----Original Message----- > > From: Joyce Kong <joyce.kong@arm.com> > > Sent: Thursday, August 19, 2021 7:11 AM > > To: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > <harry.van.haaren@intel.com>; honnappa.nagarahalli@arm.com; > > ruifeng.wang@arm.com > > Cc: dev@dpdk.org; nd@arm.com; stable@dpdk.org > > Subject: [PATCH] test/service_cores: fix wrong comment > > > > Change the inaccurate comment of 'set pass flag' > > to 'clear pass flag' as the '*pass_test = 0' code > > actually implements clearing. > > > > Fixes: f038a81e1c56 ("service: add unit tests") > > Cc: stable@dpdk.org > > > > Signed-off-by: Joyce Kong <joyce.kong@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com> Applied, thanks.
diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c index ece104054e..8659a1526c 100644 --- a/app/test/test_service_cores.c +++ b/app/test/test_service_cores.c @@ -68,7 +68,7 @@ static int32_t dummy_mt_unsafe_cb(void *args) rte_delay_ms(250); __atomic_store_n(lock, 0, __ATOMIC_RELAXED); } else { - /* 2nd thread will fail to take lock, so set pass flag */ + /* 2nd thread will fail to take lock, so clear pass flag */ *pass_test = 0; }
Change the inaccurate comment of 'set pass flag' to 'clear pass flag' as the '*pass_test = 0' code actually implements clearing. Fixes: f038a81e1c56 ("service: add unit tests") Cc: stable@dpdk.org Signed-off-by: Joyce Kong <joyce.kong@arm.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> --- app/test/test_service_cores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)