eal: detach interrupt and worker threads
Checks
Commit Message
The EAL library does not wait (pthread_join) these threads
so the should be detached so that library can release resources.
This shows up when looking for memory leaks with tools like
valgrind.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/eal/freebsd/eal.c | 3 +++
lib/eal/linux/eal.c | 6 ++++++
lib/eal/linux/eal_interrupts.c | 3 +++
3 files changed, 12 insertions(+)
Comments
On Thu, Aug 19, 2021 at 4:41 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The EAL library does not wait (pthread_join) these threads
> so the should be detached so that library can release resources.
> This shows up when looking for memory leaks with tools like
> valgrind.
The FreeBSD interrupt thread can be detached too.
There is also the hpet-msb-inc thread in Linux that could be detached,
maybe in a followup patch?
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
With FreeBSD interrupt thread addition, you can add:
Reviewed-by: David Marchand <david.marchand@redhat.com>
@@ -899,6 +899,9 @@ rte_eal_init(int argc, char **argv)
sizeof(rte_cpuset_t), &lcore_config[i].cpuset);
if (ret != 0)
rte_panic("Cannot set affinity\n");
+
+ /* worker threads are never joined */
+ pthread_detach(lcore_config[i].thread_id);
}
/*
@@ -1267,6 +1267,12 @@ rte_eal_init(int argc, char **argv)
sizeof(rte_cpuset_t), &lcore_config[i].cpuset);
if (ret != 0)
rte_panic("Cannot set affinity\n");
+
+ /* worker threads are never joined */
+ ret = pthread_detach(lcore_config[i].thread_id);
+ if (ret != 0)
+ RTE_LOG(DEBUG, EAL,
+ "Cannot detach lcore thread\n");
}
/*
@@ -1175,6 +1175,9 @@ rte_eal_intr_init(void)
"Failed to create thread for interrupt handling\n");
}
+ /* the interrupt thread is never joined */
+ pthread_detach(intr_thread);
+
return ret;
}