Message ID | 20210808125139.3573701-3-thomas@monjalon.net (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | David Marchand |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12EB4A0A0C; Sun, 8 Aug 2021 14:51:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEA334116F; Sun, 8 Aug 2021 14:51:49 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 206664067E for <dev@dpdk.org>; Sun, 8 Aug 2021 14:51:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CA8AD5C004A; Sun, 8 Aug 2021 08:51:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 08 Aug 2021 08:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= YAt5pKCMnXFMVMreTHNVztqZCXO5YFVjv8L5Dc78+x4=; b=tMBa2CoX8hkfI0+f wK7BsW91qcANjQMbhDKfYhRXVQiWrrgwHENSZvL7iOMQTvNyesfK30Yad1KHbU2k 94ko+m4TTOAgC8QXqeTSWISznNSIKkaw1KwFaRB8rKCVX1CZ98OZPSYB2e6NeNV4 wGPtQ3i+dh+gBMZQPVB22teD5r1/uyyQpKT/aa2U4FSypNoG4zVURXJZ/PvZiWcT aP2Ik+gXA7Xho+NzJzWucO+iE2q7SooIJLHsOXMCKwqac4EtdRkXZL//ghYlda4D wUx3q9qeur5Z+wPw2up9UcEHzTWRJIe0xDBay33FcYocM5ivV82UMu4WmagF48DL 6KKxdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=YAt5pKCMnXFMVMreTHNVztqZCXO5YFVjv8L5Dc78+ x4=; b=etkGL5yGEZbU0F+6EXHkVxA15MXvMa/wbEi5xZ+PfblKlRS275j470n21 TMZWFFz06r5MzVXKBDRBoVJaaoa6Ifv5XSGInMqhAC7PRkhnLukRyjhZVhKQfX8f p2+1Ko66UHexnpBt/Zs5ajuDe+srBHQSxLRSVJ3wnhpxucTx4L/sncV4cFD1QcRc zZeRkS4MhuuLtSYw34XPH88fUIFUjTUbeZ3f5r727jv4l8wnMwJrgiPzWnh1T0K+ rQg2K+KKk7AXMkN0LDN1HSRw95Q3iyo6vVUxKGwYSY3sm48IpYkzpWwP2j5sAU4M gSdUEmS+UTacbn3/xZ/g1jar7THog== X-ME-Sender: <xms:Y9MPYSF_-tOnAeQdC3KRcNVCdh-ZzZLFTmIeywMmlpvbDtY0FQmm3g> <xme:Y9MPYTXjQWjfIyywZaxKoDedYgqWF3JskpV_5oV-_k7k9-Y3AGdBw3Io8x3NsHKmH CM8YNtHhSdAPp-QKQ> X-ME-Received: <xmr:Y9MPYcKza_hXmNUaOmkr6Y1QK8kktl-hvzsjbG5FjR0YHR_kaP1sr_Y4Xhh2qx7Nxhc2z2nR9CU-BIYw7712-RPyqd8cpTk> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvedutdevueevjeekveehheevffeugeejudekffeltdelkeeifeeg udehvdegjefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:Y9MPYcFBF8GbTZs9ggigsqSaVO7CZvBy99iBGViFt9KgDflBJeqPtg> <xmx:Y9MPYYUpKlTfNM5BcfO_W980oNq4nu8HpkmzfSeN8VMvSy40UGOLSg> <xmx:Y9MPYfPHw9SimXDCsOk3GA2DMFP5jgbDyMPKjF-yLBV1EF9Daec_Rg> <xmx:Y9MPYVgCPWFaBLZsx1eHyY1Wu8d4YinpTZ46_Yo3AAZv_odL-zBDWQ> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 08:51:46 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, Ori Kam <orika@nvidia.com> Date: Sun, 8 Aug 2021 14:51:35 +0200 Message-Id: <20210808125139.3573701-3-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210808125139.3573701-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 2/5] regex/mlx5: fix minsize build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | more build tests | |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | warning | coding style issues |
Commit Message
Thomas Monjalon
Aug. 8, 2021, 12:51 p.m. UTC
Error occurs when configuring meson with --buildtype=minsize
with GCC 11.1.0:
drivers/regex/mlx5/mlx5_regex_fastpath.c:398:17: error:
‘len’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
| complete_umr_wqe(qp, sq, &qp->jobs[mkey_job_id], sq->pi,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| klm_num, len);
| ~~~~~~~~~~~~~
drivers/regex/mlx5/mlx5_regex_fastpath.c:315:31: note: ‘len’ was declared here
| uint32_t klm_num = 0, len;
| ^~~
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/regex/mlx5/mlx5_regex_fastpath.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
> -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon > Sent: Sunday, August 8, 2021 8:52 PM > To: dev@dpdk.org > Cc: bruce.richardson@intel.com; david.marchand@redhat.com; Ori Kam > <orika@nvidia.com> > Subject: [dpdk-dev] [PATCH v3 2/5] regex/mlx5: fix minsize build > > Error occurs when configuring meson with --buildtype=minsize with GCC > 11.1.0: > > drivers/regex/mlx5/mlx5_regex_fastpath.c:398:17: error: > ‘len’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > | complete_umr_wqe(qp, sq, &qp->jobs[mkey_job_id], sq->pi, > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | klm_num, len); > | ~~~~~~~~~~~~~ > drivers/regex/mlx5/mlx5_regex_fastpath.c:315:31: note: ‘len’ was declared > here > | uint32_t klm_num = 0, len; > | ^~~ > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- > drivers/regex/mlx5/mlx5_regex_fastpath.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c > b/drivers/regex/mlx5/mlx5_regex_fastpath.c > index 786718af53..c79445ce7d 100644 > --- a/drivers/regex/mlx5/mlx5_regex_fastpath.c > +++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c > @@ -312,7 +312,8 @@ prep_regex_umr_wqe_set(struct mlx5_regex_priv > *priv, struct mlx5_regex_qp *qp, > struct mlx5_regex_job *job = NULL; > size_t sqid = sq->sqn, mkey_job_id = 0; > size_t left_ops = nb_ops; > - uint32_t klm_num = 0, len; > + uint32_t klm_num = 0; > + uint32_t len = 0; > struct mlx5_klm *mkey_klm = NULL; > struct mlx5_klm klm; > > -- > 2.31.1 Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c b/drivers/regex/mlx5/mlx5_regex_fastpath.c index 786718af53..c79445ce7d 100644 --- a/drivers/regex/mlx5/mlx5_regex_fastpath.c +++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c @@ -312,7 +312,8 @@ prep_regex_umr_wqe_set(struct mlx5_regex_priv *priv, struct mlx5_regex_qp *qp, struct mlx5_regex_job *job = NULL; size_t sqid = sq->sqn, mkey_job_id = 0; size_t left_ops = nb_ops; - uint32_t klm_num = 0, len; + uint32_t klm_num = 0; + uint32_t len = 0; struct mlx5_klm *mkey_klm = NULL; struct mlx5_klm klm;