diff mbox series

eal/windows: expose symbol rte_version

Message ID 20210805174819.1147-1-u9012063@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series eal/windows: expose symbol rte_version |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing fail Testing issues
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

William Tu Aug. 5, 2021, 5:48 p.m. UTC 
  When OVS inits, it calls rte_version to get the DPDK's version.
The patch fixes the error below by exposing rte_version symbol.
libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol
rte_version referenced in function dpdk_init

Signed-off-by: William Tu <u9012063@gmail.com>
---
 lib/eal/version.map | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Kozlyuk Aug. 11, 2021, 9:55 p.m. UTC | #1 
2021-08-05 17:48 (UTC+0000), William Tu:
> When OVS inits, it calls rte_version to get the DPDK's version.
> The patch fixes the error below by exposing rte_version symbol.
> libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol
> rte_version referenced in function dpdk_init

Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org

> Signed-off-by: William Tu <u9012063@gmail.com>

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

> ---
>  lib/eal/version.map | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index 887012d02a..3de59910cd 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -198,7 +198,7 @@ DPDK_21 {
>  	rte_uuid_is_null; # WINDOWS_NO_EXPORT
>  	rte_uuid_parse; # WINDOWS_NO_EXPORT
>  	rte_uuid_unparse; # WINDOWS_NO_EXPORT
> -	rte_version; # WINDOWS_NO_EXPORT
> +	rte_version;
>  	rte_vfio_clear_group; # WINDOWS_NO_EXPORT
>  	rte_vfio_container_create; # WINDOWS_NO_EXPORT
>  	rte_vfio_container_destroy; # WINDOWS_NO_EXPORT

I can see many functions not exported on Windows for no reason.
This includes the rest of the version API, but it's experimental,
so it's better to have this standalone patch for backporting
(since the patch it fixes is backported).
I'm going to restore other exports in a bulk patchset.
Thomas Monjalon Sept. 30, 2021, 8:26 p.m. UTC | #2 
11/08/2021 23:55, Dmitry Kozlyuk:
> 2021-08-05 17:48 (UTC+0000), William Tu:
> > When OVS inits, it calls rte_version to get the DPDK's version.
> > The patch fixes the error below by exposing rte_version symbol.
> > libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol
> > rte_version referenced in function dpdk_init
> 
> Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
> 
> > Signed-off-by: William Tu <u9012063@gmail.com>
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks.

Note: do not hesitate to ping when a patch is forgotten so long.
diff mbox series

Patch

diff --git a/lib/eal/version.map b/lib/eal/version.map
index 887012d02a..3de59910cd 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -198,7 +198,7 @@  DPDK_21 {
 	rte_uuid_is_null; # WINDOWS_NO_EXPORT
 	rte_uuid_parse; # WINDOWS_NO_EXPORT
 	rte_uuid_unparse; # WINDOWS_NO_EXPORT
-	rte_version; # WINDOWS_NO_EXPORT
+	rte_version;
 	rte_vfio_clear_group; # WINDOWS_NO_EXPORT
 	rte_vfio_container_create; # WINDOWS_NO_EXPORT
 	rte_vfio_container_destroy; # WINDOWS_NO_EXPORT