From patchwork Fri Jul 30 21:44:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 96479 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F108A0C40; Fri, 30 Jul 2021 23:45:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1B3540040; Fri, 30 Jul 2021 23:45:04 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 49F5B4003F for ; Fri, 30 Jul 2021 23:45:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8A2811B3; Fri, 30 Jul 2021 14:45:02 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 948253F70D; Fri, 30 Jul 2021 14:45:02 -0700 (PDT) From: Honnappa Nagarahalli To: dev@dpdk.org, honnappa.nagarahalli@arm.com, olivier.matz@6wind.com, lucp.at.work@gmail.com, david.marchand@redhat.com, thomas@monjalon.net Cc: ruifeng.wang@arm.com, nd@arm.com Date: Fri, 30 Jul 2021 16:44:53 -0500 Message-Id: <20210730214453.19975-1-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The current expected behaviour of the function rte_ctrl_thread_create is rigid which makes the implementation of the function complex. Make the expected behaviour abstract to allow for simplified implementation. With this change, the calls to pthread_setaffinity_np can be moved to the control thread. This will avoid the use of pthread_barrier_wait and simplify the synchronization mechanism between rte_ctrl_thread_create and the calling thread. Signed-off-by: Honnappa Nagarahalli Acked-by: Ruifeng Wang Acked-by: Jerin Jacob --- Possible patch is at: http://patches.dpdk.org/project/dpdk/patch/20210730213709.19400-1-honnappa.nagarahalli@arm.com/ doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 9584d6bfd7..1960e3c8bf 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -11,6 +11,13 @@ here. Deprecation Notices ------------------- +* eal: The expected behaviour of the function ``rte_ctrl_thread_create`` + abstracted to allow for simplified implementation. The new behaviour is + as follows: + Creates a control thread with the given name. The affinity of the new + thread is based on the CPU affinity retrieved at the time rte_eal_init() + was called, the dataplane and service lcores are then excluded. + * kvargs: The function ``rte_kvargs_process`` will get a new parameter for returning key match count. It will ease handling of no-match case.