diff mbox series

[1/1] net/mlx5: fix typo in flow engine type

Message ID 20210728093946.752300-1-asafp@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [1/1] net/mlx5: fix typo in flow engine type |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Asaf Penso July 28, 2021, 9:39 a.m. UTC 
  The concrete function names have a prefix for flow_dv.
This emphasizes the flow engine is direct verbs.

The function flow_get_aged_flows doesn’t have this prefix.
It creates an inconsistency with the other functions.

Update the function name to include dv.

Fixes: fa2d01c87d2 ("net/mlx5: support flow aging")
Cc: stable@dpdk.org

Signed-off-by: Asaf Penso <asafp@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Matan Azrad July 28, 2021, 9:55 a.m. UTC | #1 
From: Asaf Penso
> The concrete function names have a prefix for flow_dv.
> This emphasizes the flow engine is direct verbs.
> 
> The function flow_get_aged_flows doesn’t have this prefix.
> It creates an inconsistency with the other functions.
> 
> Update the function name to include dv.
> 
> Fixes: fa2d01c87d2 ("net/mlx5: support flow aging")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Asaf Penso <asafp@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Raslan Darawsheh July 29, 2021, 8:20 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Asaf Penso <asafp@nvidia.com>
> Sent: Wednesday, July 28, 2021 12:40 PM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; stable@dpdk.org
> Subject: [PATCH 1/1] net/mlx5: fix typo in flow engine type
> 
> The concrete function names have a prefix for flow_dv.
> This emphasizes the flow engine is direct verbs.
> 
> The function flow_get_aged_flows doesn’t have this prefix.
> It creates an inconsistency with the other functions.
> 
> Update the function name to include dv.
> 
> Fixes: fa2d01c87d2 ("net/mlx5: support flow aging")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Asaf Penso <asafp@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 736227bc0c..4b569b0bdb 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -17231,7 +17231,7 @@  flow_dv_counter_query(struct rte_eth_dev *dev, uint32_t counter, bool clear,
  * @note: only stub for now
  */
 static int
-flow_get_aged_flows(struct rte_eth_dev *dev,
+flow_dv_get_aged_flows(struct rte_eth_dev *dev,
 		    void **context,
 		    uint32_t nb_contexts,
 		    struct rte_flow_error *error)
@@ -17854,7 +17854,7 @@  const struct mlx5_flow_driver_ops mlx5_flow_dv_drv_ops = {
 	.counter_alloc = flow_dv_counter_allocate,
 	.counter_free = flow_dv_counter_free,
 	.counter_query = flow_dv_counter_query,
-	.get_aged_flows = flow_get_aged_flows,
+	.get_aged_flows = flow_dv_get_aged_flows,
 	.action_validate = flow_dv_action_validate,
 	.action_create = flow_dv_action_create,
 	.action_destroy = flow_dv_action_destroy,