diff mbox series

[v2] eventdev: fix event port setup in tx adapter

Message ID 20210724141036.915356-1-s.v.naga.harish.k@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers show
Series [v2] eventdev: fix event port setup in tx adapter | expand

Checks

Context Check Description
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Naga Harish K, S V July 24, 2021, 2:10 p.m. UTC
The event port config set by application in
rte_event_eth_tx_adapter_create API is modified in
default configuration callback function. This patch removes
this hardcode to use application provided event port
config value.

Fixes: ("eventdev: fix event port config override in tx adapter")

Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
---
 lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jayatheerthan, Jay July 28, 2021, 6:44 a.m. UTC | #1
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Saturday, July 24, 2021 7:41 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> Cc: dev@dpdk.org
> Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
> 
> The event port config set by application in
> rte_event_eth_tx_adapter_create API is modified in
> default configuration callback function. This patch removes
> this hardcode to use application provided event port
> config value.
> 
> Fixes: ("eventdev: fix event port config override in tx adapter")

@Jerin, does this look good to you ?

> 
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> ---
>  lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index db260bfb68..18c0359db7 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
>  		return ret;
>  	}
> 
> -	pc->event_port_cfg = 0;
>  	ret = rte_event_port_setup(dev_id, port_id, pc);
>  	if (ret) {
>  		RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> --
> 2.25.1
Jerin Jacob July 28, 2021, 9:30 a.m. UTC | #2
On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay
<jay.jayatheerthan@intel.com> wrote:
>
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Saturday, July 24, 2021 7:41 PM
> > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > The event port config set by application in
> > rte_event_eth_tx_adapter_create API is modified in
> > default configuration callback function. This patch removes
> > this hardcode to use application provided event port
> > config value.
> >
> > Fixes: ("eventdev: fix event port config override in tx adapter")
>
> @Jerin, does this look good to you ?

Yes. I will merge this. See below.

>
> >
> > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>


@Naga Harish K, S V Can we remove "," from the Signoff name.

Some suggestions for consideration in preferred order. Let me know
your preferred Signoff name, I will change it accordingly.

Naga Harish <s.v.naga.harish.k@intel.com>

or

Naga Harish K <s.v.naga.harish.k@intel.com>

or

Naga Harish K S V <s.v.naga.harish.k@intel.com>

> > ---
> >  lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > index db260bfb68..18c0359db7 100644
> > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> >               return ret;
> >       }
> >
> > -     pc->event_port_cfg = 0;
> >       ret = rte_event_port_setup(dev_id, port_id, pc);
> >       if (ret) {
> >               RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > --
> > 2.25.1
Jayatheerthan, Jay July 28, 2021, 10:57 a.m. UTC | #3
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, July 28, 2021 3:01 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> 
> On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > Sent: Saturday, July 24, 2021 7:41 PM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> > > Cc: dev@dpdk.org
> > > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
> > >
> > > The event port config set by application in
> > > rte_event_eth_tx_adapter_create API is modified in
> > > default configuration callback function. This patch removes
> > > this hardcode to use application provided event port
> > > config value.
> > >
> > > Fixes: ("eventdev: fix event port config override in tx adapter")
> >
> > @Jerin, does this look good to you ?
> 
> Yes. I will merge this. See below.

Thanks!

> 
> >
> > >
> > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> 
> 
> @Naga Harish K, S V Can we remove "," from the Signoff name.
> 
> Some suggestions for consideration in preferred order. Let me know
> your preferred Signoff name, I will change it accordingly.
> 
> Naga Harish <s.v.naga.harish.k@intel.com>
> 
> or
> 
> Naga Harish K <s.v.naga.harish.k@intel.com>
> 
> or
> 
> Naga Harish K S V <s.v.naga.harish.k@intel.com>

This option is good. (Harish is out and hence I am responding)

> 
> > > ---
> > >  lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > index db260bfb68..18c0359db7 100644
> > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> > >               return ret;
> > >       }
> > >
> > > -     pc->event_port_cfg = 0;
> > >       ret = rte_event_port_setup(dev_id, port_id, pc);
> > >       if (ret) {
> > >               RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > > --
> > > 2.25.1
Jerin Jacob July 30, 2021, 10:24 a.m. UTC | #4
On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
<jay.jayatheerthan@intel.com> wrote:
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Wednesday, July 28, 2021 3:01 PM
> > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter

> >
> > >
> > > >
> > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> >
> >
> > @Naga Harish K, S V Can we remove "," from the Signoff name.
> >
> > Some suggestions for consideration in preferred order. Let me know
> > your preferred Signoff name, I will change it accordingly.
> >
> > Naga Harish <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K S V <s.v.naga.harish.k@intel.com>
>
> This option is good. (Harish is out and hence I am responding)

1)  Option 'Signed-off-by: Naga Harish K S V
<s.v.naga.harish.k@intel.com> is warned by checkpatch

[for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1

### eventdev: fix event port setup in Tx adapter

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
!= 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'

2)  Option 'Signed-off-by: Naga Harish K, S V
<s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh

[for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
Wrong tag:
        Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>


@thomas @David Marchand

Could you suggest what Sign-off to take?


>
> >
> > > > ---
> > > >  lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > index db260bfb68..18c0359db7 100644
> > > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> > > >               return ret;
> > > >       }
> > > >
> > > > -     pc->event_port_cfg = 0;
> > > >       ret = rte_event_port_setup(dev_id, port_id, pc);
> > > >       if (ret) {
> > > >               RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > > > --
> > > > 2.25.1
Thomas Monjalon July 30, 2021, 10:31 a.m. UTC | #5
30/07/2021 12:24, Jerin Jacob:
> On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > Sent: Wednesday, July 28, 2021 3:01 PM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> 
> > >
> > > >
> > > > >
> > > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > >
> > >
> > > @Naga Harish K, S V Can we remove "," from the Signoff name.
> > >
> > > Some suggestions for consideration in preferred order. Let me know
> > > your preferred Signoff name, I will change it accordingly.
> > >
> > > Naga Harish <s.v.naga.harish.k@intel.com>
> > >
> > > or
> > >
> > > Naga Harish K <s.v.naga.harish.k@intel.com>
> > >
> > > or
> > >
> > > Naga Harish K S V <s.v.naga.harish.k@intel.com>
> >
> > This option is good. (Harish is out and hence I am responding)
> 
> 1)  Option 'Signed-off-by: Naga Harish K S V
> <s.v.naga.harish.k@intel.com> is warned by checkpatch
> 
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
> 
> ### eventdev: fix event port setup in Tx adapter
> 
> WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
> mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
> != 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'
> 
> 2)  Option 'Signed-off-by: Naga Harish K, S V
> <s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh
> 
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
> Wrong tag:
>         Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> 
> 
> @thomas @David Marchand
> 
> Could you suggest what Sign-off to take?

The first option is probably OK but the problem is a mismatch with the author name.
Make sure to change the authorship with --amend --author=
Jerin Jacob July 30, 2021, 10:36 a.m. UTC | #6
On Fri, Jul 30, 2021 at 4:00 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 30/07/2021 12:24, Jerin Jacob:
> > On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > > Sent: Wednesday, July 28, 2021 3:01 PM
> > > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > > > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > > >
> > > > >
> > > > > >
> > > > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > >
> > > >
> > > > @Naga Harish K, S V Can we remove "," from the Signoff name.
> > > >
> > > > Some suggestions for consideration in preferred order. Let me know
> > > > your preferred Signoff name, I will change it accordingly.
> > > >
> > > > Naga Harish <s.v.naga.harish.k@intel.com>
> > > >
> > > > or
> > > >
> > > > Naga Harish K <s.v.naga.harish.k@intel.com>
> > > >
> > > > or
> > > >
> > > > Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > >
> > > This option is good. (Harish is out and hence I am responding)
> >
> > 1)  Option 'Signed-off-by: Naga Harish K S V
> > <s.v.naga.harish.k@intel.com> is warned by checkpatch
> >
> > [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
> >
> > ### eventdev: fix event port setup in Tx adapter
> >
> > WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
> > mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
> > != 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'
> >
> > 2)  Option 'Signed-off-by: Naga Harish K, S V
> > <s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh
> >
> > [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
> > Wrong tag:
> >         Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> >
> >
> > @thomas @David Marchand
> >
> > Could you suggest what Sign-off to take?
>
> The first option is probably OK but the problem is a mismatch with the author name.
> Make sure to change the authorship with --amend --author=

Thanks for the input.


>
>
Jerin Jacob July 30, 2021, 10:59 a.m. UTC | #7
On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
<jay.jayatheerthan@intel.com> wrote:
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Wednesday, July 28, 2021 3:01 PM
> > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > > Sent: Saturday, July 24, 2021 7:41 PM
> > > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> > > > Cc: dev@dpdk.org
> > > > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
> > > >
> > > > The event port config set by application in
> > > > rte_event_eth_tx_adapter_create API is modified in
> > > > default configuration callback function. This patch removes
> > > > this hardcode to use application provided event port
> > > > config value.
> > > >
> > > > Fixes: ("eventdev: fix event port config override in tx adapter")
> > >
> > > @Jerin, does this look good to you ?
> >
> > Yes. I will merge this. See below.


Applied to dpdk-next-net-eventdev/for-main. Thanks


>
> Thanks!
>
> >
> > >
> > > >
> > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> >
> >
> > @Naga Harish K, S V Can we remove "," from the Signoff name.
> >
> > Some suggestions for consideration in preferred order. Let me know
> > your preferred Signoff name, I will change it accordingly.
> >
> > Naga Harish <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K S V <s.v.naga.harish.k@intel.com>
>
> This option is good. (Harish is out and hence I am responding)
>
> >
> > > > ---
> > > >  lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > index db260bfb68..18c0359db7 100644
> > > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> > > >               return ret;
> > > >       }
> > > >
> > > > -     pc->event_port_cfg = 0;
> > > >       ret = rte_event_port_setup(dev_id, port_id, pc);
> > > >       if (ret) {
> > > >               RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > > > --
> > > > 2.25.1
diff mbox series

Patch

diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index db260bfb68..18c0359db7 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -286,7 +286,6 @@  txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
 		return ret;
 	}
 
-	pc->event_port_cfg = 0;
 	ret = rte_event_port_setup(dev_id, port_id, pc);
 	if (ret) {
 		RTE_EDEV_LOG_ERR("failed to setup event port %u\n",