diff mbox series

crypto/octeontx: enable build on non Linux OS

Message ID 20210722090651.2598075-1-sthotton@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series crypto/octeontx: enable build on non Linux OS |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Shijith Thotton July 22, 2021, 9:06 a.m. UTC 
  Enabled build of Octeontx crypto PMD on non linux OS. Other Octeontx
PMDs are enabled already.

This is to avoid ABI test failure on an OS once we add dependency
between a driver which is built to another which is not.

Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
 drivers/crypto/octeontx/meson.build | 4 ----
 1 file changed, 4 deletions(-)

Comments

Akhil Goyal July 22, 2021, 9:17 a.m. UTC | #1 
> Enabled build of Octeontx crypto PMD on non linux OS. Other Octeontx
> PMDs are enabled already.
> 
> This is to avoid ABI test failure on an OS once we add dependency
> between a driver which is built to another which is not.

Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter framework")
> 

Reported-by: David Marchand <david.marchand@redhat.com>

> Signed-off-by: Shijith Thotton <sthotton@marvell.com>

Acked-by: Akhil Goyal <gakhil@marvell.com>

Thomas/David: please pick this patch directly on main to fix build on CI for FreeBSD.
Thomas Monjalon July 22, 2021, 7:06 p.m. UTC | #2 
22/07/2021 11:17, Akhil Goyal:
> > Enabled build of Octeontx crypto PMD on non linux OS. Other Octeontx
> > PMDs are enabled already.
> > 
> > This is to avoid ABI test failure on an OS once we add dependency
> > between a driver which is built to another which is not.
> 
> Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter framework")
> > 
> 
> Reported-by: David Marchand <david.marchand@redhat.com>
> 
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> 
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> Thomas/David: please pick this patch directly on main to fix build on CI for FreeBSD.

Applied, thanks.
Thomas Monjalon July 22, 2021, 7:08 p.m. UTC | #3 
22/07/2021 21:06, Thomas Monjalon:
> 22/07/2021 11:17, Akhil Goyal:
> > > Enabled build of Octeontx crypto PMD on non linux OS. Other Octeontx
> > > PMDs are enabled already.
> > > 
> > > This is to avoid ABI test failure on an OS once we add dependency
> > > between a driver which is built to another which is not.
> > 
> > Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter framework")
> > > 
> > 
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > 
> > > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> > 
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > 
> > Thomas/David: please pick this patch directly on main to fix build on CI for FreeBSD.
> 
> Applied, thanks.

Please could you re-test the ABI on FreeBSD
and re-enable in the CI if the test is passing?

Thank you
Brandon Lo July 22, 2021, 8:20 p.m. UTC | #4 
On Thu, Jul 22, 2021 at 3:08 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 22/07/2021 21:06, Thomas Monjalon:
> > 22/07/2021 11:17, Akhil Goyal:
> > > > Enabled build of Octeontx crypto PMD on non linux OS. Other Octeontx
> > > > PMDs are enabled already.
> > > >
> > > > This is to avoid ABI test failure on an OS once we add dependency
> > > > between a driver which is built to another which is not.
> > >
> > > Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter framework")
> > > >
> > >
> > > Reported-by: David Marchand <david.marchand@redhat.com>
> > >
> > > > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> > >
> > > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > >
> > > Thomas/David: please pick this patch directly on main to fix build on CI for FreeBSD.
> >
> > Applied, thanks.
>
> Please could you re-test the ABI on FreeBSD
> and re-enable in the CI if the test is passing?
>
> Thank you

I ran a couple test runs on FreeBSD 13 to ensure that the patch
compiles successfully, and I enabled reporting.
FreeBSD 13 should start to appear in the ABI test results of newer
tarballs with the patch.

Thanks,
Brandon


--
Brandon Lo
UNH InterOperability Laboratory
21 Madbury Rd, Suite 100, Durham, NH 03824
blo@iol.unh.edu
www.iol.unh.edu
Thomas Monjalon July 22, 2021, 8:32 p.m. UTC | #5 
22/07/2021 22:20, Brandon Lo:
> On Thu, Jul 22, 2021 at 3:08 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 22/07/2021 21:06, Thomas Monjalon:
> > > 22/07/2021 11:17, Akhil Goyal:
> > > > > Enabled build of Octeontx crypto PMD on non linux OS. Other Octeontx
> > > > > PMDs are enabled already.
> > > > >
> > > > > This is to avoid ABI test failure on an OS once we add dependency
> > > > > between a driver which is built to another which is not.
> > > >
> > > > Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter framework")
> > > > >
> > > >
> > > > Reported-by: David Marchand <david.marchand@redhat.com>
> > > >
> > > > > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> > > >
> > > > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > > >
> > > > Thomas/David: please pick this patch directly on main to fix build on CI for FreeBSD.
> > >
> > > Applied, thanks.
> >
> > Please could you re-test the ABI on FreeBSD
> > and re-enable in the CI if the test is passing?
> >
> > Thank you
> 
> I ran a couple test runs on FreeBSD 13 to ensure that the patch
> compiles successfully, and I enabled reporting.
> FreeBSD 13 should start to appear in the ABI test results of newer
> tarballs with the patch.

Thanks a lot Brandon, well managed.
diff mbox series

Patch

diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build
index 3ae6729e8f..244b16230e 100644
--- a/drivers/crypto/octeontx/meson.build
+++ b/drivers/crypto/octeontx/meson.build
@@ -1,9 +1,5 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Cavium, Inc
-if not is_linux
-    build = false
-    reason = 'only supported on Linux'
-endif
 
 deps += ['bus_pci']
 deps += ['bus_vdev']