From patchwork Mon Jul 12 08:04:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalesh A P X-Patchwork-Id: 95695 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C50B2A0C50; Mon, 12 Jul 2021 09:43:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C79F741197; Mon, 12 Jul 2021 09:43:43 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (lpdvsmtp09.broadcom.com [192.19.166.228]) by mails.dpdk.org (Postfix) with ESMTP id CE73641185 for ; Mon, 12 Jul 2021 09:43:39 +0200 (CEST) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 60EAA80FA; Mon, 12 Jul 2021 06:14:05 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 60EAA80FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1626095646; bh=eCwC+9NTX0QRP71ByULZicAmFsgbldCw41A98jAC/ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U/3uB66Ry4AF3mc0SRdZnLCR3/n/wwHi2qNJ8HbI2RJQ9HW9dww/tZOW+AVe5GQRQ ktmglnl85o83vUH5uocNhk1TEB3P6F3XJokb7W/OofutgxCVBo5AFznmtHXwZS67LR ujmeKsLSfEtvZePym4jPNSI4FamLhWoQ6i+IInvc= From: Kalesh A P To: dev@dpdk.org Cc: ajit.khaparde@broadcom.com Date: Mon, 12 Jul 2021 13:34:34 +0530 Message-Id: <20210712080435.9149-4-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20210712080435.9149-1-kalesh-anakkur.purayil@broadcom.com> References: <20210712080435.9149-1-kalesh-anakkur.purayil@broadcom.com> Subject: [dpdk-dev] [PATCH 3/4] net/bnxt: minor refactoring of async handling code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Somnath Kotur Store the async event completion data1 and data2 in separate variables at the start of the function before the switch case for the different events so they can be used by any of the event handlers. Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c index 2c7fd78..500146b 100644 --- a/drivers/net/bnxt/bnxt_cpr.c +++ b/drivers/net/bnxt/bnxt_cpr.c @@ -103,7 +103,10 @@ void bnxt_handle_async_event(struct bnxt *bp, uint16_t port_id = bp->eth_dev->data->port_id; struct bnxt_error_recovery_info *info; uint32_t event_data; - uint32_t echo_req_data1, echo_req_data2; + uint32_t data1, data2; + + data1 = rte_le_to_cpu_32(async_cmp->event_data1); + data2 = rte_le_to_cpu_32(async_cmp->event_data2); switch (event_id) { case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE: @@ -136,7 +139,7 @@ void bnxt_handle_async_event(struct bnxt *bp, } pthread_mutex_lock(&bp->err_recovery_lock); - event_data = rte_le_to_cpu_32(async_cmp->event_data1); + event_data = data1; /* timestamp_lo/hi values are in units of 100ms */ bp->fw_reset_max_msecs = async_cmp->timestamp_hi ? rte_le_to_cpu_16(async_cmp->timestamp_hi) * 100 : @@ -170,8 +173,7 @@ void bnxt_handle_async_event(struct bnxt *bp, PMD_DRV_LOG(INFO, "Port %u: Error recovery async event received\n", port_id); - event_data = rte_le_to_cpu_32(async_cmp->event_data1) & - EVENT_DATA1_FLAGS_MASK; + event_data = data1 & EVENT_DATA1_FLAGS_MASK; if (event_data & EVENT_DATA1_FLAGS_MASTER_FUNC) info->flags |= BNXT_FLAG_MASTER_FUNC; @@ -198,22 +200,18 @@ void bnxt_handle_async_event(struct bnxt *bp, bnxt_schedule_fw_health_check(bp); break; case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_DEBUG_NOTIFICATION: - PMD_DRV_LOG(INFO, "DNC event: evt_data1 %#x evt_data2 %#x\n", - rte_le_to_cpu_32(async_cmp->event_data1), - rte_le_to_cpu_32(async_cmp->event_data2)); + PMD_DRV_LOG(INFO, "Port: %u DNC event: data1 %#x data2 %#x\n", + port_id, data1, data2); break; case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_DEFAULT_VNIC_CHANGE: bnxt_process_default_vnic_change(bp, async_cmp); break; case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_ECHO_REQUEST: - echo_req_data1 = rte_le_to_cpu_32(async_cmp->event_data1); - echo_req_data2 = rte_le_to_cpu_32(async_cmp->event_data2); PMD_DRV_LOG(INFO, "Port %u: Received fw echo request: data1 %#x data2 %#x\n", - port_id, echo_req_data1, echo_req_data2); + port_id, data1, data2); if (bp->recovery_info) - bnxt_hwrm_fw_echo_reply(bp, echo_req_data1, - echo_req_data2); + bnxt_hwrm_fw_echo_reply(bp, data1, data2); break; default: PMD_DRV_LOG(DEBUG, "handle_async_event id = 0x%x\n", event_id);