From patchwork Sun Jul 11 13:13:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: danat@marvell.com X-Patchwork-Id: 95649 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01387A0C45; Sun, 11 Jul 2021 15:13:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E50654115C; Sun, 11 Jul 2021 15:13:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2EC8340688; Sun, 11 Jul 2021 15:13:21 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16BDCKau029332; Sun, 11 Jul 2021 06:13:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=osQV9pVuL37Z/ANdgbVyXPq8zVHxrRrKTI0RZX1tP3I=; b=S6wR6nELPJ2NE30NCt0zwzu6GClJXEQeQxqdkgEI8NxVP3bZ7cQ/A6D9AVdgzWs+TjEI bQv7+ZhskGAxfF0YNU8tyvTGgU/zILTQiEoabchmU2eDGEP30ijluDZ5wFkCRTxIBl7Q PkVLYBao3egiZJYriBSS+kX3ZHWBsrJclW6SewV+W/epqqX1XakwPcPiui1ChBONKYv5 DtgO2hE7HEfFIXAEQYDLXHPLyyvHzba7xP/P0b0GBLqNxGIQxn+/A083lSP2KqWMm5wv TAcEYItp1QNTw6MUghJUqdtedJaHojcgkJrZQn/PQb6K5GtbxaW1cbTwehc+caKDFlGN Ww== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 39q8wqu0hj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 11 Jul 2021 06:13:20 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 11 Jul 2021 06:13:18 -0700 Received: from jupiter077.il.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Sun, 11 Jul 2021 06:13:17 -0700 From: To: CC: , , , Meir Levi , Date: Sun, 11 Jul 2021 16:13:14 +0300 Message-ID: <20210711131314.11985-1-danat@marvell.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: S94AiZHBjWu9iDRt8iMSqI-ekbruhu_U X-Proofpoint-GUID: S94AiZHBjWu9iDRt8iMSqI-ekbruhu_U X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-11_08:2021-07-09, 2021-07-11 signatures=0 Subject: [dpdk-dev] [PATCH] net/mvpp2: fix declare unsupported vlan offload features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Meir Levi vlan_strip and vlan_extend features need to return "unsupported" error value. Fixes: ff0b8b10dc4 ("net/mvpp2: support VLAN offload") Cc: stable@dpdk.org Signed-off-by: Meir Levi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index 1802695a0e..078aefbb8d 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -1873,8 +1873,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask) uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads; int ret; - if (mask & ETH_VLAN_STRIP_MASK) + if (mask & ETH_VLAN_STRIP_MASK) { MRVL_LOG(ERR, "VLAN stripping is not supported\n"); + return -ENOTSUP; + } if (mask & ETH_VLAN_FILTER_MASK) { if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER) @@ -1886,8 +1888,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask) return ret; } - if (mask & ETH_VLAN_EXTEND_MASK) + if (mask & ETH_VLAN_EXTEND_MASK) { MRVL_LOG(ERR, "Extend VLAN not supported\n"); + return -ENOTSUP; + } return 0; }