From patchwork Sun Jul 11 13:11:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: danat@marvell.com X-Patchwork-Id: 95647 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88B27A0C45; Sun, 11 Jul 2021 15:11:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5B254068E; Sun, 11 Jul 2021 15:11:53 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 80D7740040; Sun, 11 Jul 2021 15:11:51 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16BDBWXA028187; Sun, 11 Jul 2021 06:11:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=qu1zI4I79WnWm+LZA5SZDVAlgYNEFTmZ76KTGuJ12h0=; b=FQ91wHbBYbsYL4PmhxJFnPqqxwTdJOxk97ouNr4t6Jdl/XbHFqhZwMZoc/2DkLOlRxgA quNwRRfMz3tPEJlrSeyaR74Tih1YwWw1c2CK/IlBMPVcQIXXNtw5sbOnb6kFhkK2zmrl xmQPXZe01azpJKR3qHl0/xN41Obv4ONSrnQYnijJF++7mdVGmkEtqjLZWJxU0bX5XuKR C5ptUq7p9mqq21NIyS8MFlgHbrJHI3BFZFAz2Sl8jqcg16u+j5pOBawqu/F+h3n2LYDp VA8zlF33NWyNvjxd4wrJhUt9KjNz19sifeJIdatn616DGqe/RhyRCHqUEySTcbe6aJjM sw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 39q8wqu0eq-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 11 Jul 2021 06:11:50 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 11 Jul 2021 06:11:48 -0700 Received: from jupiter077.il.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Sun, 11 Jul 2021 06:11:46 -0700 From: To: CC: , , , , Date: Sun, 11 Jul 2021 16:11:43 +0300 Message-ID: <20210711131143.11893-1-danat@marvell.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: U7fUuWpKxlSfeQHIDJZGE_YnDAlgLZM7 X-Proofpoint-GUID: U7fUuWpKxlSfeQHIDJZGE_YnDAlgLZM7 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-11_08:2021-07-09, 2021-07-11 signatures=0 Subject: [dpdk-dev] [PATCH] net/mvpp2: fix port max speed overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dana Vardi ethtool_cmd_speed return uint32 and after the arithmetic operation in mrvl_get_max_rate func the result is out of range. Fixes: 429c394417 ("net/mvpp2: support traffic manager") Cc: tdu@semihalf.com Cc: stable@dpdk.org Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mrvl_tm.c b/drivers/net/mvpp2/mrvl_tm.c index a3150328d9..4d75f8e915 100644 --- a/drivers/net/mvpp2/mrvl_tm.c +++ b/drivers/net/mvpp2/mrvl_tm.c @@ -57,7 +57,7 @@ mrvl_get_max_rate(struct rte_eth_dev *dev, uint64_t *rate) close(fd); - *rate = ethtool_cmd_speed(&edata) * 1000 * 1000 / 8; + *rate = (uint64_t)ethtool_cmd_speed(&edata) * 1000 * 1000 / 8; return 0; }