From patchwork Tue Jul 6 11:57:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Walsh X-Patchwork-Id: 95379 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66D5CA0C47; Tue, 6 Jul 2021 13:58:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3690841262; Tue, 6 Jul 2021 13:58:03 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 317AD4120E for ; Tue, 6 Jul 2021 13:58:01 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="206091305" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="206091305" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 04:57:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="496576622" Received: from silpixa00400466.ir.intel.com ([10.237.213.142]) by fmsmga002.fm.intel.com with ESMTP; 06 Jul 2021 04:57:57 -0700 From: Conor Walsh To: david.marchand@redhat.com, konstantin.ananyev@intel.com, vladimir.medvedkin@intel.com, ruifeng.wang@arm.com, jerinj@marvell.com Cc: dev@dpdk.org, paulis.gributs@intel.com, Conor Walsh Date: Tue, 6 Jul 2021 11:57:55 +0000 Message-Id: <20210706115755.1011721-1-conor.walsh@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] examples/l3fwd: remove useless reloads in EM main loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch aligns the l3fwd EM code with the changes made to LPM in commit 74fb854a3de6 ("examples/l3fwd: remove useless reloads in LPM main loop"). This change ensures the compiler knows that the lcore config variables are constant values and the compiler will then optimize the code accordingly. Signed-off-by: Conor Walsh Reviewed-by: Ruifeng Wang Reviewed-by: David Marchand Reviewed-by: Ruifeng Wang Reviewed-by: David Marchand --- examples/l3fwd/l3fwd_em.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c index 01f8dff485..43fc7612e7 100644 --- a/examples/l3fwd/l3fwd_em.c +++ b/examples/l3fwd/l3fwd_em.c @@ -632,14 +632,16 @@ em_main_loop(__rte_unused void *dummy) lcore_id = rte_lcore_id(); qconf = &lcore_conf[lcore_id]; - if (qconf->n_rx_queue == 0) { + const uint16_t n_rx_q = qconf->n_rx_queue; + const uint16_t n_tx_p = qconf->n_tx_port; + if (n_rx_q == 0) { RTE_LOG(INFO, L3FWD, "lcore %u has nothing to do\n", lcore_id); return 0; } RTE_LOG(INFO, L3FWD, "entering main loop on lcore %u\n", lcore_id); - for (i = 0; i < qconf->n_rx_queue; i++) { + for (i = 0; i < n_rx_q; i++) { portid = qconf->rx_queue_list[i].port_id; queueid = qconf->rx_queue_list[i].queue_id; @@ -659,7 +661,7 @@ em_main_loop(__rte_unused void *dummy) diff_tsc = cur_tsc - prev_tsc; if (unlikely(diff_tsc > drain_tsc)) { - for (i = 0; i < qconf->n_tx_port; ++i) { + for (i = 0; i < n_tx_p; ++i) { portid = qconf->tx_port_id[i]; if (qconf->tx_mbufs[portid].len == 0) continue; @@ -675,7 +677,7 @@ em_main_loop(__rte_unused void *dummy) /* * Read packet from RX queues */ - for (i = 0; i < qconf->n_rx_queue; ++i) { + for (i = 0; i < n_rx_q; ++i) { portid = qconf->rx_queue_list[i].port_id; queueid = qconf->rx_queue_list[i].queue_id; nb_rx = rte_eth_rx_burst(portid, queueid, pkts_burst,