| Message ID | 20210705052730.2283962-3-michaelba@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Thomas Monjalon |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74E21A0A0F; Mon, 5 Jul 2021 07:28:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B58AD41155; Mon, 5 Jul 2021 07:28:03 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2080.outbound.protection.outlook.com [40.107.95.80]) by mails.dpdk.org (Postfix) with ESMTP id 54E124114C; Mon, 5 Jul 2021 07:28:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bYm5Gi81DFnLGawNTnl5dWgBo1qxF+g1XtuYMBblEvgH3xaImK0pYsuUxFqFv+t8h/GgiT/+9XmSMkan0OR/eCEVeAHupJ6I79ihQwAmrKeH4atQI/xIogFJIcW98ghhYGOs5qRIE4NvbevwwBOKbNzmVOAWibjpsZuTBW1U345KwjndZGGb17vrG26Vi7PEy/dXnScUJg2dPeQbT3OeIowcHXwFA5Obk84/EiUyvEKqcM9AmUFx9+oPTIB01dEISmtGrkwAJzj4gOtYWtbYam8u6eY4ovIq9PiA+pVKPXeIT+fT4QVCadRmmMLWG8698qAffN4+bn9wR2teP+emXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=WIOyz92HFhIWguAcPQPnLDXSsT9XU5/t87QUR19BFdyBtV8J9ia5guWEsDbvOEzfQ3fpQfHPgHr0s0mU1+IfNrJ2ctosb8KyxfxheoXapwkYkNB7tMr0jUwbxk2YNlpiqTlGSOV8qmJfDbQ72GPDHqEymSGYQ9u85ypbbEMOTu5O7XbNHHc9a2buZTkBAv8ppmzj9cIhRgAgpXjTqZJ8JGeJZjMps1lSoMDcpfoT2LuvBQtkb7UVfztPAC1IPWivWLolT3a+IoUYq8yfOKEk5W6QudOsVj/h55ssHSNuH+ndK4tUUV5zKaDCRkcgjfTg0jZqbq6E6XV/fjD+pWcrJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=hgTROHfa4yUOS0V87u1Zf6Yt1E4vdAYhmAHRPspLcrLK9PPd7B+y/R6/Y65+kxMmfj6k12D3hxhzyV1tjkfk0sP5yb88Ev6mCr/GMncemKTQAKwIphBJveQJFC0D1GB83U7X4NaxK3pi/YGYV59/Wj4nCzwaXk88gprlGKwxpZbGXujlzbLOJ0fUgtuGPipHmoKHOBd+D2YnIFGzzYTWa3oJv22dM5u+9LsCqs92IkI0SioqV1UI7Tg3SBOjUSo8Tb+E3ElbWxa7dUDy8bziOo6qvckKxlp3pifOywCjrQcxKHB7DFwfWpOXykdosW+MMnrY2GQ4Xu3MoIuv2w566w== Received: from CO2PR04CA0195.namprd04.prod.outlook.com (2603:10b6:104:5::25) by BN6PR12MB1826.namprd12.prod.outlook.com (2603:10b6:404:106::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22; Mon, 5 Jul 2021 05:28:00 +0000 Received: from CO1NAM11FT005.eop-nam11.prod.protection.outlook.com (2603:10b6:104:5:cafe::98) by CO2PR04CA0195.outlook.office365.com (2603:10b6:104:5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 05:28:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT005.mail.protection.outlook.com (10.13.174.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Mon, 5 Jul 2021 05:28:00 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 5 Jul 2021 05:27:58 +0000 From: Michael Baum <michaelba@nvidia.com> To: <dev@dpdk.org> CC: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <stable@dpdk.org> Date: Mon, 5 Jul 2021 08:27:30 +0300 Message-ID: <20210705052730.2283962-3-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210705052730.2283962-1-michaelba@nvidia.com> References: <20210628192347.1825713-1-michaelba@nvidia.com> <20210705052730.2283962-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4e2058d-0d90-406f-9942-08d93f75a78d X-MS-TrafficTypeDiagnostic: BN6PR12MB1826: X-Microsoft-Antispam-PRVS: <BN6PR12MB1826CB834A356CA61F980247CC1C9@BN6PR12MB1826.namprd12.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +rhLVg5HmnC5J1lTxA/bMwMCVzyNvkv66WAvY6mNa6KOcP+jPG7dBSLE9S127Vsq6LhULIu/GjTwzioHxXN9/N0sKyVKX7BAjcsBLyyk2/UXji06hA/RrjxlFX1J66bJQjsat86OnUNcttUgSry1B3AlWiJDRmFC2hAJCRCldVsl4sjUZXJb6dy6mjXWtI+oNG/pRtZ7ifQLxcS1m2yQ1OE2A8zE2fQIq39OYqGuloiJdi90PSnKQHbBbW8MPBA0xZbExKPaipH8D1yn+ACrocwZiF50PkGnmjuXft07MCn0rp09VleOtKRHq0z0PlW7a/O6i3JD2Q8LANYl5eAgUayYmb2jaqn5MDLvL01ElADwl04Oytb5lgx5O21PI00WDVDgm4gq9zojpMSj38+sTQHWOEmYvMgkknOhNjbXoZUBhSXYnoMSb3cVUimEbwmDaiGL5ZH5I2K/ZcpmymCGP6yb7cp8b+A1GEXHpLywm1h9aeIMEU+t/hprcSrP9UXh7rL9FIkaa2xDvp7XwJ7xUfr/ZHOEuC5f3mZdn3aDaXnv54aFOqVDKmrvkZW0RisNb0rNaMDGzw3GmdlN+LY1hkQBd0ERO8uzZZCBoQF9KwMOADpJpSG0TsLrLaJGZZN3OBTMKKevvhlNIg+dO5Yzoq7qjZftaYv08qoUsBxsAbcA4u+DF6JBE30OHUBNZGiQTcLyGDsXLWyAe4aP088fgg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(396003)(376002)(46966006)(36840700001)(36906005)(2906002)(36756003)(4744005)(47076005)(316002)(86362001)(2616005)(82310400003)(16526019)(8676002)(1076003)(6916009)(8936002)(478600001)(426003)(186003)(336012)(55016002)(356005)(7636003)(5660300002)(26005)(4326008)(450100002)(82740400003)(6286002)(54906003)(6666004)(7696005)(83380400001)(70586007)(36860700001)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2021 05:28:00.1565 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4e2058d-0d90-406f-9942-08d93f75a78d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT005.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1826 Subject: [dpdk-dev] [PATCH_v2 3/3] regex/mlx5: fix redundancy in PCI remove function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
[PATCH_v2,1/3] regex/mlx5: fix memory region unregistration
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/github-robot | fail | github build: failed |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Michael Baum
July 5, 2021, 5:27 a.m. UTC
In the PCI removal function, PMD releases all driver resources and
cancels the regexdev registry.
However, regexdev registration is accidentally canceled twice.
Remove one of them.
Fixes: b34d816363b5 ("regex/mlx5: support rules import")
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@nvidia.com>
---
drivers/regex/mlx5/mlx5_regex.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index f64dc2824c..1c5bf930ad 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -290,8 +290,6 @@ mlx5_regex_pci_remove(struct rte_pci_device *pci_dev) rte_regexdev_unregister(priv->regexdev); if (priv->ctx) mlx5_glue->close_device(priv->ctx); - if (priv->regexdev) - rte_regexdev_unregister(priv->regexdev); rte_free(priv); } return 0;