From patchwork Fri Jul 2 01:24:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 95152 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0B72A0A0C; Fri, 2 Jul 2021 03:24:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06CEE41303; Fri, 2 Jul 2021 03:24:29 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 4FC614003E for ; Fri, 2 Jul 2021 03:24:28 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id y4so7573048pfi.9 for ; Thu, 01 Jul 2021 18:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=E1lxnOKZdGYRG8KrvK2OLf6V5kENKmSZ4gYXrsmjvQI=; b=BR2eUtgYIggZFj+mx18y0Gz69jl8wpGKMdSwTe9iBIXbMOnuLajH1Oy+5E3itvEEJF mywRyeqJJtVCQdq2iJXTIUj73ooP7cwrME7vBpyBiudX90QeZ9VV7Ic0/eb+jbw28q4l aRSGDAMEHw4DfJbJodC3Eh9eHwF2OefcKUgSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=E1lxnOKZdGYRG8KrvK2OLf6V5kENKmSZ4gYXrsmjvQI=; b=qZNd9glAlTmfYHjE+6r4ORt/l+HFEv7OrNpnSW5kghEgmcNeMXGPJ6iwcAtSZZ8dt/ Eu5ZmaJlzSmrxIgi4Fp7TmuUSxoFh4E6AznDYDF3gF9mnZnQzgp7XlQ0d53ZN0zfZqwQ WtVCvrBcAYVGRibnr6KzolpovISk4+24nHevjjhRBee4CLMkz4PCR2Y7a+L2UN/of5DT 4v1U8db0Zd61agcWJ3BgbHLsFp5jcR12dQ7pkW+3qw/hMNs/FJBA4ksvhb+VPXu7rcqP /VqQA2TW9FTX3tGPtMSaP81hObjHnWbyuQHCGp3jjteE3mWaNkmXjRL+E1laZXKN4sDb l94A== X-Gm-Message-State: AOAM5333uc7wCbyxgB2j1cM6TGMCFLh5HcRWxo0bbys+F1CqrZ+0nLis vWaRpBVxKf5zMEI8S5ZEhIMEHo8ipPVukJyXcDtZ+fVjCDZhrAIIVKO7ul2h2Acr1RAMZujewWv 4gKLL9kcDZE3w4VyYgEE2ZmeZANfHVGg9FapgH3I2SF/+tEB+jaGkVWjyuiNWRrE= X-Google-Smtp-Source: ABdhPJylkthvr2+VMlh7X2tlRFdzorM4zm5Gdgu6HGmgb+LrDXq3zM0re8kEJhG8xMs4mKUm6ZNmgw== X-Received: by 2002:a62:7612:0:b029:30f:c530:db69 with SMTP id r18-20020a6276120000b029030fc530db69mr2807575pfc.17.1625189067011; Thu, 01 Jul 2021 18:24:27 -0700 (PDT) Received: from localhost.localdomain (ip68-5-71-166.oc.oc.cox.net. [68.5.71.166]) by smtp.gmail.com with ESMTPSA id h24sm823804pjv.27.2021.07.01.18.24.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jul 2021 18:24:26 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: stable@dpdk.org, Lance Richardson Date: Thu, 1 Jul 2021 18:24:15 -0700 Message-Id: <20210702012415.54208-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: References: MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v2] net/bnxt: fix rxq interrupt setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Don't set rxq interrupt config Applications can set the rxq interrupt config to 1 or 0 as needed. If an application is not interested in handling Rx interrupts and prefers to poll Rx rings, there is no need for the PMD to set this config option to 1. Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- v1->v2: Setting 0 or 1 in PMD would override application setting. So skip it. --- drivers/net/bnxt/bnxt_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 495c6cd21e..ed09f1bf52 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1011,7 +1011,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, }; eth_dev->data->dev_conf.intr_conf.lsc = 1; - eth_dev->data->dev_conf.intr_conf.rxq = 1; dev_info->rx_desc_lim.nb_min = BNXT_MIN_RING_DESC; dev_info->rx_desc_lim.nb_max = BNXT_MAX_RX_RING_DESC; dev_info->tx_desc_lim.nb_min = BNXT_MIN_RING_DESC;