From patchwork Thu Jul 1 14:11:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 95147 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC2FEA0A0C; Thu, 1 Jul 2021 16:11:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 750EC40141; Thu, 1 Jul 2021 16:11:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 628994003E for ; Thu, 1 Jul 2021 16:11:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625148707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3HMy7oWUyfiPGbUQd1x7M6EEGYI1Fmb7FtpuMCbPodw=; b=YCGFQJeSe+PfjLJs1BZ8D0mmzdJ72fzdvkQixQ+MkXju9IJo0KRLpePWs/CZ9ZJa+wuzqd K1rSB68iIqKKlWoLLfsSH/yTpM8On4vMUmRAU5AT+3dw+Bo7KF+NdcAiw6Jkn9s8CiclM/ ktBNZjBIjtgm4cb4UqJHUQoVwYwqNLE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-x1yQY-17OgC3RI-JWTeXXA-1; Thu, 01 Jul 2021 10:11:46 -0400 X-MC-Unique: x1yQY-17OgC3RI-JWTeXXA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CE11800D62; Thu, 1 Jul 2021 14:11:45 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.195.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 557E410016F5; Thu, 1 Jul 2021 14:11:44 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Thomas Monjalon Date: Thu, 1 Jul 2021 16:11:31 +0200 Message-Id: <20210701141131.8076-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] devtools: recommend new logtype helpers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following commit eeded2044af5 ("log: register with standardized names"), the new helpers should be preferred so that we can maintain a consistent naming for logtypes. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index c30dadd962..c314d83a29 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -126,6 +126,14 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # refrain from using RTE_LOG_REGISTER for drivers and libs + awk -v FOLDERS='lib drivers' \ + -v EXPRESSIONS='\\' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using RTE_LOG_REGISTER, prefer RTE_LOG_REGISTER_(DEFAULT|SUFFIX)' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # SVG must be included with wildcard extension to allow conversion awk -v FOLDERS='doc' \ -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \