From patchwork Thu Jul 1 06:59:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: danat@marvell.com X-Patchwork-Id: 95100 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD2AEA0A0C; Thu, 1 Jul 2021 08:59:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A91D2412AA; Thu, 1 Jul 2021 08:59:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D4E784067C; Thu, 1 Jul 2021 08:59:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1616t3oh028245; Wed, 30 Jun 2021 23:59:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=BNg11HI5zr4rov/3sHV3PWknMcv5n5LDM82aiwnBHN4=; b=c5U+o5Zhx0vCvw/ir0lDpc+hPZmuvkOFPFd5U6inrc7PS/ERSMPomW5jdAXPM5rwiy0b xew07afYgk0/Q8PzTw8KdpT32VIOQOOKv3HT+E6hPbyLUt+0r6iAKVTbVeCEFSxeK2NN yfDczPyp7OgjU7QLDnKLcGBw8St0F8AL+HgsuYBtcoRGdnCk7iEXs9gngH8s5bswQhne hxLik1gkp9q27UBZ7dZqjjcPGlKKw0h5YyKz0nCqbdYFdFX8puDb8aPNAowa5Eh5U85W zZMnnVPa47pWMMJYWxeWEAoJFABlYbavFjwjxoz9MSCqLPB6vSWqww8v4Quv/1mEVt0V Jw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 39h2h4hg79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 30 Jun 2021 23:59:25 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 30 Jun 2021 23:59:24 -0700 Received: from jupiter077.il.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 30 Jun 2021 23:59:22 -0700 From: To: CC: , , , , Date: Thu, 1 Jul 2021 09:59:20 +0300 Message-ID: <20210701065920.31096-1-danat@marvell.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Proofpoint-GUID: SBWWGNVbHhFTDiuZRRp3lYpW2GltfWjV X-Proofpoint-ORIG-GUID: SBWWGNVbHhFTDiuZRRp3lYpW2GltfWjV X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-01_01:2021-06-30, 2021-07-01 signatures=0 Subject: [dpdk-dev] [PATCH] crypto/mvsam: fix memset of mrvl sess private data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dana Vardi This patch fix wrong clear memory session pointer. When call mrvl_crypto_pmd_sym_session_clear function, it might cause the following error: CRYPTODEV: set_sym_session_private_data() line 497: Set private data for driver 1 not allowed This fix set zeroes to mrvl_crypto_session pointer instead to rte_cryptodev_sym_session pointer, and will verify that rte_cryptodev_sym_session pointer will not lose data such as nb_drivers. Bugzilla ID: 646 Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver") Cc: stable@dpdk.org Signed-off-by: Dana Vardi Reviewed-by: Michael Shamis Reviewed-by: Liron Himi --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c index 3cb7e3b9c..1a0a9fc14 100644 --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c @@ -794,7 +794,7 @@ mrvl_crypto_pmd_sym_session_clear(struct rte_cryptodev *dev, MRVL_LOG(ERR, "Error while destroying session!"); } - memset(sess, 0, sizeof(struct mrvl_crypto_session)); + memset(mrvl_sess, 0, sizeof(struct mrvl_crypto_session)); struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv); set_sym_session_private_data(sess, index, NULL); rte_mempool_put(sess_mp, sess_priv);