From patchwork Wed Jun 30 13:51:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 95083 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4290DA0A0F; Wed, 30 Jun 2021 15:52:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A5D24128C; Wed, 30 Jun 2021 15:52:35 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id DDBF741273 for ; Wed, 30 Jun 2021 15:52:30 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id j2so3711773wrs.12 for ; Wed, 30 Jun 2021 06:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=evhZW9wftKtpez2phFWijAL4t1JEhsyyuM27rbpI6Ck=; b=G/qH4omHzIfextPgSE4P2xM/tQq3fcAq5LM/6cqWDgT2KYtJmpZqwSAfWP1o5c4b4d F1b+BEj5GZDKE6BzUeEaOkwkXQa0MzBHHf4Hh9yro7aPtKPvglazg9P+WX9KrjujtsSo lPUC3y0grE0AYkG+aP9rwVEDvTnpI/iFBOIyKB8/aRqyAVKr8fBXwk1w3ZYN39vSwg6M uM+va5gTEg71o9AeOwuFDpQfpSljsGKQnyfUo7yUnhHBwCddXwzRpWqwpjwK1ZuZzGbG wBamX9y6YYi2mS9zlugkZHaj/EtgyoHSC8GqQCBF5Fxc2kL5RfTs/LrRXChUMryT1qrv jIVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=evhZW9wftKtpez2phFWijAL4t1JEhsyyuM27rbpI6Ck=; b=e1o1Pe40qoFhwdeIasajY/zRVgOITv2ljZ5chLOtZZuF9sx0Jj6Kj5nZXXOyStoDHR kUvSmmvotIWe1nKhd10yRwrlHQyQOw5bqVB55nR7yWOSYwIpxHuaVa1CDCgAlFJ7mzBJ WXYdkAjy+FzuH6UJZEa1gbyVhUZAnDCx8vVFatcqZA01L6937uSyWfd3V8Dn7Nk62ySm BRAXRw7OEZUT9VdMSTc8r1xvc44tlJgrrQBFzzDIk+QVtiwRuQYHoV3bYCeauW87WTb9 rTv5B9myW9VGreBHKqxAwo08KKl5xmTGQOV+tiK5MLg6JaNBJl9yGrrgQqYlOqz5WaZ4 uRQQ== X-Gm-Message-State: AOAM531riXUHyt1lDpvmaViE+c9VZRLoj3wPeAzcNBleLtdtkpseeMN/ i1w3o6vANWQXFHu96Qtdgf+OOC8JFehdqA== X-Google-Smtp-Source: ABdhPJxIW94nOCR6Zqqn5fdF9wDnD/uZrDjSasAbDVPueT77VP0HiMnr5eBYGIEEU9jGDovwL8BnkA== X-Received: by 2002:a5d:5742:: with SMTP id q2mr20152078wrw.256.1625061150621; Wed, 30 Jun 2021 06:52:30 -0700 (PDT) Received: from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g15sm193026wrs.50.2021.06.30.06.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 06:52:30 -0700 (PDT) From: Olivier Matz To: dev@dpdk.org Cc: guohongzhi1@huawei.com, keith.wiles@intel.com, mb@smartsharesystems.com, thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Date: Wed, 30 Jun 2021 15:51:58 +0200 Message-Id: <20210630135158.8108-5-olivier.matz@6wind.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210630135158.8108-1-olivier.matz@6wind.com> References: <20210427135755.927-1-olivier.matz@6wind.com> <20210630135158.8108-1-olivier.matz@6wind.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 4/4] test/cksum: new test for L3/L4 checksum API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add a simple unit test for checksum API. Signed-off-by: Olivier Matz --- MAINTAINERS | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 2 + app/test/test_cksum.c | 271 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 280 insertions(+) create mode 100644 app/test/test_cksum.c diff --git a/MAINTAINERS b/MAINTAINERS index 5877a16971..4347555ebc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1314,6 +1314,7 @@ Packet processing Network headers M: Olivier Matz F: lib/net/ +F: app/test/test_cksum.c Packet CRC M: Jasvinder Singh diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py index 11f9c8640c..302d6374c1 100644 --- a/app/test/autotest_data.py +++ b/app/test/autotest_data.py @@ -567,6 +567,12 @@ "Func": default_autotest, "Report": None, }, + { + "Name": "Checksum autotest", + "Command": "cksum_autotest", + "Func": default_autotest, + "Report": None, + }, # #Please always keep all dump tests at the end and together! # diff --git a/app/test/meson.build b/app/test/meson.build index 0a5f425578..ef90b16f16 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -17,6 +17,7 @@ test_sources = files( 'test_bitmap.c', 'test_bpf.c', 'test_byteorder.c', + 'test_cksum.c', 'test_cmdline.c', 'test_cmdline_cirbuf.c', 'test_cmdline_etheraddr.c', @@ -188,6 +189,7 @@ fast_tests = [ ['atomic_autotest', false], ['bitops_autotest', true], ['byteorder_autotest', true], + ['cksum_autotest', true], ['cmdline_autotest', true], ['common_autotest', true], ['cpuflags_autotest', true], diff --git a/app/test/test_cksum.c b/app/test/test_cksum.c new file mode 100644 index 0000000000..cd983d7c01 --- /dev/null +++ b/app/test/test_cksum.c @@ -0,0 +1,271 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright 2021 6WIND S.A. + */ + +#include +#include +#include +#include + +#include +#include +#include + +#include "test.h" + +#define MEMPOOL_CACHE_SIZE 0 +#define MBUF_DATA_SIZE 256 +#define NB_MBUF 128 + +/* + * Test L3/L4 checksum API. + */ + +#define GOTO_FAIL(str, ...) do { \ + printf("cksum test FAILED (l.%d): <" str ">\n", \ + __LINE__, ##__VA_ARGS__); \ + goto fail; \ + } while (0) + +/* generated in scapy with Ether()/IP()/TCP())) */ +static const char test_cksum_ipv4_tcp[] = { + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x08, 0x00, 0x45, 0x00, + 0x00, 0x28, 0x00, 0x01, 0x00, 0x00, 0x40, 0x06, + 0x7c, 0xcd, 0x7f, 0x00, 0x00, 0x01, 0x7f, 0x00, + 0x00, 0x01, 0x00, 0x14, 0x00, 0x50, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x50, 0x02, + 0x20, 0x00, 0x91, 0x7c, 0x00, 0x00, + +}; + +/* generated in scapy with Ether()/IPv6()/TCP()) */ +static const char test_cksum_ipv6_tcp[] = { + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x08, 0x00, 0x60, 0x00, + 0x00, 0x00, 0x00, 0x14, 0x06, 0x40, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x14, + 0x00, 0x50, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x50, 0x02, 0x20, 0x00, 0x8f, 0x7d, + 0x00, 0x00, +}; + +/* generated in scapy with Ether()/IP()/UDP()/Raw('x')) */ +static const char test_cksum_ipv4_udp[] = { + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x08, 0x00, 0x45, 0x00, + 0x00, 0x1d, 0x00, 0x01, 0x00, 0x00, 0x40, 0x11, + 0x7c, 0xcd, 0x7f, 0x00, 0x00, 0x01, 0x7f, 0x00, + 0x00, 0x01, 0x00, 0x35, 0x00, 0x35, 0x00, 0x09, + 0x89, 0x6f, 0x78, +}; + +/* generated in scapy with Ether()/IPv6()/UDP()/Raw('x')) */ +static const char test_cksum_ipv6_udp[] = { + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x86, 0xdd, 0x60, 0x00, + 0x00, 0x00, 0x00, 0x09, 0x11, 0x40, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x35, + 0x00, 0x35, 0x00, 0x09, 0x87, 0x70, 0x78, +}; + +/* generated in scapy with Ether()/IP(options='\x00')/UDP()/Raw('x')) */ +static const char test_cksum_ipv4_opts_udp[] = { + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x08, 0x00, 0x46, 0x00, + 0x00, 0x21, 0x00, 0x01, 0x00, 0x00, 0x40, 0x11, + 0x7b, 0xc9, 0x7f, 0x00, 0x00, 0x01, 0x7f, 0x00, + 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x35, + 0x00, 0x35, 0x00, 0x09, 0x89, 0x6f, 0x78, +}; + +/* test l3/l4 checksum api */ +static int +test_l4_cksum(struct rte_mempool *pktmbuf_pool, const char *pktdata, size_t len) +{ + struct rte_net_hdr_lens hdr_lens; + struct rte_mbuf *m = NULL; + uint32_t packet_type; + uint16_t prev_cksum; + void *l3_hdr; + void *l4_hdr; + uint32_t l3; + uint32_t l4; + char *data; + + m = rte_pktmbuf_alloc(pktmbuf_pool); + if (m == NULL) + GOTO_FAIL("Cannot allocate mbuf"); + + data = rte_pktmbuf_append(m, len); + if (data == NULL) + GOTO_FAIL("Cannot append data"); + + memcpy(data, pktdata, len); + + packet_type = rte_net_get_ptype(m, &hdr_lens, RTE_PTYPE_ALL_MASK); + l3 = packet_type & RTE_PTYPE_L3_MASK; + l4 = packet_type & RTE_PTYPE_L4_MASK; + + l3_hdr = rte_pktmbuf_mtod_offset(m, void *, hdr_lens.l2_len); + l4_hdr = rte_pktmbuf_mtod_offset(m, void *, + hdr_lens.l2_len + hdr_lens.l3_len); + + if (l3 == RTE_PTYPE_L3_IPV4 || l3 == RTE_PTYPE_L3_IPV4_EXT) { + struct rte_ipv4_hdr *ip = l3_hdr; + + /* verify IPv4 checksum */ + if (rte_ipv4_cksum(l3_hdr) != 0) + GOTO_FAIL("invalid IPv4 checksum verification"); + + /* verify bad IPv4 checksum */ + ip->hdr_checksum++; + if (rte_ipv4_cksum(l3_hdr) == 0) + GOTO_FAIL("invalid IPv4 bad checksum verification"); + ip->hdr_checksum--; + + /* recalculate IPv4 checksum */ + prev_cksum = ip->hdr_checksum; + ip->hdr_checksum = 0; + ip->hdr_checksum = rte_ipv4_cksum(ip); + if (ip->hdr_checksum != prev_cksum) + GOTO_FAIL("invalid IPv4 checksum calculation"); + + /* verify L4 checksum */ + if (rte_ipv4_udptcp_cksum_verify(l3_hdr, l4_hdr) != 0) + GOTO_FAIL("invalid L4 checksum verification"); + + if (l4 == RTE_PTYPE_L4_TCP) { + struct rte_tcp_hdr *tcp = l4_hdr; + + /* verify bad TCP checksum */ + tcp->cksum++; + if (rte_ipv4_udptcp_cksum_verify(l3_hdr, l4_hdr) == 0) + GOTO_FAIL("invalid bad TCP checksum verification"); + tcp->cksum--; + + /* recalculate TCP checksum */ + prev_cksum = tcp->cksum; + tcp->cksum = 0; + tcp->cksum = rte_ipv4_udptcp_cksum(l3_hdr, l4_hdr); + if (tcp->cksum != prev_cksum) + GOTO_FAIL("invalid TCP checksum calculation"); + + } else if (l4 == RTE_PTYPE_L4_UDP) { + struct rte_udp_hdr *udp = l4_hdr; + + /* verify bad UDP checksum */ + udp->dgram_cksum++; + if (rte_ipv4_udptcp_cksum_verify(l3_hdr, l4_hdr) == 0) + GOTO_FAIL("invalid bad UDP checksum verification"); + udp->dgram_cksum--; + + /* recalculate UDP checksum */ + prev_cksum = udp->dgram_cksum; + udp->dgram_cksum = 0; + udp->dgram_cksum = rte_ipv4_udptcp_cksum(l3_hdr, + l4_hdr); + if (udp->dgram_cksum != prev_cksum) + GOTO_FAIL("invalid TCP checksum calculation"); + } + } else if (l3 == RTE_PTYPE_L3_IPV6 || l3 == RTE_PTYPE_L3_IPV6_EXT) { + if (rte_ipv6_udptcp_cksum_verify(l3_hdr, l4_hdr) != 0) + GOTO_FAIL("invalid L4 checksum verification"); + + if (l4 == RTE_PTYPE_L4_TCP) { + struct rte_tcp_hdr *tcp = l4_hdr; + + /* verify bad TCP checksum */ + tcp->cksum++; + if (rte_ipv6_udptcp_cksum_verify(l3_hdr, l4_hdr) == 0) + GOTO_FAIL("invalid bad TCP checksum verification"); + tcp->cksum--; + + /* recalculate TCP checksum */ + prev_cksum = tcp->cksum; + tcp->cksum = 0; + tcp->cksum = rte_ipv6_udptcp_cksum(l3_hdr, l4_hdr); + if (tcp->cksum != prev_cksum) + GOTO_FAIL("invalid TCP checksum calculation"); + + } else if (l4 == RTE_PTYPE_L4_UDP) { + struct rte_udp_hdr *udp = l4_hdr; + + /* verify bad UDP checksum */ + udp->dgram_cksum++; + if (rte_ipv6_udptcp_cksum_verify(l3_hdr, l4_hdr) == 0) + GOTO_FAIL("invalid bad UDP checksum verification"); + udp->dgram_cksum--; + + /* recalculate UDP checksum */ + prev_cksum = udp->dgram_cksum; + udp->dgram_cksum = 0; + udp->dgram_cksum = rte_ipv6_udptcp_cksum(l3_hdr, + l4_hdr); + if (udp->dgram_cksum != prev_cksum) + GOTO_FAIL("invalid TCP checksum calculation"); + } + } + + rte_pktmbuf_free(m); + + return 0; + +fail: + if (m) + rte_pktmbuf_free(m); + + return -1; +} + +static int +test_cksum(void) +{ + struct rte_mempool *pktmbuf_pool = NULL; + + /* create pktmbuf pool if it does not exist */ + pktmbuf_pool = rte_pktmbuf_pool_create("test_cksum_mbuf_pool", + NB_MBUF, MEMPOOL_CACHE_SIZE, 0, MBUF_DATA_SIZE, + SOCKET_ID_ANY); + + if (pktmbuf_pool == NULL) + GOTO_FAIL("cannot allocate mbuf pool"); + + if (test_l4_cksum(pktmbuf_pool, test_cksum_ipv4_tcp, + sizeof(test_cksum_ipv4_tcp)) < 0) + GOTO_FAIL("checksum error on ipv4_tcp"); + + if (test_l4_cksum(pktmbuf_pool, test_cksum_ipv6_tcp, + sizeof(test_cksum_ipv6_tcp)) < 0) + GOTO_FAIL("checksum error on ipv6_tcp"); + + if (test_l4_cksum(pktmbuf_pool, test_cksum_ipv4_udp, + sizeof(test_cksum_ipv4_udp)) < 0) + GOTO_FAIL("checksum error on ipv4_udp"); + + if (test_l4_cksum(pktmbuf_pool, test_cksum_ipv6_udp, + sizeof(test_cksum_ipv6_udp)) < 0) + GOTO_FAIL("checksum error on ipv6_udp"); + + if (test_l4_cksum(pktmbuf_pool, test_cksum_ipv4_opts_udp, + sizeof(test_cksum_ipv4_opts_udp)) < 0) + GOTO_FAIL("checksum error on ipv4_opts_udp"); + + rte_mempool_free(pktmbuf_pool); + + return 0; + +fail: + rte_mempool_free(pktmbuf_pool); + + return -1; +} +#undef GOTO_FAIL + +REGISTER_TEST_COMMAND(cksum_autotest, test_cksum);