From patchwork Wed Jun 30 12:46:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 95076 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A032CA0A0F; Wed, 30 Jun 2021 14:49:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE0AF412EE; Wed, 30 Jun 2021 14:47:17 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by mails.dpdk.org (Postfix) with ESMTP id 0AE66412D7 for ; Wed, 30 Jun 2021 14:47:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aqffmrWxEVgr9hzmexWrbyRzMoVRaTxnqxAnKvp+5GTAQkmBhT7VjJR/LRI2UyC8rB3Sbnugdkf/JWIW05591wwfIB8z3pxc9CLYZ08scCdSlckymPjPlprcnQngmS0fNvd5vnSCLTsPYqaQsgcOKP31OFtJKXHxaTHqF0MEDTXpGF4UaOf/MZ1R8QQy0Io7Vuso/xE+Uwg66DRYl8BkBG/fr1O4HAh5WJNbpfEcuRBTKMr/6LZIqkLhQtmHEOcW79TUH3l9dBwlG0RXOOW6MKcc2o5IAmN2Np98FHm53wU+v3/1/JNFtj6badOBAYooJiwwnD3Ot0AROBN0gFdVhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jf0WosUb0J5nOPlTECv5/FZR9BpVRZ49Qsp8jXrWDVM=; b=Ecs3H+8zd6qg0KxmydibP9I4SsmKgISMma4Zqf3/hHvUqEumwbQQ+nw6tb7W0Rm8Vu6ZL8OoDKUS4becXmi/51fFfj+nzrCHejkL4U1WKjaAUMrUOLiA8X4z1AiqtmW4TdVRq9Fp+2QcfJ2yfN6lOYlG5H7+VC+26XOLoN8eQcrcMSLBOqatR2gTEkTFLMd89OiHRIeXV9KcBWd/G4cSyhLLXF5T58qEw3IwVNOerXcKfzhQnLs3qEiOwAGoLyDoIewbDzkuIrSa5LBOjeFUpfdlUejtIM0kJrDC2ckLv0/67YzqVt5M9l5jro0Q4MwaBILcSs66siKvla+A566CnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jf0WosUb0J5nOPlTECv5/FZR9BpVRZ49Qsp8jXrWDVM=; b=SpFKIOytaI3D7iyBM92f1ZTHY2fyg7YJNShnPkKJMvc13WQZ1PA+rs68/Tp1Fbt7Ad/8Q0JTK79PC4npcXOe8TkmjRQWBWcKxc6rCJJhyUBL+BAcB2zrQUZ6PZFGg+cop8H9nkHLthJPHoux5bMFsDsJTMCnI8jCR3TKN3Md5xrcsev9gGWqDg1a8UyjwjvIKUVUTaWwQZpe2iVss0p8nJ6dMYv2SvtrF7mt4rkcbSY5FbLPzA4evPHcnrluMp4EimjS4K7h/0i2Ti+xPTMJIiuiy/VAZuRghyE2r4P4WSW93S8eXvQr5LHhF+RGy81e5dbUUQOfg5Tq9swGoSJN1A== Received: from BN9PR03CA0350.namprd03.prod.outlook.com (2603:10b6:408:f6::25) by BYAPR12MB2934.namprd12.prod.outlook.com (2603:10b6:a03:13b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Wed, 30 Jun 2021 12:47:14 +0000 Received: from BN8NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::1f) by BN9PR03CA0350.outlook.office365.com (2603:10b6:408:f6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.21 via Frontend Transport; Wed, 30 Jun 2021 12:47:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT013.mail.protection.outlook.com (10.13.176.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 12:47:13 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 30 Jun 2021 12:47:06 +0000 From: Suanming Mou To: , CC: , , Date: Wed, 30 Jun 2021 15:46:09 +0300 Message-ID: <20210630124609.8711-23-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210630124609.8711-1-suanmingm@nvidia.com> References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210630124609.8711-1-suanmingm@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2de5d7c-60ca-44f4-fc79-08d93bc52f77 X-MS-TrafficTypeDiagnostic: BYAPR12MB2934: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:202; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kQ5CyS+F5zQApyTi8RLwREpODTkoMOz8/gwmzVTgO7Qv/58D2/9kfEkl6Y3CrFmD6BKAosMtNL/aYGqw/KoC1gRdvf5q3VYRwECre4wIKFJQykBc/OeE/UyudTvTDcbKLdevrQ1wPHgYINJAeVDcRVt6riMzrTvGHX99xriXwaAe5K97iv37QMrgqsPwcx6tpsfd7axYiZQhMLi+/gzIxNNhjiXWRloBNAtHNEJAIUwaUzm3lif52ChDFNKCg/9DBBi9lu+TgdhIJ0PZqqKDwqec8KnFH2Ze2Pw43E3OE8WHxntFp04A6X5F/nB14VOU0wYNapuhbIgHD4wbO/em8GeWvjzKsRlsLZnaIdtjcjpJkwF1TZ6dSaOP2g0JD3JzJoP1nuqCFPpq/ksB6Ebs9qttPZCFyBzqoDYGEe6L5nJ/W8EEkCnAiZ8ireGwQLJKu6lUi+T7P1Jijwc8JmMtQJUQHtmvQ2xq/SvFCBlcwibnWIvIxF7+TVTpZHSdjNqXSLgM0Jd5jNKzXXmSi/m3aHkZhAGfpIVZuNwd67IEvx8B1CDlLcOjLatjBYnmUbx3wh+MlwURYtHFP0Rb4Sc030SgrpQTiKroRQlI67rnh7b2vlXyWzOaG50d39epXpZZdgw4XZcN+4bScwxMy+0g2f3rushWWUhjlQ7QgSCbFnD+04yz1QFgoRN+prad9vOVInV+bsSEFqSq+AHQkF82pA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(346002)(396003)(46966006)(36840700001)(7636003)(6286002)(70586007)(70206006)(110136005)(1076003)(47076005)(186003)(82740400003)(16526019)(83380400001)(36756003)(55016002)(36860700001)(26005)(356005)(8936002)(54906003)(8676002)(478600001)(426003)(336012)(6636002)(82310400003)(5660300002)(2906002)(4326008)(86362001)(7696005)(2616005)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 12:47:13.8615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c2de5d7c-60ca-44f4-fc79-08d93bc52f77 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2934 Subject: [dpdk-dev] [PATCH v2 22/22] net/mlx5: optimize Rx queue match X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As hrxq struct has the indirect table pointer, while matching the hrxq, better to use the hrxq indirect table instead of searching from the list. This commit optimizes the hrxq indirect table matching. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 7893b3edd4..23685d7654 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2094,23 +2094,19 @@ mlx5_ind_table_obj_modify(struct rte_eth_dev *dev, } int -mlx5_hrxq_match_cb(void *tool_ctx, struct mlx5_list_entry *entry, void *cb_ctx) +mlx5_hrxq_match_cb(void *tool_ctx __rte_unused, struct mlx5_list_entry *entry, + void *cb_ctx) { - struct rte_eth_dev *dev = tool_ctx; struct mlx5_flow_cb_ctx *ctx = cb_ctx; struct mlx5_flow_rss_desc *rss_desc = ctx->data; struct mlx5_hrxq *hrxq = container_of(entry, typeof(*hrxq), entry); - struct mlx5_ind_table_obj *ind_tbl; - if (hrxq->rss_key_len != rss_desc->key_len || + return (hrxq->rss_key_len != rss_desc->key_len || memcmp(hrxq->rss_key, rss_desc->key, rss_desc->key_len) || - hrxq->hash_fields != rss_desc->hash_fields) - return 1; - ind_tbl = mlx5_ind_table_obj_get(dev, rss_desc->queue, - rss_desc->queue_num); - if (ind_tbl) - mlx5_ind_table_obj_release(dev, ind_tbl, hrxq->standalone); - return ind_tbl != hrxq->ind_table; + hrxq->hash_fields != rss_desc->hash_fields || + hrxq->ind_table->queues_n != rss_desc->queue_num || + memcmp(hrxq->ind_table->queues, rss_desc->queue, + rss_desc->queue_num * sizeof(rss_desc->queue[0]))); } /**