From patchwork Wed Jun 30 12:45:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 95064 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 559B8A0A0F; Wed, 30 Jun 2021 14:47:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B6EA412A5; Wed, 30 Jun 2021 14:47:00 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2087.outbound.protection.outlook.com [40.107.236.87]) by mails.dpdk.org (Postfix) with ESMTP id 8EE674129A for ; Wed, 30 Jun 2021 14:46:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aJmpoTaKbWfNNyHUNvdl+rh3Rz/qEO7LrBiW/NDL1mUEPJx7jhrjIj5zD2Kbk/QC3K+qDl7Px/lHoPMQYolLymAGdqUH12jiB9hVLCIo6RGE9BOPe10xclCYBJy9jjgnt54VRQ0dysvpiyaiYO9EDDtjdpri5wCFEfF/64/Kg4zl4m7rmqkVQ2CNuWi1F1vhkpB34DDROer+MEPCz41P44C+CkgqiC6BiGsMCuDqPClSuJZ3GaTjz1S45/UfgUnpLtoBpQoaHAD7lncFmwuWASVutJs3LYC5AkPxHSGYgkuLL2VbwCFzKEee2WUZWS3eiYmeVsnqzoLCNLAauIeGFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0ZO3LzgDLilvO0Hjo8/zxkeJs1+OOB1uCF2gI2tPJM=; b=OLqdE+Q8JlwV+WcTmXx8jZ1gxlW0xGdAsWvrP8o+r0nfAPNk5PRlPcwVvQCkPfZVL1OQSV7K1TcJRzH0J8iFnNTamcjR377JIPvwRsD20UDhrgN86HjlTWFkRoCD/wiZiLR9Xjew1MsGGBAb2oYFh4yU2ESNQMJIvR5w9sftPlMpgaPOOSSin1kr3mXnY4cGSLQjDFU9giULOzDV4tlLYMhbtvtb9CsLGXY6/Jiq7fmRl71uspCDalKRXNocgOMeTWLxoGWaxX3a3r1WjIZw9LFVs9DyaQ1VIQme3bUOIe6nE4IgWq6qIIAlopik50B3+ArN/qCSpE5VPSlhf5/6Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0ZO3LzgDLilvO0Hjo8/zxkeJs1+OOB1uCF2gI2tPJM=; b=V7GL5Te/iDKur4Ur9nXPwbLdgRPzHeAoE3l2szY7SsfvHlkw8syR8Aq/ngI0ofAv/ziDG+w9lV4nv11xzsq20MKc4cxBc8d1B9+wW/ofDfp5e1cWmMku77qjCLq3VVRLs6emLeTeoifPXFNSNz9vhhpfMxj9LhL9FmBIbezNfEvvRo+gKTWNLe6uiTXJH3fQQHoRQ+dIgpMbQenRTHiqcPqbBJgLUXg+IGdflejdCwYOXQZKn4JxidnobyFSKGPdghhhLc4MRom/Y2jZdL0QF9i0gj5Ry+LWSndHISzqGlzBbCBmiJDdKpEsikQ/V3Igyl4PjWrjpFv6I/s5RmVFzA== Received: from BN6PR1701CA0020.namprd17.prod.outlook.com (2603:10b6:405:15::30) by CY4PR12MB1784.namprd12.prod.outlook.com (2603:10b6:903:11e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Wed, 30 Jun 2021 12:46:55 +0000 Received: from BN8NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:405:15:cafe::e9) by BN6PR1701CA0020.outlook.office365.com (2603:10b6:405:15::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 12:46:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT045.mail.protection.outlook.com (10.13.177.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 12:46:54 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 30 Jun 2021 12:46:43 +0000 From: Suanming Mou To: , CC: , , Date: Wed, 30 Jun 2021 15:45:57 +0300 Message-ID: <20210630124609.8711-11-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210630124609.8711-1-suanmingm@nvidia.com> References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210630124609.8711-1-suanmingm@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd80e35f-6b46-4fc4-df4d-08d93bc52417 X-MS-TrafficTypeDiagnostic: CY4PR12MB1784: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:249; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SbOtEHQrFR07Ut2ABTpWoM39EQNC6KiyHqoynUkNkblA3pf2OFrTvyVQ63tWaZl5GQ402xZCyqamYZrhK5Ua2CDNymErNW7ccHYAiPgvwWe3BzHcAc1Fat7eAGl1r3ESLS/5i+2JXXand6OkLmRDoSPIVLRceTcJ3LRLPDzJyVFCp9ewHgdFD7YoVleVq1iYlG8m7jqOdXHYHN+9742sWraxzIVcNEQ0v24rzXhsy48ULXcsEB55cqC3LM4w2PW3VbCSuivpxNnDD8qGX1yI1X9mdOMFwjHWsE1v8p0oEB1xLnnWeHRbuRxz2YSGRP7XCHD37RrbB+MHKkHhSHs475j0XNB/Yc0+gCzx+Dcxjlken0xDly0GDius7TPTZb2qm7StqzHnI/2SyDUMHSsh7wZHMd3o0ePjl5rJ1Qbdwm1blQ/soyMsAdIzPiHnQU6my8FAr3d4rz6uTclUYs7oWiZ4NooN3fI0p9SGTiOrF9gMAgP1k7zvWPqurSUTIe0y4LxAwzkl5TCCtQxtJ8hXjIdARFleBO9NDaFow0dPDMuUx9dbXz8+MzvVfbEp9ap2qDmQMyAFDjwRohRDaWpyCBKu1FKfgjwvt5F2xu7ORwabGzR52CAvoUY1yfa9W+dNJ0fT3Hj3+RGOY+w09DYIUJYuLwg+ycMKSaED111Si/chjjvpAM6o5B1q1DYI9WX0f9z29dPAq+drcACFufj4nA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(39860400002)(396003)(36840700001)(46966006)(70206006)(186003)(16526019)(83380400001)(6666004)(110136005)(316002)(36860700001)(70586007)(1076003)(86362001)(54906003)(7696005)(47076005)(4326008)(356005)(82310400003)(55016002)(8936002)(5660300002)(6636002)(426003)(7636003)(26005)(82740400003)(2616005)(8676002)(6286002)(336012)(2906002)(36756003)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 12:46:54.8057 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd80e35f-6b46-4fc4-df4d-08d93bc52417 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1784 Subject: [dpdk-dev] [PATCH v2 10/22] net/mlx5: relax the list utility atomic operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Matan Azrad The atomic operation in the list utility no need a barriers because the critical part are managed by RW lock. Relax them. Signed-off-by: Matan Azrad Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_utils.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index 7cdf44dcf7..29248c80ed 100644 --- a/drivers/net/mlx5/mlx5_utils.c +++ b/drivers/net/mlx5/mlx5_utils.c @@ -50,13 +50,13 @@ __list_lookup(struct mlx5_list *list, int lcore_index, void *ctx, bool reuse) if (list->cb_match(list, entry, ctx) == 0) { if (reuse) { ret = __atomic_add_fetch(&entry->ref_cnt, 1, - __ATOMIC_ACQUIRE) - 1; + __ATOMIC_RELAXED) - 1; DRV_LOG(DEBUG, "mlx5 list %s entry %p ref: %u.", list->name, (void *)entry, entry->ref_cnt); } else if (lcore_index < RTE_MAX_LCORE) { ret = __atomic_load_n(&entry->ref_cnt, - __ATOMIC_ACQUIRE); + __ATOMIC_RELAXED); } if (likely(ret != 0 || lcore_index == RTE_MAX_LCORE)) return entry; @@ -181,7 +181,7 @@ mlx5_list_register(struct mlx5_list *list, void *ctx) list->gen_cnt++; rte_rwlock_write_unlock(&list->lock); LIST_INSERT_HEAD(&list->cache[lcore_index].h, local_entry, next); - __atomic_add_fetch(&list->count, 1, __ATOMIC_ACQUIRE); + __atomic_add_fetch(&list->count, 1, __ATOMIC_RELAXED); DRV_LOG(DEBUG, "mlx5 list %s entry %p new: %u.", list->name, (void *)entry, entry->ref_cnt); return local_entry; @@ -194,7 +194,7 @@ mlx5_list_unregister(struct mlx5_list *list, struct mlx5_list_entry *gentry = entry->gentry; int lcore_idx; - if (__atomic_sub_fetch(&entry->ref_cnt, 1, __ATOMIC_ACQUIRE) != 0) + if (__atomic_sub_fetch(&entry->ref_cnt, 1, __ATOMIC_RELAXED) != 0) return 1; lcore_idx = rte_lcore_index(rte_lcore_id()); MLX5_ASSERT(lcore_idx < RTE_MAX_LCORE); @@ -207,14 +207,14 @@ mlx5_list_unregister(struct mlx5_list *list, } else { return 0; } - if (__atomic_sub_fetch(&gentry->ref_cnt, 1, __ATOMIC_ACQUIRE) != 0) + if (__atomic_sub_fetch(&gentry->ref_cnt, 1, __ATOMIC_RELAXED) != 0) return 1; rte_rwlock_write_lock(&list->lock); if (likely(gentry->ref_cnt == 0)) { LIST_REMOVE(gentry, next); rte_rwlock_write_unlock(&list->lock); list->cb_remove(list, gentry); - __atomic_sub_fetch(&list->count, 1, __ATOMIC_ACQUIRE); + __atomic_sub_fetch(&list->count, 1, __ATOMIC_RELAXED); DRV_LOG(DEBUG, "mlx5 list %s entry %p removed.", list->name, (void *)gentry); return 0;