From patchwork Mon Jun 28 19:23:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 94926 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1AB2A0A0C; Mon, 28 Jun 2021 21:24:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 110374115F; Mon, 28 Jun 2021 21:24:20 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by mails.dpdk.org (Postfix) with ESMTP id 2E3A941155; Mon, 28 Jun 2021 21:24:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FIijlbM7scGhaZLWCeMJtvOwGXLGe291rq4PJ7/yndeK8jXelGTb/0GG41rxQZeZaSCojEJVl38mb+5oB21lP7G+J1jjoPPVclguPdwn5Ce3WoK8V2RHrbEaMNxrDpp7w7e+B+YoqNpVBo5ThBwRiwYRZUwFU6/8rVongn4Zuzc0xdun64P3c/mneBKxzdMSS9vtFHUyARCnB6uRD7SbjBQ3vqDcKUeM5nDYSELkkQFtW13i/9dLBztdhAH/CZaru9PPDh2tAFty/KJR2UcVh+vOaO5RSusptkyRj3uzwvEYjuY2cyqooR/J/0ls1/0ovSGx+tf7+nLBl5hLuYSjlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=Jm4VaTSDBFz/YnffBX/DWl95mwacmHwA0G1Duq8fauqXeDmdToHWQQ9Nd6aE8ytJAtFm2O1mx5P5INPSM0XGUFznJD7uhq/IMOmX4hzBqNFaFmtNWcab0ByEMro+sNMw1I8dyeyZ/uGrYAeS+VX4k22AehQyIliUJdNxFjhpGFXifx38JBD2/KfcMgNsNNmhdj7ipAGj9RImg4UhuLNiByLWakflltrruxLw5r3fdlQDeQ38PIwAX5/fy4QtdUXQble38jwNLJ+6d4lTcOjHaD6LirVUf+IvX4X5pNMXvMMGLwiPTAW9hYCtRzBMeX9lHzblxEQCq8H9LpyIeGLI4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=FHUVqCYNSq7QlirwAWpCo8Xfx3NPEUe+s1Ik1oOUu6j+lpCFxNI7OLYMabCZjG7wIZTfUFD3g7SlQN4leQDNbq5VBQI7pvV8rpil/zGDUmhTL6oVbekU5dwHdn+KRCiKx5JxghOSq+trAd2korR2JnsUR6/qhn4PEQuxtNLMvgKh8rnnEQDXAFPUEECe/qOy5Rg+qGvtpGfYsAhDq7V4RGUXFqmU3fmYoUaCUYcn+wMbchMu6MK33wbBkOytjXvlMqZktIwe2ToUGUYLo1nRdIGkrin6UgKtGShw3iW32U6yPJNs6SYcS2Lmbdq2j6IGO8kZp9EEEbKQPWjmJXljHA== Received: from DM6PR13CA0017.namprd13.prod.outlook.com (2603:10b6:5:bc::30) by MWHPR12MB1552.namprd12.prod.outlook.com (2603:10b6:301:a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Mon, 28 Jun 2021 19:24:16 +0000 Received: from DM6NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:5:bc:cafe::c) by DM6PR13CA0017.outlook.office365.com (2603:10b6:5:bc::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.8 via Frontend Transport; Mon, 28 Jun 2021 19:24:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT016.mail.protection.outlook.com (10.13.173.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 19:24:16 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Jun 2021 19:24:13 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Mon, 28 Jun 2021 22:23:47 +0300 Message-ID: <20210628192347.1825713-3-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210628192347.1825713-1-michaelba@nvidia.com> References: <20210628192347.1825713-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dd59f70-f9b9-4430-58c6-08d93a6a5202 X-MS-TrafficTypeDiagnostic: MWHPR12MB1552: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pH83Ob3wXcta9L18V7bmjNjw6cdue6WynnRIYmmW5tyMyrF6+4NOk0+ULO0HfM/h0slOnvQ0DXtzSJ5Aj2+rV54Nc/TXUFdrECbxqQRuZ982tXKhgwalyPtBRZ3sVHW0hxxK1tYskmi4BVMJviIackq5nkgaU2cypyoEPoje3IfJ5tISr5IGQqHWyQCChffJ6f/vW7ibcqSKnTRcRL+s0WA2I8QCiraSoFAdZBvjnBUHOzuuThCynukuuuKO1tjYVkoLV2vuWdFMC8A00RyLHu/rMXkGvcyVG7WTQjMaDFfl8PTZzNlx/1Supoiskg2d2mTI9N+SA+w9jLDVrYBUQzSvZqll8YJ8vJ8Sy4ImpmdCEisipst4w8r4QZOp8nu5q2AWNIocDF80+Hu4Cr/M1KEaujUDvHI5eCkwgP0yRgNnG4Mdx6amNHLhZlrIksPiYj+lskZ6DgBaDSPWNPeFatEE6p4v4wD1uJEfmmSAunxj+FRYA3UXn7e+A79ejBTdJ8QMKf9UWSDNr4juSpsuqcx5yoLA3dVj+sVYd9Uj7w3Y7HUK/I/WhFSVSHWDUVgrHtIUhwM3w2oygP6xK3B8W5ORejsCR2W2dznLyqMx8kmAP7M0Q8+2QFahc8qW/GjkST045O9VnRzfvahJTowEX+OOn/nHvGDwCnYuQSv70MYjje86kAHEyzY5s79g7D2yBUN47nO63nNm9maRaE0fXg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(36840700001)(46966006)(4326008)(26005)(8676002)(6916009)(70586007)(70206006)(47076005)(1076003)(4744005)(7696005)(450100002)(8936002)(6666004)(5660300002)(6286002)(55016002)(7636003)(356005)(426003)(82310400003)(478600001)(16526019)(186003)(2616005)(83380400001)(336012)(82740400003)(86362001)(36756003)(316002)(2906002)(54906003)(36906005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2021 19:24:16.5316 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dd59f70-f9b9-4430-58c6-08d93a6a5202 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1552 Subject: [dpdk-dev] [PATCH 3/3] regex/mlx5: fix redundancy in PCI remove function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: stable@dpdk.org Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index f64dc2824c..1c5bf930ad 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -290,8 +290,6 @@ mlx5_regex_pci_remove(struct rte_pci_device *pci_dev) rte_regexdev_unregister(priv->regexdev); if (priv->ctx) mlx5_glue->close_device(priv->ctx); - if (priv->regexdev) - rte_regexdev_unregister(priv->regexdev); rte_free(priv); } return 0;