diff mbox series

fix l2fwd --no-mac-updating not working issue

Message ID 20210628090834.71199-1-winsome8282@163.com (mailing list archive)
State Rejected, archived
Delegated to: David Marchand
Headers show
Series fix l2fwd --no-mac-updating not working issue | expand

Checks

Context Check Description
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

RickZhong June 28, 2021, 9:08 a.m. UTC
The original disable mac updating codes were removed by mistake.

Signed-off-by: RickZhong <winsome8282@163.com>
---
 examples/l2fwd/main.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

David Marchand June 28, 2021, 9:25 a.m. UTC | #1
On Mon, Jun 28, 2021 at 11:09 AM RickZhong <winsome8282@163.com> wrote:
>
> The original disable mac updating codes were removed by mistake.
>
> Signed-off-by: RickZhong <winsome8282@163.com>
> ---
>  examples/l2fwd/main.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c
> index 32d405e65..69d0087dc 100644
> --- a/examples/l2fwd/main.c
> +++ b/examples/l2fwd/main.c
> @@ -491,6 +491,10 @@ l2fwd_parse_args(int argc, char **argv)
>                         timer_period = timer_secs;
>                         break;
>
> +               /* no-mac-updating */
> +               case 0:
> +                       break;
> +
>                 /* long options */
>                 case CMD_LINE_OPT_PORTMAP_NUM:
>                         ret = l2fwd_parse_port_pair_config(optarg);

This issue should be fixed with these patches:
http://patchwork.dpdk.org/project/dpdk/patch/20210622024706.1179945-1-sunchenglian@loongson.cn/
http://patchwork.dpdk.org/project/dpdk/patch/20210622024944.1180109-2-sunchenglian@loongson.cn/

Can you test/review them?

Thanks.
diff mbox series

Patch

diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c
index 32d405e65..69d0087dc 100644
--- a/examples/l2fwd/main.c
+++ b/examples/l2fwd/main.c
@@ -491,6 +491,10 @@  l2fwd_parse_args(int argc, char **argv)
 			timer_period = timer_secs;
 			break;
 
+		/* no-mac-updating */
+		case 0:
+			break;
+
 		/* long options */
 		case CMD_LINE_OPT_PORTMAP_NUM:
 			ret = l2fwd_parse_port_pair_config(optarg);