diff mbox series

net/i40e: fix L2 payload RSS mask input set

Message ID 20210618083821.9876-1-alvinx.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/i40e: fix L2 payload RSS mask input set |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing fail Testing issues
ci/iol-mellanox-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Alvin Zhang June 18, 2021, 8:38 a.m. UTC 
  Allow VLAN tag being added to L2 payload packet type RSS input set.

Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/i40e/i40e_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Xing, Beilei June 21, 2021, 8:39 a.m. UTC | #1 
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Friday, June 18, 2021 4:38 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/i40e: fix L2 payload RSS mask input set
> 
> Allow VLAN tag being added to L2 payload packet type RSS input set.
> 
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_hash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c
> index b1cb24f..722edc9 100644
> --- a/drivers/net/i40e/i40e_hash.c
> +++ b/drivers/net/i40e/i40e_hash.c
> @@ -201,11 +201,11 @@ struct i40e_hash_match_pattern {  #define
> I40E_HASH_MAP_CUS_PATTERN(pattern, rss_mask, cus_pctype) { \
>  	pattern, rss_mask, true, cus_pctype }
> 
> -#define I40E_HASH_L2_RSS_MASK		(ETH_RSS_ETH |
> ETH_RSS_L2_SRC_ONLY | \
> +#define I40E_HASH_L2_RSS_MASK		(ETH_RSS_VLAN |
> ETH_RSS_ETH | \
> +					ETH_RSS_L2_SRC_ONLY | \
>  					ETH_RSS_L2_DST_ONLY)
> 
>  #define I40E_HASH_L23_RSS_MASK		(I40E_HASH_L2_RSS_MASK |
> \
> -					ETH_RSS_VLAN | \
>  					ETH_RSS_L3_SRC_ONLY | \
>  					ETH_RSS_L3_DST_ONLY)
> 
> --
> 1.8.3.1

Acked-by: Beilei Xing <beilei.xing@intel.com>
Qi Zhang June 22, 2021, 3:38 a.m. UTC | #2 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xing, Beilei
> Sent: Monday, June 21, 2021 4:39 PM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix L2 payload RSS mask input set
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, AlvinX <alvinx.zhang@intel.com>
> > Sent: Friday, June 18, 2021 4:38 PM
> > To: Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH] net/i40e: fix L2 payload RSS mask input set
> >
> > Allow VLAN tag being added to L2 payload packet type RSS input set.
> >
> > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> >  drivers/net/i40e/i40e_hash.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_hash.c
> > b/drivers/net/i40e/i40e_hash.c index b1cb24f..722edc9 100644
> > --- a/drivers/net/i40e/i40e_hash.c
> > +++ b/drivers/net/i40e/i40e_hash.c
> > @@ -201,11 +201,11 @@ struct i40e_hash_match_pattern {  #define
> > I40E_HASH_MAP_CUS_PATTERN(pattern, rss_mask, cus_pctype) { \
> >  	pattern, rss_mask, true, cus_pctype }
> >
> > -#define I40E_HASH_L2_RSS_MASK		(ETH_RSS_ETH |
> > ETH_RSS_L2_SRC_ONLY | \
> > +#define I40E_HASH_L2_RSS_MASK		(ETH_RSS_VLAN |
> > ETH_RSS_ETH | \
> > +					ETH_RSS_L2_SRC_ONLY | \
> >  					ETH_RSS_L2_DST_ONLY)
> >
> >  #define I40E_HASH_L23_RSS_MASK		(I40E_HASH_L2_RSS_MASK |
> > \
> > -					ETH_RSS_VLAN | \
> >  					ETH_RSS_L3_SRC_ONLY | \
> >  					ETH_RSS_L3_DST_ONLY)
> >
> > --
> > 1.8.3.1
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c
index b1cb24f..722edc9 100644
--- a/drivers/net/i40e/i40e_hash.c
+++ b/drivers/net/i40e/i40e_hash.c
@@ -201,11 +201,11 @@  struct i40e_hash_match_pattern {
 #define I40E_HASH_MAP_CUS_PATTERN(pattern, rss_mask, cus_pctype) { \
 	pattern, rss_mask, true, cus_pctype }
 
-#define I40E_HASH_L2_RSS_MASK		(ETH_RSS_ETH | ETH_RSS_L2_SRC_ONLY | \
+#define I40E_HASH_L2_RSS_MASK		(ETH_RSS_VLAN | ETH_RSS_ETH | \
+					ETH_RSS_L2_SRC_ONLY | \
 					ETH_RSS_L2_DST_ONLY)
 
 #define I40E_HASH_L23_RSS_MASK		(I40E_HASH_L2_RSS_MASK | \
-					ETH_RSS_VLAN | \
 					ETH_RSS_L3_SRC_ONLY | \
 					ETH_RSS_L3_DST_ONLY)