diff mbox series

[v2] eal/arm: remove irrelevant code

Message ID 20210611144219.322428-1-ruifeng.wang@arm.com (mailing list archive)
State Accepted
Delegated to: David Marchand
Headers show
Series [v2] eal/arm: remove irrelevant code | expand

Checks

Context Check Description
ci/iol-testing fail Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Ruifeng Wang June 11, 2021, 2:42 p.m. UTC
Data types Elf32_auxv_t and Elf64_auxv_t are used by OS Linux
auxiliary vector read, and not used by arch specific cpu flag
API implementations. Hence remove them from Arm file.

Reported-by: James Grant <j.grant@qub.ac.uk>
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
v2:
Update commit message to remove implication of FreeBSD support.

 lib/eal/arm/rte_cpuflags.c | 2 --
 1 file changed, 2 deletions(-)

Comments

David Marchand July 5, 2021, 7:54 a.m. UTC | #1
On Fri, Jun 11, 2021 at 4:42 PM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
>
> Data types Elf32_auxv_t and Elf64_auxv_t are used by OS Linux
> auxiliary vector read, and not used by arch specific cpu flag
> API implementations. Hence remove them from Arm file.
>
> Reported-by: James Grant <j.grant@qub.ac.uk>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> v2:
> Update commit message to remove implication of FreeBSD support.

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/eal/arm/rte_cpuflags.c b/lib/eal/arm/rte_cpuflags.c
index 845770f1e5..d84c9fc09f 100644
--- a/lib/eal/arm/rte_cpuflags.c
+++ b/lib/eal/arm/rte_cpuflags.c
@@ -48,7 +48,6 @@  struct feature_entry {
 
 #ifdef RTE_ARCH_ARMv7
 #define PLATFORM_STR "v7l"
-typedef Elf32_auxv_t _Elfx_auxv_t;
 
 const struct feature_entry rte_cpu_feature_table[] = {
 	FEAT_DEF(SWP,       REG_HWCAP,    0)
@@ -83,7 +82,6 @@  const struct feature_entry rte_cpu_feature_table[] = {
 
 #elif defined RTE_ARCH_ARM64
 #define PLATFORM_STR "aarch64"
-typedef Elf64_auxv_t _Elfx_auxv_t;
 
 const struct feature_entry rte_cpu_feature_table[] = {
 	FEAT_DEF(FP,		REG_HWCAP,    0)