From patchwork Fri Jun 11 06:54:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Yang X-Patchwork-Id: 94083 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DB73A0C40; Fri, 11 Jun 2021 08:56:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B916F4067C; Fri, 11 Jun 2021 08:56:53 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 1F48A4014F for ; Fri, 11 Jun 2021 08:56:51 +0200 (CEST) IronPort-SDR: X3mnpKFdoD+yzBKncj5FwpZQDT8F0JzuKix9FPzj9wuT+aKNpYZmOsKDpTLttY8618zKolgxQA Sb/5M+ZCXxRg== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="205503516" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="205503516" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 23:56:37 -0700 IronPort-SDR: QZxLfLPgbFdUK2tL6h83ARQSoxjYKDLmFPHOT442KM843plmJ7AH9WxDlGOvJbvdTS2ym8jf6W K8BjqekVu6qw== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="483158979" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.194]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 23:56:35 -0700 From: Steve Yang To: dev@dpdk.org Cc: beilei.xing@intel.com, Steve Yang Date: Fri, 11 Jun 2021 06:54:57 +0000 Message-Id: <20210611065457.988344-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210611013511.977843-1-stevex.yang@intel.com> References: <20210611013511.977843-1-stevex.yang@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] net/i40e: fix set rss hash function invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" i40e can support following rss hash function types: default/toeplitz, symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default. Add simple_xor and toeplitz hash functions support when parsing pattern action. Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Signed-off-by: Steve Yang --- v2: - add the fix line. - support simple_xor and toeplitz hash functions explicitly. drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index b1cb24f437..0cef21c88f 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, NULL, "RSS Queues not supported when pattern specified"); - if (rss_act->func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) + switch (rss_act->func) { + case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ: rss_conf->symmetric_enable = true; - else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT) - return rte_flow_error_set(error, -EINVAL, - RTE_FLOW_ERROR_TYPE_ACTION_CONF, - NULL, - "Only symmetric TOEPLITZ supported when pattern specified"); + break; + case RTE_ETH_HASH_FUNCTION_DEFAULT: + case RTE_ETH_HASH_FUNCTION_TOEPLITZ: + case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR: + break; + default: + return rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION_CONF, + NULL, + "RSS hash function not supported " + "when pattern specified"); + } if (!i40e_hash_validate_rss_types(rss_act->types)) return rte_flow_error_set(error, EINVAL,