diff mbox series

[v2] config/arm: add Qualcomm Centriq 2400 part number

Message ID 20210525082402.8051-1-thierry.herbelot@6wind.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] config/arm: add Qualcomm Centriq 2400 part number |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-abi-testing warning Testing issues
ci/iol-testing fail Testing issues
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Thierry Herbelot May 25, 2021, 8:24 a.m. UTC 
  0xc00 is for "SoC 2.0" Qualcom Centriq servers.
0x800 is for "SoC 1.1".

Cc: Jerin Jacob <jerinj@marvell.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V2: add maintainers as Cc
---
 config/arm/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon June 17, 2021, 7:06 a.m. UTC | #1 
25/05/2021 10:24, Thierry Herbelot:
> 0xc00 is for "SoC 2.0" Qualcom Centriq servers.
> 0x800 is for "SoC 1.1".
> 
> Cc: Jerin Jacob <jerinj@marvell.com>
> Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2: add maintainers as Cc
> ---
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -226,6 +226,7 @@ soc_bluefield = {
>  soc_centriq2400 = {
>      'description': 'Qualcomm Centriq 2400',
>      'implementer': '0x51',
> +    'part_number': '0x800',
>      'part_number': '0xc00',
>      'numa': false
>  }

Any comment or ack?
David Marchand June 17, 2021, 7:21 a.m. UTC | #2 
On Thu, Jun 17, 2021 at 9:07 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 25/05/2021 10:24, Thierry Herbelot:
> > 0xc00 is for "SoC 2.0" Qualcom Centriq servers.

Qualcomm*

> > 0x800 is for "SoC 1.1".
> >
> > Cc: Jerin Jacob <jerinj@marvell.com>
> > Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > --
> > V2: add maintainers as Cc
> > ---
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -226,6 +226,7 @@ soc_bluefield = {
> >  soc_centriq2400 = {
> >      'description': 'Qualcomm Centriq 2400',
> >      'implementer': '0x51',
> > +    'part_number': '0x800',
> >      'part_number': '0xc00',
> >      'numa': false
> >  }
>
> Any comment or ack?

$ meson setup build-centriq --cross-file config/arm/arm64_centriq2400_linux_gcc
...
Compiler for C supports arguments -Wno-missing-field-initializers
-Wmissing-field-initializers: YES

config/arm/meson.build:226:0: ERROR: Duplicate dictionary key: part_number
Ruifeng Wang June 17, 2021, 7:24 a.m. UTC | #3 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, June 17, 2021 3:07 PM
> To: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: dev@dpdk.org; Thierry Herbelot <thierry.herbelot@6wind.com>; Juraj
> Linkeš <juraj.linkes@pantheon.tech>
> Subject: Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400
> part number
> 
> 25/05/2021 10:24, Thierry Herbelot:
> > 0xc00 is for "SoC 2.0" Qualcom Centriq servers.
> > 0x800 is for "SoC 1.1".
> >
> > Cc: Jerin Jacob <jerinj@marvell.com>
> > Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > --
> > V2: add maintainers as Cc
> > ---
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -226,6 +226,7 @@ soc_bluefield = {
> >  soc_centriq2400 = {
> >      'description': 'Qualcomm Centriq 2400',
> >      'implementer': '0x51',
> > +    'part_number': '0x800',
> >      'part_number': '0xc00',
> >      'numa': false
> >  }
> 
> Any comment or ack?
>
Ruifeng Wang June 17, 2021, 7:28 a.m. UTC | #4 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, June 17, 2021 3:07 PM
> To: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: dev@dpdk.org; Thierry Herbelot <thierry.herbelot@6wind.com>; Juraj
> Linkeš <juraj.linkes@pantheon.tech>
> Subject: Re: [dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400
> part number
> 
> 25/05/2021 10:24, Thierry Herbelot:
> > 0xc00 is for "SoC 2.0" Qualcom Centriq servers.
> > 0x800 is for "SoC 1.1".
> >
> > Cc: Jerin Jacob <jerinj@marvell.com>
> > Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > --
> > V2: add maintainers as Cc
> > ---
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -226,6 +226,7 @@ soc_bluefield = {
> >  soc_centriq2400 = {
> >      'description': 'Qualcomm Centriq 2400',
> >      'implementer': '0x51',
> > +    'part_number': '0x800',
To add support for a new part number, I think it should be added to implementer_qualcomm.
If cross compile for the new soc is needed, it needs a new soc_xx block. I'm wondering this is a real request? I assume SoC 1.0 will have no config difference from SoC 2.0.

Thanks.
> >      'part_number': '0xc00',
> >      'numa': false
> >  }
> 
> Any comment or ack?
>
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index e83a56e0d589..971a050efd93 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -226,6 +226,7 @@  soc_bluefield = {
 soc_centriq2400 = {
     'description': 'Qualcomm Centriq 2400',
     'implementer': '0x51',
+    'part_number': '0x800',
     'part_number': '0xc00',
     'numa': false
 }