diff mbox series

test/crypto: fix test status when PMD isn't loaded

Message ID 20210518141955.960508-1-ciara.power@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series test/crypto: fix test status when PMD isn't loaded |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/github-robot success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Power, Ciara May 18, 2021, 2:19 p.m. UTC 
  The return value for a test when the required PMD is not loaded should
be TEST_SKIPPED, rather than TEST_FAILED.

Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites")

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 app/test/test_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fan Zhang May 18, 2021, 2:37 p.m. UTC | #1 
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Tuesday, May 18, 2021 3:20 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; aconole@redhat.com; gakhil@marvell.com;
> Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH] test/crypto: fix test status when PMD isn't loaded
> 
> The return value for a test when the required PMD is not loaded should
> be TEST_SKIPPED, rather than TEST_FAILED.
> 
> Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites")
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> 2.25.1

Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Thomas Monjalon May 19, 2021, 8:32 a.m. UTC | #2 
> > The return value for a test when the required PMD is not loaded should
> > be TEST_SKIPPED, rather than TEST_FAILED.
> > 
> > Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites")
> > 
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> 
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 736952a9e6..c68684b80b 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -14504,7 +14504,7 @@  run_cryptodev_testsuite(const char *pmd_name)
 
 	if (gbl_driver_id == -1) {
 		RTE_LOG(ERR, USER1, "%s PMD must be loaded.\n", pmd_name);
-		return TEST_FAILED;
+		return TEST_SKIPPED;
 	}
 
 	ts.unit_test_suites = malloc(sizeof(struct unit_test_suite *) *