diff mbox series

net/nfp: remove compile time log

Message ID 20210518104115.1427712-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series net/nfp: remove compile time log | expand

Checks

Context Check Description
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/github-robot success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Ferruh Yigit May 18, 2021, 10:41 a.m. UTC
Logging should be converted to dynamic log.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/nfp/nfp_net_logs.h | 7 -------
 1 file changed, 7 deletions(-)

Comments

Andrew Rybchenko June 28, 2021, 11:13 a.m. UTC | #1
Hi Heinrich,

could you take a look at the patch?

Thanks,
Andrew.

On 5/18/21 1:41 PM, Ferruh Yigit wrote:
> Logging should be converted to dynamic log.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
> index 27dd87611b94..76cc94cb6565 100644
> --- a/drivers/net/nfp/nfp_net_logs.h
> +++ b/drivers/net/nfp/nfp_net_logs.h
> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>   #define ASSERT(x) do { } while (0)
>   #endif
>   
> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -
> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
> -#define PMD_CPP_LOG(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> -#else
>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
> -#endif
>   
>   extern int nfp_logtype_driver;
>   #define PMD_DRV_LOG(level, fmt, args...) \
>
Thomas Monjalon July 23, 2021, 2:14 p.m. UTC | #2
Please review.

28/06/2021 13:13, Andrew Rybchenko:
> Hi Heinrich,
> 
> could you take a look at the patch?
> 
> Thanks,
> Andrew.
> 
> On 5/18/21 1:41 PM, Ferruh Yigit wrote:
> > Logging should be converted to dynamic log.
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> >   drivers/net/nfp/nfp_net_logs.h | 7 -------
> >   1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
> > index 27dd87611b94..76cc94cb6565 100644
> > --- a/drivers/net/nfp/nfp_net_logs.h
> > +++ b/drivers/net/nfp/nfp_net_logs.h
> > @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
> >   #define ASSERT(x) do { } while (0)
> >   #endif
> >   
> > -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
> > -
> > -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
> > -#define PMD_CPP_LOG(level, fmt, args...) \
> > -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> > -#else
> >   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
> > -#endif
> >   
> >   extern int nfp_logtype_driver;
> >   #define PMD_DRV_LOG(level, fmt, args...) \
Heinrich Kuhn July 29, 2021, 12:18 p.m. UTC | #3
On 2021/07/23 16:14, Thomas Monjalon wrote:
> Please review.
> 
> 28/06/2021 13:13, Andrew Rybchenko:
>> Hi Heinrich,
>>
>> could you take a look at the patch?
>>
>> Thanks,
>> Andrew.
>>
>> On 5/18/21 1:41 PM, Ferruh Yigit wrote:
>>> Logging should be converted to dynamic log.
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>>>   1 file changed, 7 deletions(-)
>>>
>>> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
>>> index 27dd87611b94..76cc94cb6565 100644
>>> --- a/drivers/net/nfp/nfp_net_logs.h
>>> +++ b/drivers/net/nfp/nfp_net_logs.h
>>> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>>>   #define ASSERT(x) do { } while (0)
>>>   #endif
>>>   
>>> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>> -
>>> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>> -#define PMD_CPP_LOG(level, fmt, args...) \
>>> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
>>> -#else
>>>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
>>> -#endif
>>>   
>>>   extern int nfp_logtype_driver;
>>>   #define PMD_DRV_LOG(level, fmt, args...) \
> 
> 
> 
Hi Andrew,

Apologies for the delay, looks good thanks

Reviewed-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
Ferruh Yigit Aug. 16, 2021, 2:04 p.m. UTC | #4
On 7/29/2021 1:18 PM, Heinrich Kuhn wrote:
> 
> 
> On 2021/07/23 16:14, Thomas Monjalon wrote:
>> Please review.
>>
>> 28/06/2021 13:13, Andrew Rybchenko:
>>> Hi Heinrich,
>>>
>>> could you take a look at the patch?
>>>
>>> Thanks,
>>> Andrew.
>>>
>>> On 5/18/21 1:41 PM, Ferruh Yigit wrote:
>>>> Logging should be converted to dynamic log.
>>>>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> ---
>>>>   drivers/net/nfp/nfp_net_logs.h | 7 -------
>>>>   1 file changed, 7 deletions(-)
>>>>
>>>> diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
>>>> index 27dd87611b94..76cc94cb6565 100644
>>>> --- a/drivers/net/nfp/nfp_net_logs.h
>>>> +++ b/drivers/net/nfp/nfp_net_logs.h
>>>> @@ -30,14 +30,7 @@ extern int nfp_logtype_init;
>>>>   #define ASSERT(x) do { } while (0)
>>>>   #endif
>>>>   
>>>> -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>>> -
>>>> -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
>>>> -#define PMD_CPP_LOG(level, fmt, args...) \
>>>> -	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
>>>> -#else
>>>>   #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
>>>> -#endif
>>>>   
>>>>   extern int nfp_logtype_driver;
>>>>   #define PMD_DRV_LOG(level, fmt, args...) \
>>
>>
>>
> Hi Andrew,
> 
> Apologies for the delay, looks good thanks
> 
> Reviewed-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> 

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h
index 27dd87611b94..76cc94cb6565 100644
--- a/drivers/net/nfp/nfp_net_logs.h
+++ b/drivers/net/nfp/nfp_net_logs.h
@@ -30,14 +30,7 @@  extern int nfp_logtype_init;
 #define ASSERT(x) do { } while (0)
 #endif
 
-#define RTE_LIBRTE_NFP_NET_DEBUG_CPP
-
-#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP
-#define PMD_CPP_LOG(level, fmt, args...) \
-	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
-#else
 #define PMD_CPP_LOG(level, fmt, args...) do { } while (0)
-#endif
 
 extern int nfp_logtype_driver;
 #define PMD_DRV_LOG(level, fmt, args...) \