From patchwork Mon May 10 06:11:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Feifei Wang X-Patchwork-Id: 93082 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BAD9A0548; Mon, 10 May 2021 08:12:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F039E40140; Mon, 10 May 2021 08:12:03 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 228634003E for ; Mon, 10 May 2021 08:12:02 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0812B1FB; Sun, 9 May 2021 23:12:02 -0700 (PDT) Received: from net-x86-dell-8268.shanghai.arm.com (net-x86-dell-8268.shanghai.arm.com [10.169.210.127]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DA6723F73B; Sun, 9 May 2021 23:11:59 -0700 (PDT) From: Feifei Wang To: Jerin Jacob Cc: dev@dpdk.org, nd@arm.com, Feifei Wang , Ruifeng Wang , Honnappa Nagarahalli Date: Mon, 10 May 2021 14:11:48 +0800 Message-Id: <20210510061148.1674641-1-feifei.wang2@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] app/eventdev: remove unnecessary barrier for order test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For "order_launch_lcores" function, wmb after that the main lcore updates the variable "t->err", which represents the end of the test signal, is unnecessary. Because after the main lcore updates this siginal variable, it will jump out of the launch function loop, and wait other lcores stop or return error in the main function(evt_main.c). During this time, there is no storing operation and thus no need for wmb. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob --- app/test-eventdev/test_order_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c index 04456d56db..d7760061ba 100644 --- a/app/test-eventdev/test_order_common.c +++ b/app/test-eventdev/test_order_common.c @@ -308,7 +308,6 @@ order_launch_lcores(struct evt_test *test, struct evt_options *opt, rte_event_dev_dump(opt->dev_id, stdout); evt_err("No schedules for seconds, deadlock"); t->err = true; - rte_smp_wmb(); break; } old_remaining = remaining;