From patchwork Thu May 6 14:25:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 93018 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38253A0524; Thu, 6 May 2021 16:27:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CC834116B; Thu, 6 May 2021 16:26:03 +0200 (CEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id 556EC41156 for ; Thu, 6 May 2021 16:26:00 +0200 (CEST) Received: by mail-lf1-f54.google.com with SMTP id z9so8033177lfu.8 for ; Thu, 06 May 2021 07:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ya29Y1oo4CSGqqdor+vF9iZ5PkFZCJ8mO7cQJ+GXFEQ=; b=YcJufDIxem4MeDmnoCMVvoYtbgBMm0F89iE48Rv9OtHSmXArvkdMGjkMnklT13lVK6 3xZM8yfDdsnERlzKNPtnrv+HFIcUV0/FjfL/dkkvwORmroizI0QSUe5jhDR1pWhfe4kR i+J2nnrdZ5I5g0OE1yZpvIVmiS7dO61XWd/gxFo3tJez5QPwA9ysSpFfbau3QQk3tIi0 bI89WMu6TGFzw5Ogl2eCxb3UO401hid7ERsapq+W8Or0P6PwpjEDLLKc61nxiG/+hu2H EgTJOdR60kr0G/AbDL0iee3MUzuBoQ1R0Hyrw7sTYEN9wqAJbRL5Fj4gKwi6K8Xfd6n2 a8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ya29Y1oo4CSGqqdor+vF9iZ5PkFZCJ8mO7cQJ+GXFEQ=; b=JGns7fJAhbZ4GaxfaAG42o95rmHbN+VnnKa/yDS4at7L5yyhZcWfOwW8GPYQPqRIqt KJW76VPgq1L/KOPMkA3Xc5x7pi7Zvp00Y7tgqaVzxmMpBeVeITyTuN7TdJlQx+bsxSZb WymmCYf6dKhE/JDRLkppmOADqkn2om+QZOGV5GCOMzMXjokz5fDJjjLbwjChR49P1yHP N9GT7tlzPk0W6joiTOaxDNfCCthigRpUEL7GZ7OW5h0BcFKwu6lVgAGHF56bkTjjp1qv D8urSY/72pNhrd3fgyJyTONTn7svKnQJtAyfFkwxL3uuXGmbb6jXkxb97Hw+waT3Ehbl SsDg== X-Gm-Message-State: AOAM531EfpXgPPQhY3NRvl0EmvoshDAzFybAPRBS8GWZ+zUvyq9YaL31 zD2PJD3UZTvYD0CHvQA3IV893Krs4BQWGEjd X-Google-Smtp-Source: ABdhPJz802lsQkkigQp6mHsBzWfX0wNW684EBTtFt+V7tWDh7VKETG3l5TPmhHx+vVTE99nFJzd8ZA== X-Received: by 2002:a05:6512:12d2:: with SMTP id p18mr3133588lfg.239.1620311159653; Thu, 06 May 2021 07:25:59 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id b40sm892908ljr.101.2021.05.06.07.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 07:25:58 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, Michal Krawczyk , stable@dpdk.org, Shay Agroskin Date: Thu, 6 May 2021 16:25:17 +0200 Message-Id: <20210506142526.28245-14-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210506142526.28245-1-mk@semihalf.com> References: <20210505073348.6394-1-mk@semihalf.com> <20210506142526.28245-1-mk@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 13/22] net/ena: terminate devargs allowed keys with NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As the documentation of rte_kvargs_parse() states, the valid_keys argument must be NULL terminated. Lack of this feature may cause segmentation fault if the passed devarg will be different then the supported value. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shay Agroskin Acked-by: Ferruh Yigit make sen --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index cb8ad5c3d0..6092288239 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter *adapter, { static const char * const allowed_args[] = { ENA_DEVARG_LARGE_LLQ_HDR, + NULL, }; struct rte_kvargs *kvlist; int rc;