From patchwork Thu May 6 14:25:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 93017 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC63BA0524; Thu, 6 May 2021 16:27:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFA304115B; Thu, 6 May 2021 16:26:01 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 0B05641152 for ; Thu, 6 May 2021 16:25:59 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id t11so8023355lfl.11 for ; Thu, 06 May 2021 07:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GGtM5qsb7+GqyqX/GA3YsmYDNifrLD8/+HhQUhZLHtY=; b=CiZckHYFp4YZr07sPHSS/VKwHIY2XD0TyfrXQZNEfvOfdGSn62sObV1P28XU19km8h EClGaEisdZDIvSzcYF2CqAxx0pPdwm+8jcIGgoJnmoNqwG0V6+PlNI/BVXGlChVU1uTC pNd6sIDe1VVVcXpMFpRNBrbdD2psqaPrNcpLZysb+QtVVaV6DrbeYboT24d6WLqAKAEC RQBoIpeq+EBMvdQ578909xWrSgD96fi65V+9k4ZG6Vx/thpdS7C3JaWEpzIdJcc0bs63 wNMGmErYhFjjugOGc0CJQyWvou77TxM9aaB1Ehy4AGU9cLwjpHG45fNL8LaDozyEy3j6 eL8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GGtM5qsb7+GqyqX/GA3YsmYDNifrLD8/+HhQUhZLHtY=; b=c/TIczmbCqFguzNlJvOFEk65MA14rDAbhuzM05nUuGJsdyjwvGgZlpKfqtxUfZzuWu xSukBBc9NtblS/PVhHaoWowATJ+R3W3/2W3M7oSjRmVg+ZuRSEGnd3WyL2hlAXBtvB1I WSt9NZcjAZSdcxU2vgjX6KfjzJm7wiUTvZBS5nmS2gH0UTsd317EsgMakoQycrJcegvK kG2VQx+EevNbs67rHH7xRqguTrtJCMpoKZZSRp5SN+2CeVg696TbHaAf9WyH9TzNouza dsL5FvoJFkOpbTXDvWz70jbBJx4D4p5OM4jzU9I4IXvZRsXUKmO7f5v6pKDIsI+DVAOt HE6A== X-Gm-Message-State: AOAM530w0T4slWkBGx9zchf2IEv1zS9QhrxuXBb0DiEuaX5EugixvIuw fbB27VD6C1SZMfKnEB5GdfoqroYPc9bGHAFx X-Google-Smtp-Source: ABdhPJzWz98LN2XT038WU1A90Qocq8vGLZSPWiuMrUNO8YSw4CJY0ip1ncEcjhVGacHmmvugp8DVCg== X-Received: by 2002:a05:6512:929:: with SMTP id f9mr3101781lft.153.1620311158360; Thu, 06 May 2021 07:25:58 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl. [89.79.189.199]) by smtp.gmail.com with ESMTPSA id b40sm892908ljr.101.2021.05.06.07.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 07:25:57 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, stable@dpdk.org, Shay Agroskin , Michal Krawczyk Date: Thu, 6 May 2021 16:25:16 +0200 Message-Id: <20210506142526.28245-13-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210506142526.28245-1-mk@semihalf.com> References: <20210505073348.6394-1-mk@semihalf.com> <20210506142526.28245-1-mk@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 12/22] net/ena: fix parsing of large_llq_hdr argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Igor Chauskin The code incorrectly checked the return value of comparison when parsing the argument key name. The return value of strcmp should be compared to 0 to identify a match. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Cc: stable@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Shay Agroskin Reviewed-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3c9102cd19..cb8ad5c3d0 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2865,7 +2865,7 @@ static int ena_process_bool_devarg(const char *key, } /* Now, assign it to the proper adapter field. */ - if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR)) + if (strcmp(key, ENA_DEVARG_LARGE_LLQ_HDR) == 0) adapter->use_large_llq_hdr = bool_value; return 0;