diff mbox series

lib: restore developer mode checks

Message ID 20210505142105.12914-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series lib: restore developer mode checks |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/github-robot success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

David Marchand May 5, 2021, 2:21 p.m. UTC 
  Most of the checks on developer_mode have been accidentally dropped.
Restore them.

Fixes: 7d611e35b077 ("lib: simplify main build file")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bruce Richardson May 5, 2021, 3:34 p.m. UTC | #1 
On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> Most of the checks on developer_mode have been accidentally dropped.
> Restore them.
> 
> Fixes: 7d611e35b077 ("lib: simplify main build file")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Thanks.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon May 5, 2021, 8:07 p.m. UTC | #2 
05/05/2021 17:34, Bruce Richardson:
> On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> > Most of the checks on developer_mode have been accidentally dropped.
> > Restore them.
> > 
> > Fixes: 7d611e35b077 ("lib: simplify main build file")
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> 
> Thanks.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/lib/meson.build b/lib/meson.build
index 64a59abab6..77f363a516 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -170,7 +170,7 @@  foreach l:libraries
     libname = 'rte_' + name
     includes += include_directories(l)
 
-    if is_windows and use_function_versioning
+    if developer_mode and is_windows and use_function_versioning
         message('@0@: Function versioning is not supported by Windows.'.format(name))
     endif
 
@@ -227,7 +227,7 @@  foreach l:libraries
     endif
 
     lk_deps = [version_map, def_file, mingw_map]
-    if not is_windows
+    if developer_mode and not is_windows
         # on unix systems check the output of the
         # check-symbols.sh script, using it as a
         # dependency of the .so build