diff mbox series

[v7,17/17] doc: update mlx5 support for conntrack

Message ID 20210505122328.51129-18-bingz@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers show
Series conntrack support in mlx5 PMD | expand

Checks

Context Check Description
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation warning apply issues
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/checkpatch success coding style OK

Commit Message

Bing Zhao May 5, 2021, 12:23 p.m. UTC
In the release notes and mlx5 NIC document, the support and
limitation of connection tracking are added.

Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 doc/guides/nics/features/default.ini   |  1 +
 doc/guides/nics/features/mlx5.ini      |  1 +
 doc/guides/nics/mlx5.rst               | 14 ++++++++++++++
 doc/guides/rel_notes/release_21_05.rst |  2 ++
 4 files changed, 18 insertions(+)

Comments

Ferruh Yigit May 5, 2021, 6:21 p.m. UTC | #1
On 5/5/2021 1:23 PM, Bing Zhao wrote:
> In the release notes and mlx5 NIC document, the support and
> limitation of connection tracking are added.
> 

A new NIC feature seems added, better to be acked beyond the mlx5 scope.

> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  doc/guides/nics/features/default.ini   |  1 +
>  doc/guides/nics/features/mlx5.ini      |  1 +
>  doc/guides/nics/mlx5.rst               | 14 ++++++++++++++
>  doc/guides/rel_notes/release_21_05.rst |  2 ++
>  4 files changed, 18 insertions(+)
> 
> diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
> index 8046bd121e..0deb4ef547 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -66,6 +66,7 @@ Module EEPROM dump   =
>  Registers dump       =
>  LED                  =
>  Multiprocess aware   =
> +Connection tracking  =
>  FreeBSD              =
>  Linux                =
>  Windows              =

Need to update 'doc/guides/nics/features.rst' too, to describe new feature.

I will drop new feature part in next-net, it can be sent as separate patch
later. Will keep driver and release notes documentation.
Bing Zhao May 18, 2021, 1:05 p.m. UTC | #2
Hi Ferruh & Thomas,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, May 6, 2021 2:21 AM
> To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; NBU-
> Contact-Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH v7 17/17] doc: update mlx5 support
> for conntrack
> 
> External email: Use caution opening links or attachments
> 
> 
> On 5/5/2021 1:23 PM, Bing Zhao wrote:
> > In the release notes and mlx5 NIC document, the support and
> limitation
> > of connection tracking are added.
> >
> 
> A new NIC feature seems added, better to be acked beyond the mlx5
> scope.
> 
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > ---
> >  doc/guides/nics/features/default.ini   |  1 +
> >  doc/guides/nics/features/mlx5.ini      |  1 +
> >  doc/guides/nics/mlx5.rst               | 14 ++++++++++++++
> >  doc/guides/rel_notes/release_21_05.rst |  2 ++
> >  4 files changed, 18 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/default.ini
> > b/doc/guides/nics/features/default.ini
> > index 8046bd121e..0deb4ef547 100644
> > --- a/doc/guides/nics/features/default.ini
> > +++ b/doc/guides/nics/features/default.ini
> > @@ -66,6 +66,7 @@ Module EEPROM dump   =
> >  Registers dump       =
> >  LED                  =
> >  Multiprocess aware   =
> > +Connection tracking  =
> >  FreeBSD              =
> >  Linux                =
> >  Windows              =
> 
> Need to update 'doc/guides/nics/features.rst' too, to describe new
> feature.
> 
> I will drop new feature part in next-net, it can be sent as separate
> patch later. Will keep driver and release notes documentation.

http://patches.dpdk.org/project/dpdk/patch/20210518125235.90185-1-bingz@nvidia.com/

A new patch with the updated description is in the link below.
I checked the file of the "features.rst" again, it seems that only the API for ethdev are
described.
Even if conntrack is a new feature and provided by new HW, but the only way to operate on it
is to use rte_flow API now.

So I am not quite sure if it is possible and proper to list the feature in the driver feature
lists table. What do you think?

BR. Bing
diff mbox series

Patch

diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 8046bd121e..0deb4ef547 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -66,6 +66,7 @@  Module EEPROM dump   =
 Registers dump       =
 LED                  =
 Multiprocess aware   =
+Connection tracking  =
 FreeBSD              =
 Linux                =
 Windows              =
diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini
index ddd131da16..45dbe75d07 100644
--- a/doc/guides/nics/features/mlx5.ini
+++ b/doc/guides/nics/features/mlx5.ini
@@ -45,6 +45,7 @@  Stats per queue      = Y
 FW version           = Y
 Module EEPROM dump   = Y
 Multiprocess aware   = Y
+Connection tracking  = Y
 Linux                = Y
 Windows              = P
 ARMv8                = Y
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index e7aeb779fd..5aa1100a83 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -108,6 +108,7 @@  Features
   flow group.
 - Flow metering, including meter policy API.
 - Flow integrity offload API.
+- Connection tracking.
 
 Limitations
 -----------
@@ -433,6 +434,14 @@  Limitations
       or
       flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec 0 / eth / ipv4 proto is udp / end …
 
+- Connection tracking:
+
+  - connection tracking (conntrack) couldn't co-exist with ASO meter, ASO age action in a single flow rule.
+  - Flow rules insertion rate and memory consumption.
+  - software limitation:
+     - ports: a maximal number of 256.
+     - conntrack: a maximal number of 4M.
+
 Statistics
 ----------
 
@@ -1695,6 +1704,11 @@  Supported hardware offloads
    |                       | | rdma-core 35  | | rdma-core 35  |
    |                       | | ConnectX-5    | | ConnectX-5    |
    +-----------------------+-----------------+-----------------+
+   | Connection tracking   | |               | | DPDK 21.05    |
+   |                       | |     N/A       | | OFED 5.3      |
+   |                       | |               | | rdma-core 35  |
+   |                       | |               | | ConnectX-6 Dx |
+   +-----------------------+-----------------+-----------------+
 
 .. table:: Minimal SW/HW versions for shared action offload
    :name: sact
diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst
index 4938c931ff..1b4b13f76c 100644
--- a/doc/guides/rel_notes/release_21_05.rst
+++ b/doc/guides/rel_notes/release_21_05.rst
@@ -167,6 +167,8 @@  New Features
   * Added support for ASO (Advanced Steering Operation) meter.
   * Added support for ASO metering by PPS (packet per second).
   * Added support for the monitor policy of Power Management API.
+  * Added support for connection tracking action and item as well as context create,
+    destroy, update and query.
 
 * **Updated NXP DPAA driver.**