From patchwork Wed May 5 06:41:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bing Zhao X-Patchwork-Id: 92812 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC306A0524; Wed, 5 May 2021 08:43:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EFC1410FC; Wed, 5 May 2021 08:43:06 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2087.outbound.protection.outlook.com [40.107.220.87]) by mails.dpdk.org (Postfix) with ESMTP id 9F92B410F6 for ; Wed, 5 May 2021 08:43:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MAMScD9ekqA+Fy5RIJzw8J25Nc3oVqvLH7dgdpegQj/28xMni4NMDYJVN9PhsQpbyBY0VDpns8rk3IIr/Lhpf0NApPtaapt4TWICimEzDRXmbNUKNRTrT612RuvycWx9QhfNj2PRfn7FIMnSU8eP510LCDFhJGxMAL22c5ObDnbtWK/6UITyKhfn/uZw9ZPV33zAzyAzqavf2TTzyeUSVWao0A4oTJmKSEaVr6LsLwULko5OTYwnDwdQaMC13uy5ecvVQyDQHO2yqEBkgrRFdeuymjU1OisyiP6kHtwfDMIlUmWBoonMJlQZmsJUuXTUaY455cY76mAC4pL2jr/q6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MiapB1OOlt9lbk0GR9JIMTYCCTRFED+eNwQtPrDHfiQ=; b=Vs6mr+Fgoh+cLxoH+uEXgNeb3P85l4uqnKpkU6EqwPcVXVJIP7dmbMXqMQlbuPVcikBbe3Irv7DBqR4cRShkqirBiACfWpPIbgo+Bv8zyQlZCNT2x8L29aqaOBLWyFrmge6Wx4d8D7CToA8/f0SDhGFBvoKa1huISV+fs7N6ce2BPZjAqkn5btNPQZpytfOPXtn4Tn9az4vNyNtkpHGbIndW/7LkpoMXEqT0mbQ088LIL+hFgzg2pGLKCvEiGhkptt0X3wXgAVjB0m6ipVGzMe/yq9f1KsylZviS8/gEfwHRhuzuvBYjdZQSgWCakaVMOAK2V/HA9KYjizeB6enjqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MiapB1OOlt9lbk0GR9JIMTYCCTRFED+eNwQtPrDHfiQ=; b=tUpElZJXMrUogiGJ1DOhYrqVZ3dp2LuPpZAOTLYrxCTyF5fXcswapSawtazOx9SwntW/8XoUv4P7E2Vq885hnE2Ruw0qi80StNNZ6I3REFRXZgHwSj82DImQvxpBDAJM0beL+Cf1WC+ujvfLwdyVgB65oV5huN0gtDr7y1Pwgs9BuCGCPHYVaSmnltHP9PVjLRNMGTBCtVZcpLZvO9B7QjMwO5DGSVqaMP3qSEQPEbaHKmOv11cTSMecx5xLBKfxHIhLbR74r8Lw0OsAusVqs3mKbC9TfF1tnjPVKD3kniIbB+61UVSp0FtW1rOjxHT5vkIBz0R7RqtUfKwb1Qrnbw== Received: from BN9PR03CA0497.namprd03.prod.outlook.com (2603:10b6:408:130::22) by BN8PR12MB3251.namprd12.prod.outlook.com (2603:10b6:408:9b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Wed, 5 May 2021 06:43:02 +0000 Received: from BN8NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:408:130:cafe::b0) by BN9PR03CA0497.outlook.office365.com (2603:10b6:408:130::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Wed, 5 May 2021 06:43:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT054.mail.protection.outlook.com (10.13.177.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4087.27 via Frontend Transport; Wed, 5 May 2021 06:43:02 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 5 May 2021 06:42:55 +0000 From: Bing Zhao To: , , CC: , , Date: Wed, 5 May 2021 09:41:00 +0300 Message-ID: <20210505064104.30248-14-bingz@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210505064104.30248-1-bingz@nvidia.com> References: <20210427153811.11554-1-bingz@nvidia.com> <20210505064104.30248-1-bingz@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c8f9acb-a0e2-41de-51c0-08d90f9107c4 X-MS-TrafficTypeDiagnostic: BN8PR12MB3251: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YX8kQrmwTeoaGEefapLZyyfDiVdZkEhiEU8G/itLsV/pkSrQ1KhtXuJNwSlRm7YvWHIBHqatJ8lTszhUwz8NKyr0QoFqR1WBcoF3z4q1KrYTSv2aWiufOZVVbxkRHZsiNdWjmORqSvcdkdAJmUL0Npkc5HQFvMKJ6aUmVijtIP1NCFbmkZAbKZVSXbIsUYFfCtTEzC94muTE5EsnpOpppYZNp5b3+bBeO2NoiJQB3x99gID4vGIQVbJPB1PLcjdsOGUGeMNEw/DuSb25VWNspkqL30ur7fTB8wlCD+oJEDvG7lAkdU2qt67DTVazZjpIcad5sKd0NbhPQiIptFYKf1AsSn/RvEt93RsTDx/Csw/9CmNmIEx6XmlvEAggUiiytcLlPeruyI1ecrLdWOxlcvk39cqWLNMaSVojCKuQQ2fbKwwHUptIEneJO7FSgxReZB3JtG0CcHlzsgUNOM6FfYeXUWT+HCUGgO3pgEZnZlOgRwSncL3ir1AxJad2IR1Op4BbLZ8Cimqrf2e0bL6pcW5XTELiQ5ae0O2F1BX++7eOSyyu4U22Y6SDVO2147kBNuu67Ty7lrkIqacF2ZwSIXb6084/Troud51X81Z+1YEi7oQwIv00TzXV+23plnmgd/mduyMIJZIqDIPgL9xoOh1kTD0ej2flBD6A/uvONylKRUF9cbAPXl0K0wX3th3i X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(36840700001)(46966006)(7696005)(82740400003)(4326008)(356005)(8676002)(2616005)(26005)(15650500001)(8936002)(186003)(36756003)(55016002)(82310400003)(16526019)(426003)(336012)(107886003)(6286002)(2906002)(7636003)(83380400001)(70206006)(316002)(54906003)(110136005)(36860700001)(1076003)(70586007)(36906005)(86362001)(6666004)(47076005)(5660300002)(478600001)(309714004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2021 06:43:02.2688 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c8f9acb-a0e2-41de-51c0-08d90f9107c4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3251 Subject: [dpdk-dev] [PATCH v3 13/17] net/mlx5: add CT context update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When updating a connection tracking context, two separate parts could be updated. First, the direction. This will only update the traffic direction recorded in the software for flow creation. Second, the TCP parameters. The hardware context will be updated via the WQE. This update will be blocked until the hardware status is updated and ready for the next flow creation. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_dv.c | 56 +++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index b0858e3df8..6afbbbc4bb 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -13824,6 +13824,60 @@ __flow_dv_action_rss_update(struct rte_eth_dev *dev, uint32_t idx, return ret; } +/* + * Updates in place conntrack context or direction. + * Context update should be synchronized. + * + * @param[in] dev + * Pointer to the Ethernet device structure. + * @param[in] idx + * The conntrack object ID to be updated. + * @param[in] update + * Pointer to the structure of information to update. + * @param[out] error + * Perform verbose error reporting if not NULL. Initialized in case of + * error only. + * + * @return + * 0 on success, otherwise negative errno value. + */ +static int +__flow_dv_action_ct_update(struct rte_eth_dev *dev, uint32_t idx, + const struct rte_flow_modify_conntrack *update, + struct rte_flow_error *error) +{ + struct mlx5_priv *priv = dev->data->dev_private; + struct mlx5_aso_ct_action *ct; + const struct rte_flow_action_conntrack *new_prf; + int ret = 0; + + ct = flow_aso_ct_get_by_idx(dev, idx); + if (!ct->refcnt) + return rte_flow_error_set(error, ENOMEM, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, + "CT object is inactive"); + new_prf = &update->new_ct; + if (update->direction) + ct->is_original = !!new_prf->is_original_dir; + if (update->state) { + ret = mlx5_aso_ct_update_by_wqe(priv->sh, ct, new_prf); + if (ret) + return rte_flow_error_set(error, EIO, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, + "Failed to send CT context update WQE"); + /* Block until ready or a failure. */ + ret = mlx5_aso_ct_available(priv->sh, ct); + if (ret) + rte_flow_error_set(error, rte_errno, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, + "Timeout to get the CT update"); + } + return ret; +} + /** * Updates in place shared action configuration, lock free, * (mutex should be acquired by caller). @@ -13859,6 +13913,8 @@ flow_dv_action_update(struct rte_eth_dev *dev, case MLX5_INDIRECT_ACTION_TYPE_RSS: action_conf = ((const struct rte_flow_action *)update)->conf; return __flow_dv_action_rss_update(dev, idx, action_conf, err); + case MLX5_INDIRECT_ACTION_TYPE_CT: + return __flow_dv_action_ct_update(dev, idx, update, err); default: return rte_flow_error_set(err, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,