[PATCH-V2] config/arm: restore support for Qualcomm servers
Checks
Commit Message
From the documentation:
"The SoC configuration is a combination of implementer and CPU part number
configuration and SoC-specific configuration."
Align Qualcomm SoC configuration with the configuration of other server
SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
implementer configuration.
Fixes: f2340c858046 ("config/arm: add platform config option")
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V2:
- use the right original commit in Fixes
---
config/arm/meson.build | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, April 29, 2021 10:07 AM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa
> Nagarahalli <honnappa.nagarahalli@arm.com>; Ruifeng Wang
> <ruifeng.wang@arm.com>
> Subject: [PATCH-V2] config/arm: restore support for Qualcomm servers
>
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part number
> configuration and SoC-specific configuration."
>
> Align Qualcomm SoC configuration with the configuration of other server SoCs
> (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer
> configuration.
>
> Fixes: f2340c858046 ("config/arm: add platform config option")
>
Since this is just adding new soc configuration, I don't think it's actually fixing anything.
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2:
> - use the right original commit in Fixes
> ---
> config/arm/meson.build | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 22cd81319c06..4518b7e877b3 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -298,6 +298,13 @@ soc_octeontx2 = {
> 'numa': false
> }
>
> +soc_qualcomm = {
> + 'description': 'Qualcomm Centriq 2400',
> + 'implementer': '0x51',
> + 'part_number': '0xc00',
> + 'numa': false
> +}
> +
> soc_stingray = {
> 'description': 'Broadcom Stingray',
> 'implementer': '0x41',
> @@ -334,6 +341,7 @@ socs = {
> 'n1sdp': soc_n1sdp,
> 'n2': soc_n2,
> 'octeontx2': soc_octeontx2,
> + 'qualcomm': soc_qualcomm,
Now that I'm looking at this change, I see that you've added the qualcomm soc here and it's not added to the docs in this patch, but rather the patch which fixes the docs. I think you should move the qualcomm doc addition to this patch (and the other patch would just have the fixes).
> 'stingray': soc_stingray,
> 'thunderx2': soc_thunderx2,
> 'thunderxt88': soc_thunderxt88
> --
> 2.29.2
>
@@ -298,6 +298,13 @@ soc_octeontx2 = {
'numa': false
}
+soc_qualcomm = {
+ 'description': 'Qualcomm Centriq 2400',
+ 'implementer': '0x51',
+ 'part_number': '0xc00',
+ 'numa': false
+}
+
soc_stingray = {
'description': 'Broadcom Stingray',
'implementer': '0x41',
@@ -334,6 +341,7 @@ socs = {
'n1sdp': soc_n1sdp,
'n2': soc_n2,
'octeontx2': soc_octeontx2,
+ 'qualcomm': soc_qualcomm,
'stingray': soc_stingray,
'thunderx2': soc_thunderx2,
'thunderxt88': soc_thunderxt88